Need % hp/mn command

[Stanos]

Hi.
Does anyone have command that when you type !percentage its makes your health/mana to % and if you type it again it makes your health/mana to normal so its like turning on/off with the same command.
TFS 1.2
Client 8.60

 

[Jacobs]

Making stats display in % requires client edits afaik.
Thus it is not a command - you do not tell the server to change anything, this is purely client side and quite a bit more tricky - though you could make it more player friendly and just change it via a button.

 

[Infernum]

it's not client sided, it's source edits inside of ProtocolGame::AddPlayerStats
you'd have to open up ProtocolGame::sendStats to a lua function such as Player.sendStats and inside of AddPlayerStats check for storage value of the player and add the health/mana values accordingly

 

[Jacobs]

Actually, yeah, it's a source edit, sorry for my lack of knowledge.
Yeah, it should totally be possible then as @Vulcan_ said.

 

[gudan garam]

Change lines 2885 and 2886 (protocolgame.cpp): otland/forgottenserver

from:

msg.add<uint16_t>(std::min<int32_t>(player->getHealth(), std::numeric_limits<uint16_t>::max()));
msg.add<uint16_t>(std::min<int32_t>(player->getMaxHealth(), std::numeric_limits<uint16_t>::max()));

to:

if (player->showHealthAsPercentage) {
        if (player->getMaxHealth() > 0) {
            msg.add<uint16_t>(player->getHealth() * 100 / player->getMaxHealth());
            msg.add<uint16_t>(100);
        } else {
            msg.add<uint16_t>(0);
            msg.add<uint16_t>(0);
        }
    } else {
        msg.add<uint16_t>(std::min<int32_t>(player->getHealth(), std::numeric_limits<uint16_t>::max()));
        msg.add<uint16_t>(std::min<int32_t>(player->getMaxHealth(), std::numeric_limits<uint16_t>::max()));
    }

Change lines 2902 and 2903 (protocolgame.cpp): otland/forgottenserver

from:

msg.add<uint16_t>(std::min<int32_t>(player->getMana(), std::numeric_limits<uint16_t>::max()));
msg.add<uint16_t>(std::min<int32_t>(player->getMaxMana(), std::numeric_limits<uint16_t>::max()));

to:

if (player->showManaAsPercentage) {
        if (player->getMaxMana() > 0) {
            msg.add<uint16_t>(player->getMana() * 100 / player->getMaxMana());
            msg.add<uint16_t>(100);
        }
        else {
            msg.add<uint16_t>(0);
            msg.add<uint16_t>(0);
        }
    }
    else {
        msg.add<uint16_t>(std::min<int32_t>(player->getMana(), std::numeric_limits<uint16_t>::max()));
        msg.add<uint16_t>(std::min<int32_t>(player->getMaxMana(), std::numeric_limits<uint16_t>::max()));
    }

player.h (otland/forgottenserver)

after:

bool hasLearnedInstantSpell(const std::string& spellName) const;

add:

bool showManaAsPercentage = false;
bool showHealthAsPercentage = false;

luascript.cpp (otland/forgottenserver)

after:

registerMethod("Player", "getFightMode", LuaScriptInterface::luaPlayerGetFightMode);

add:

registerMethod("Player", "toggleStatsAsPercentage", LuaScriptInterface::luaPlayertoggleStatsAsPercentage);

luascript.cpp (otland/forgottenserver)

add:

int LuaScriptInterface::luaPlayertoggleStatsAsPercentage(lua_State* L)
{
    // player:toggleStatsAsPercentage()
    Player* player = getUserdata<Player>(L, 1);
    if (player) {
        player->showManaAsPercentage = !player->showManaAsPercentage;
        player->showHealthAsPercentage = !player->showHealthAsPercentage;
        player->sendStats();
        lua_pushboolean(L, player->showHealthAsPercentage);
    } else {
        lua_pushnil(L);
    }
    return 1;
}

luascript.h (otland/forgottenserver)

after:

static int luaPlayerGetFightMode(lua_State* L);

add:

static int luaPlayertoggleStatsAsPercentage(lua_State* L);

We are done with the sources, lets create the talkaction:

data/talkactions/talkactions.xml:

<talkaction words="/togglestats" separator=" " script="toggle_stats.lua" />

data/talkactions/scripts/toggle_stats.lua:

function onSay(player, words, param)
    if player:toggleStatsAsPercentage() then
        -- player is now using percentage notation, you can send him a message.
    else
        -- player is now using normal notation, you can send him a message.
    end
    return false
end

If I haven't missed anything, this should work.
I made it 2 separated booleans so you could easily change it a little bit and let players choose health and mana separately.

 

[Infernum]

or you can do that i guess
nice

 

[Stanos]

Change lines 2885 and 2886 (protocolgame.cpp): otland/forgottenserver

from:

msg.add<uint16_t>(std::min<int32_t>(player->getHealth(), std::numeric_limits<uint16_t>::max()));
msg.add<uint16_t>(std::min<int32_t>(player->getMaxHealth(), std::numeric_limits<uint16_t>::max()));

to:

if (player->showHealthAsPercentage) {
        if (player->getMaxHealth() > 0) {
            msg.add<uint16_t>(player->getHealth() * 100 / player->getMaxHealth());
            msg.add<uint16_t>(100);
        } else {
            msg.add<uint16_t>(0);
            msg.add<uint16_t>(0);
        }
    } else {
        msg.add<uint16_t>(std::min<int32_t>(player->getHealth(), std::numeric_limits<uint16_t>::max()));
        msg.add<uint16_t>(std::min<int32_t>(player->getMaxHealth(), std::numeric_limits<uint16_t>::max()));
    }

Change lines 2902 and 2903 (protocolgame.cpp): otland/forgottenserver

from:

msg.add<uint16_t>(std::min<int32_t>(player->getMana(), std::numeric_limits<uint16_t>::max()));
msg.add<uint16_t>(std::min<int32_t>(player->getMaxMana(), std::numeric_limits<uint16_t>::max()));

to:

if (player->showManaAsPercentage) {
        if (player->getMaxMana() > 0) {
            msg.add<uint16_t>(player->getMana() * 100 / player->getMaxMana());
            msg.add<uint16_t>(100);
        }
        else {
            msg.add<uint16_t>(0);
            msg.add<uint16_t>(0);
        }
    }
    else {
        msg.add<uint16_t>(std::min<int32_t>(player->getMana(), std::numeric_limits<uint16_t>::max()));
        msg.add<uint16_t>(std::min<int32_t>(player->getMaxMana(), std::numeric_limits<uint16_t>::max()));
    }

player.h (otland/forgottenserver)

after:

bool hasLearnedInstantSpell(const std::string& spellName) const;

add:

bool showManaAsPercentage = false;
bool showHealthAsPercentage = false;

luascript.cpp (otland/forgottenserver)

after:

registerMethod("Player", "getFightMode", LuaScriptInterface::luaPlayerGetFightMode);

add:

registerMethod("Player", "toggleStatsAsPercentage", LuaScriptInterface::luaPlayertoggleStatsAsPercentage);

luascript.cpp (otland/forgottenserver)

add:

int LuaScriptInterface::luaPlayertoggleStatsAsPercentage(lua_State* L)
{
    // player:toggleStatsAsPercentage()
    Player* player = getUserdata<Player>(L, 1);
    if (player) {
        player->showManaAsPercentage = !player->showManaAsPercentage;
        player->showHealthAsPercentage = !player->showHealthAsPercentage;
        player->sendStats();
        lua_pushboolean(L, player->showHealthAsPercentage);
    } else {
        lua_pushnil(L);
    }
    return 1;
}

luascript.h (otland/forgottenserver)

after:

static int luaPlayerGetFightMode(lua_State* L);

add:

static int luaPlayertoggleStatsAsPercentage(lua_State* L);

We are done with the sources, lets create the talkaction:

data/talkactions/talkactions.xml:

<talkaction words="/togglestats" separator=" " script="toggle_stats.lua" />

data/talkactions/scripts/toggle_stats.lua:

function onSay(player, words, param)
    if player:toggleStatsAsPercentage() then
        -- player is now using percentage notation, you can send him a message.
    else
        -- player is now using normal notation, you can send him a message.
    end
    return false
end

If I haven't missed anything, this should work.
I made it 2 separated booleans so you could easily change it a little bit and let players choose health and mana separately.

Perfection