Need script onLogin

[phern]

Hi there!
I want to make an script that is repeating some effect on player every one second.
I think the best would be onLogin function in creaturescripts, but I have always had troubles with repeating functions.

It should look something like that:

function onLogin(cid)  
 if getPlayerGroupId(cid) == 6 or getPlayerGroupId(cid) == 4 then
<repeating effect no. 14 every one second>
end

I would really appreciate help.
Thanks in advance.

 

[VirrageS]

I think that will better and simple if this script will be in globalevents.

 

[phern]

I dont understand how You want to put it into globalevents but go on.

 

[SpiderOT]

in creaturescripts.xml add this

<event type="login" name="effect" event="script" value="effect.lua"/>

and register it in login.lua

registerCreatureEvent(cid, "effect")

now create effect.lua

local function effect(cid)
    for _, name in ipairs(getOnlinePlayers()) do
        if (cid) == getPlayerByName(name) then
	doSendMagicEffect(getCreaturePosition(cid), 14)
    addEvent(effect, 1 * 1000, cid)
end
end
end

function onLogin(cid)
     if getPlayerGroupId(cid) == 6 or getPlayerGroupId(cid) == 4 then
        addEvent(effect, 1 * 1000, cid)
    end
    return TRUE
end

 

[Cykotitan]

local function effect(cid)
	if isPlayer(cid) then
		doSendMagicEffect(getThingPos(cid), 14)
		addEvent(effect, 1000, cid)
	end
end

function onLogin(cid)
	if isInArray({4, 6}, getPlayerGroupId(cid)) then
		addEvent(effect, 1000, cid)
	end
	return true
end