TFS 1.X+ nekiro tfs 1.5 - exchange the item on the floor for the item in the hand

[bpm91]

possibility to pull the item directly from the ground into the character's hand and exchange the items
would anyone know how to fix this?

 

[dewral]

well that's not really important but if someone know the fix i will be interested xD

 

[Paulix]

I'm also interested in this, looks like you can already swap items if they're inside your backpack, it will probably need to edit sources, it might be something related to cylinders, but I've no idea how to fix

 

[Rugged Mage]

@Paulix @dewral @bpm91 I fixed this problem by changing the following code in player.cpp

    //need an exchange with source? (destination item is swapped with currently moved item)
    const Item* inventoryItem = getInventoryItem(static_cast<slots_t>(index));
    if (inventoryItem && (!inventoryItem->isStackable() || inventoryItem->getID() != item->getID())) {
        const Cylinder* cylinder = item->getTopParent();
        if (cylinder && (dynamic_cast<const DepotChest*>(cylinder) || dynamic_cast<const Player*>(cylinder))) {
            return RETURNVALUE_NEEDEXCHANGE;
        }
        return RETURNVALUE_NOTENOUGHROOM;
    }

to

    //need an exchange with source? (destination item is swapped with currently moved item)
    const Item* inventoryItem = getInventoryItem(static_cast<slots_t>(index));
    if (inventoryItem && (!inventoryItem->isStackable() || inventoryItem->getID() != item->getID())) {
        const Cylinder* cylinder = item->getTopParent();
        if (cylinder) {
            return RETURNVALUE_NEEDEXCHANGE;
        }
        return RETURNVALUE_NOTENOUGHROOM;
}

 

[bpm91]

work 100% ty ty ty \o

 

[dewral]

@Paulix @dewral @bpm91 I fixed this problem by changing the following code in player.cpp

    //need an exchange with source? (destination item is swapped with currently moved item)
    const Item* inventoryItem = getInventoryItem(static_cast<slots_t>(index));
    if (inventoryItem && (!inventoryItem->isStackable() || inventoryItem->getID() != item->getID())) {
        const Cylinder* cylinder = item->getTopParent();
        if (cylinder && (dynamic_cast<const DepotChest*>(cylinder) || dynamic_cast<const Player*>(cylinder))) {
            return RETURNVALUE_NEEDEXCHANGE;
        }
        return RETURNVALUE_NOTENOUGHROOM;
    }

to

    //need an exchange with source? (destination item is swapped with currently moved item)
    const Item* inventoryItem = getInventoryItem(static_cast<slots_t>(index));
    if (inventoryItem && (!inventoryItem->isStackable() || inventoryItem->getID() != item->getID())) {
        const Cylinder* cylinder = item->getTopParent();
        if (cylinder) {
            return RETURNVALUE_NEEDEXCHANGE;
        }
        return RETURNVALUE_NOTENOUGHROOM;
}

@Nekiro I made a PR for this if you want to test it out sometime.

Thank you, it worked

 

[Evil Puncker]

just undo these changes instead:

Only allow NEEDEXCHANGE in Player/Depot (#2836) · otland/forgottenserver@e549ad2

A free and open-source MMORPG server emulator written in C++ - Only allow NEEDEXCHANGE in Player/Depot (#2836) · otland/forgottenserver@e549ad2

github.com

 

[Nekiro]

Just for reference and for other visitors
You have to revert this commit: Only allow NEEDEXCHANGE in Player/Depot (#2836) · otland/forgottenserver@e549ad2 (https://github.com/otland/forgottenserver/commit/e549ad2368abf104a3cdefb09bf0815f22cad028)
(f, was late @Evil Puncker mentioned it already)

I agree that this behaviour should be tied to classicSlots, I might add it later to tfs

 

[johnsamir]

@Paulix @dewral @bpm91 I fixed this problem by changing the following code in player.cpp

    //need an exchange with source? (destination item is swapped with currently moved item)
    const Item* inventoryItem = getInventoryItem(static_cast<slots_t>(index));
    if (inventoryItem && (!inventoryItem->isStackable() || inventoryItem->getID() != item->getID())) {
        const Cylinder* cylinder = item->getTopParent();
        if (cylinder && (dynamic_cast<const DepotChest*>(cylinder) || dynamic_cast<const Player*>(cylinder))) {
            return RETURNVALUE_NEEDEXCHANGE;
        }
        return RETURNVALUE_NOTENOUGHROOM;
    }

to

    //need an exchange with source? (destination item is swapped with currently moved item)
    const Item* inventoryItem = getInventoryItem(static_cast<slots_t>(index));
    if (inventoryItem && (!inventoryItem->isStackable() || inventoryItem->getID() != item->getID())) {
        const Cylinder* cylinder = item->getTopParent();
        if (cylinder) {
            return RETURNVALUE_NEEDEXCHANGE;
        }
        return RETURNVALUE_NOTENOUGHROOM;
}

@Nekiro I made a PR for this if you want to test it out sometime.

In interested too, thank you