Next script problem

[Darqneez]

hello, I'd like to change this script made by wesoly136

local rune = {cost = 6500, item_id = 2268, item_id_count = 100, count = 1, drop = false}
function onUse(cid, item, fromPosition, itemEx, toPosition)
if getPlayerMoney(cid) >= rune.cost then
if doPlayerAddItem(cid, rune.item_id,rune.item_id_count,false) then
doPlayerRemoveMoney(cid, rune.cost)
doPlayerAddItem(cid, rune.item_id,rune.item_id_count,false)
doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "You have bought a sudden death rune.")
else
doPlayerSendTextMessage (cid, MESSAGE_INFO_DESCR, "You don\'t have enough container")
end
else
doPlayerSendTextMessage (cid, MESSAGE_INFO_DESCR, "You don\'t have enough money")
end
end

to script which creates a backpack filled with potions.
I tried to make my own script but it doesnt work. Can someone help me? Here's my not working script:

local rune = {cost = 3800, item_id = 7591, item_id_count = 1, count = 20, drop = false, bp_id = 2000}
function onUse(cid, item, fromPosition, itemEx, toPosition)
if getPlayerMoney(cid) >= rune.cost then
local new_container = doCreateItemEx(cid, rune.bp_id, 1)
if doAddContainerItem(new_container, rune.item_id,rune.item_id_count,false) then
doPlayerRemoveMoney(cid, rune.cost)
doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "You have bought backpack filled with great health potions.")
else
doPlayerSendTextMessage (cid, MESSAGE_INFO_DESCR, "You don\'t have enough capacity")
end
else
doPlayerSendTextMessage (cid, MESSAGE_INFO_DESCR, "You don\'t have enough money")
end
end

 

[JDB]

Here

 

[Darqneez]

But I want to learn something, that's why I'd like you to show me what do I wrong in my script :\

 

[menfes]

Are there any errors? Maybe some boolean error?

 

[Cykotitan]

local rune = {cost = 3800, id = 7591, count = 1, bp = 2000}
function onUse(cid, item, fromPosition, itemEx, toPosition)
	if getPlayerMoney(cid) >= rune.cost then
		if getPlayerFreeCap(cid) >= getItemInfo(rune.id).weight * getItemInfo(rune.bp).maxItems + getItemInfo(rune.bp).weight then
			local v = doCreateItemEx(rune.bp)
			for i = 1, getContainerCap(v) do
				doAddContainerItem(v, rune.id, rune.count)
			end
			if doPlayerAddItemEx(cid, v) == 1 then
				doPlayerRemoveMoney(cid, rune.cost)
				doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "You have bought a backpack filled with " .. getItemInfo(rune.id).plural .. ".")
			else
				doPlayerSendTextMessage (cid, MESSAGE_INFO_DESCR, "You don't have enough free space.")
			end
		else
			doPlayerSendTextMessage (cid, MESSAGE_INFO_DESCR, "You don't have enough capacity.")
		end
	else
		doPlayerSendTextMessage (cid, MESSAGE_INFO_DESCR, "You don't have enough money")
	end
	return true
end

 

[Fallen]

local rune = {cost = 3800, id = 7591, count = 1, bp = 2000}
function onUse(cid, item, fromPosition, itemEx, toPosition)
	if getPlayerMoney(cid) >= rune.cost then
		local v = doCreateItemEx(rune.bp)
		for i = 1, getContainerCap(v) do
			doAddContainerItem(v, rune.id, rune.count)
		end
		if doPlayerAddItemEx(cid, v) == 1 then
			doPlayerRemoveMoney(cid, rune.cost)
			doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, "You have bought a backpack filled with " .. getItemInfo(rune.id).plural .. ".")
		else
			doPlayerSendTextMessage (cid, MESSAGE_INFO_DESCR, "You don't have enough capacity or free space.")
		end
	else
		doPlayerSendTextMessage (cid, MESSAGE_INFO_DESCR, "You don't have enough money")
	end
	return true
end

hunted

 

[menfes]

@Darqneez
I think you missed the action where it adds the container to the player. You only have "if doAddContainerItem".