Solved No damage to teammates TFS 1.0

[narko]

function onStatsChange(cid, attacker, type, combat, value)
    if type == 1 and getCreatureHealth(cid) <= value then
        if(getGlobalStorageValue(33165) == 1) then
                elseif isPlayer(attacker) and isPlayer(cid) then
                    if isPlayer then
                        if tostring(getPlayerStorageValue(cid, 16391)) == tostring(getPlayerStorageValue(cid, 16391)) then
                            return false
                        end
                    end
                end
                return true
            end
    end

I've been trying something like this, but when a player attacks an enemie it hits no DMG and when attacks a teammate either. @Limos just tagging you if you'd like to help me

 

[Limos]

Which TFS 1.0 version do you use? The default one doesn't have statschange, it has healthchange and manachange.

 

[narko]

I am using this patch:
https://otland.net/threads/onstatschange-for-tfs-1-0.212654/ however if there is a way to make it work with onHealthChange that'd be really helpful.

 

[Evan]

You can do this with onTargetCombat() and onAreaCombat() very simply, you'd just have to update to 1.1.
1.0 is still good, but 1.1 has SO much more.

 

[narko]

Yes, I had worked with tfs 1.1 and it has lots of new functions that tfs 1.0 doesn't, but unfortunately my server is based on 1.0 and I have to adapt the whole datapack and really don't want to do that.

 

[WibbenZ]

Ehm no...
The main thing you have to change is the way arrows etc gets removed. That was moved from items.xml to weapons.xml
You can still utilize the compat.lua file.

 

[narko]

Well that is something that im not interesting in. That is why I need a little help with this ^^^

 

[narko]

Bump

 

[Evil Puncker]

better adapt it now since you will be forced to move once you note that there are so many bugs being fixed in 1.1 that you server you not have

 

[narko]

Yes I will, but for the meanwhile I need it for TFS 1.0. if someone could help with this please.

 

[Limos]

When exactly is someone a teammate? Is this based on storage, party or something else?
If it's based on storage, do they both have the same storage value? Which storage and which value?

You can just check for isPlayer(attacker) and the storagevalue of both cid and attacker.

if isPlayer(attacker) and getPlayerStorageValue(cid, 16391) == getPlayerStorageValue(attacker, 16391) then

With TFS 1.0 functions

local player, attacker = Player(cid), Player(attacker)
if attacker and player:getStorageValue(16391) == attacker:getStorageValue(16391) then

If it needs to be both for example 1 you can compare both with 1.
Then return false if it's true.
Add return true above the last end.

 

[narko]

red storage = 15000
blue storage = 1600

function onStatsChange(cid, attacker, type, combat, value)
    if type == 1 and getCreatureHealth(cid) <= value then
        if(getGlobalStorageValue(33165) == 1) then -- global storage when the event is running
                elseif isPlayer(attacker) and isPlayer(cid) then
                    if isPlayer then
                        if tostring(getPlayerStorageValue(cid, 15000)) == tostring(getPlayerStorageValue(attacker, 15000)) then  --- Check storages if they are the same 
                            return false
                        end
                    end
                end
                return true
            end
    end

 

[Limos]

if Game.getStorageValue(33165) ~= 1 then
     return true
end
local player, attacker = Player(cid), Player(attacker)
if type == 1 and attacker and (player:getStorageValue(15000) == attacker:getStorageValue(15000) or player:getStorageValue(1600) == attacker:getStorageValue(1600)) then
     return false
end

 

[narko]

Players still damage each other.

code:

function onStatsChange(cid, attacker, type, combat, value)

if Game.getStorageValue(33165) ~= 1 then
     return true
end

local player, attacker = Player(cid), Player(attacker)
if type == 1 and attacker and (player:getStorageValue(15391) == attacker:getStorageValue(15391) or player:getStorageValue(15392) == attacker:getStorageValue(15392)) then
     return false
end
end

Do I have something wrong?

 

[Limos]

How did you registered it? Can you post the creaturescripts.xml and login.lua line?
You can also do: (type == 1 or type == 3) instead of just type == 1.

You can test results with print, for example

print(player:getStorageValue(15391))

 

[narko]

creaturescripts.xml

<event type="statschange" name="States" script="events/rushcombat.lua"/>

login.lua

local events = {
     'States',
}

 

[Limos]

I mean the register function aswell in login.lua. Did you tested with print if you saw anything in your console?

 

[narko]

Actually last bug was produced because the event storage was always enable so I disabled and now getting this attacking teammates and enemies also.

No damage against enemies or teammates.

 

[Limos]

Add return true above the last end.

 

[narko]

It worked thanks alot man!