C++ Nostalrius Bug

[gohamvsgoku]

Hello, anyone that work with nostalrius engine fixed this issue?

Monters and field damage · Issue #21 · Ezzz-dev/Nostalrius

Video reporting the problem https://streamable.com/hgpp9 when the monsters are immune to certain damage, can not receive the effect until the damage is done. ReaLots test video (experimental realot...

github.com

There is a fix for this, but it doesn't work very well, the monsters continue with the effect once.

if someone found the correct solution, I thank you for sharing.

 

[gohamvsgoku]

Up

 

[Beo]

Fix #21 by nekiro · Pull Request #45 · Ezzz-dev/Nostalrius

Fix #21

github.com

Solution is here

 

[gohamvsgoku]

Fix #21 by nekiro · Pull Request #45 · Ezzz-dev/Nostalrius

Fix #21

github.com

Solution is here

No work, with this fix mosters immune effect only disappear after 1 round tick...

 

[gohamvsgoku]

Up

 

[gohamvsgoku]

Up

 

[pink_panther]

No work, with this fix mosters immune effect only disappear after 1 round tick...

What do you mean?

 

[gohamvsgoku]

What do you mean?

For eg, if a demon skeleton walk under a poison field, u will see after some seconds the green rings effect on demon skeleton, just one time... the correct is never appear effect on demon skeleton because is imunne of poison.

 

[pink_panther]

For eg, if a demon skeleton walk under a poison field, u will see after some seconds the green rings effect on demon skeleton, just one time... the correct is never appear effect on demon skeleton because is imunne of poison.

But what does that Fix do?

 

[gohamvsgoku]

But what does that Fix do?

Without the fix the effect continue until the last tick damage.

 

[pink_panther]

Without the fix the effect continue until the last tick damage.

I mean what happens if you apply that fix? Why doesn't it work?

 

[gohamvsgoku]

I mean what happens if you apply that fix? Why doesn't it work?

not happens if apply the "fix"
but the fix is not working properly, the effect should never appear once

 

[pink_panther]

not happens if apply the "fix"
but the fix is not working properly, the effect should never appear once

combat.cpp

Find:
void MagicField::onStepInField(Creature* creature)

before:
"creature->addCondition(conditionCopy);"

add:
if (creature && creature->isImmune(conditionCopy->getType())) {
    return;
}

 

[emil92b]

before - effect every tick until last damage
nekiro - 1 effect tick after monster steps out of field
panther - completely removes any effect

tested on Realots.org - News (http://experimental.realots.org) and this is the result:
if creature is immun to fire/energy/poison, it should only display the effect one time as it steps in on the field.
the effect depends on what element it steps on, example (fire and energy will display "spark" and poison will display "poison"

 

[pink_panther]

before - effect every tick until last damage
nekiro - 1 effect tick after monster steps out of field
panther - completely removes any effect

tested on Realots.org - News (http://experimental.realots.org) and this is the result:
if creature is immun to fire/energy/poison, it should only display the effect one time as it steps in on the field.
the effect depends on what element it steps on, example (fire and energy will display "spark" and poison will display "poison"

So picky

        auto combatType = conditionCopy->getType();
        if (creature && creature->isImmune(combatType)) {
            uint8_t hitEffect = 0;
            switch (combatType) {
                case CONDITION_ENERGY:
                case CONDITION_FIRE: {
                    hitEffect = CONST_ME_BLOCKHIT;
                    break;
                }
                case CONDITION_POISON: {
                    hitEffect = CONST_ME_GREEN_RINGS;
                    break;
                }
                default: {
                    hitEffect = CONST_ME_POFF;
                    break;
                }
            }

            g_game.addMagicEffect(getPosition(), hitEffect);
            return;
        }

Put that above "creature->addCondition(conditionCopy);" instead