Npc Add Storage Line Problem

[Angel Of Death]

	elseif msgcontains(msg, "learn skill") then
		if(doPlayerRemoveMoney(cid, 5000) == true) then
		if getPlayerStorageValue(cid,storage) < 0 then
		doPlayersetPlayerStorageValue(cid, 60010, 1)

how do i do this properly

 

[Kakaher]

	elseif msgcontains(msg, "learn skill") then
		if(doPlayerRemoveMoney(cid, 5000) == true) then
		if getPlayerStorageValue(cid,storage) < 0 then
		doPlayersetPlayerStorageValue(cid, 60010, 1)

how do i do this properly

Change that code to this one:

 elseif msgcontains(msg, "learn skill") then
		if(doPlayerRemoveMoney(cid, 5000) == true) then
		if getPlayerStorageValue(cid,storage) < 0 then
		setPlayerStorageValue(cid, 60010, 1)

Hope it helps

---EDIT

BTW, I would even change it to this:

 elseif msgcontains(msg, "learn skill") then
		if(doPlayerRemoveMoney(cid, 5000) == true) and  getPlayerStorageValue(cid,storage) < 0 then
		setPlayerStorageValue(cid, 60010, 1)

because of 2 reasons:
1- Remove "if's"
2- The way the script was written, the NPC would remove the player money even if he had the storage value, and this way it will not happen =p

 

[Angel Of Death]

thanks it works

 

[Kakaher]

thanks it works

No problem