• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

Lua Npc are not responding, 0.3.7

niti

niti

New Member
Joined
Nov 22, 2009
Messages
258
Reaction score
2
Hello all. I'm using TFS 0.3.7, and the npc:S are not responding to me when I say Hi, What's wrong?

[21:36:07.926] [Error - NpcScript Interface]
[21:36:07.926] data/npc/scripts/runes.lua:eek:nCreatureSay
[21:36:07.926] Description:
[21:36:07.926] data/npc/lib/npc.lua:51: attempt to call global 'isValidPosition' (a nil value)
[21:36:07.926] stack traceback:
[21:36:07.926] data/npc/lib/npc.lua:51: in function 'getNpcDistanceTo'
[21:36:07.926] data/npc/lib/npcsystem/npchandler.lua:631: in function 'isInRange'
[21:36:07.926] data/npc/lib/npcsystem/npchandler.lua:446: in function 'onCreatureSay'
[21:36:07.926] data/npc/scripts/runes.lua:8: in function <data/npc/scripts/runes.lua:8>
This is the respond in the Distro. What should I do?

bump
 
Last edited by a moderator:
Sort by date Sort by votes
attempt to call global 'isValidPosition' (a nil value)
Click to expand...
Anytime you see a nil value for a function that usually means the function doesn't exist. In this case that function is: isValidPosition(position)

Add this function to your 032-position.lua lib:

Code: 
function isValidPosition(position)
    return (isNumeric(position.x .. position.y .. position.z) and position.x > 0
        and position.y > 0 and position.z >= 0 and position.z <= 15)
end

Also if you continue to run into missing functions then maybe you need to update your libraries.
 
Upvote 0 Downvote
imkingran said:
Anytime you see a nil value for a function that usually means the function doesn't exist. In this case that function is: isValidPosition(position)

Add this function to your 032-position.lua lib:

Code: 
function isValidPosition(position)
    return (isNumeric(position.x .. position.y .. position.z) and position.x > 0
        and position.y > 0 and position.z >= 0 and position.z <= 15)
end

Also if you continue to run into missing functions then maybe you need to update your libraries.
Click to expand...
Hi, could you edit it to my script? Would be helpful since I dunno how to do it.


Code: 
function isInRange(position, fromPosition, toPosition)
    return (position.x >= fromPosition.x and position.y >= fromPosition.y and position.z >= fromPosition.z and position.x <= toPosition.x and position.y <= toPosition.y and position.z <= toPosition.z)
end

function getDistanceBetween(fromPosition, toPosition)
    local x, y = math.abs(fromPosition.x - toPosition.x), math.abs(fromPosition.y - toPosition.y)
    local diff = math.max(x, y)
    if(fromPosition.z ~= toPosition.z) then
        diff = diff + 9 + 6
    end

    return diff
end

function getDirectionTo(pos1, pos2)
    local dir = NORTH
    if(pos1.x > pos2.x) then
        dir = WEST
        if(pos1.y > pos2.y) then
            dir = NORTHWEST
        elseif(pos1.y < pos2.y) then
            dir = SOUTHWEST
        end
    elseif(pos1.x < pos2.x) then
        dir = EAST
        if(pos1.y > pos2.y) then
            dir = NORTHEAST
        elseif(pos1.y < pos2.y) then
            dir = SOUTHEAST
        end
    else
        if(pos1.y > pos2.y) then
            dir = NORTH
        elseif(pos1.y < pos2.y) then
            dir = SOUTH
        end
    end

    return dir
end

function getCreatureLookPosition(cid)
    return getPosByDir(getThingPos(cid), getCreatureLookDirection(cid))
end

function getPositionByDirection(position, direction, size)
    local n = size or 1
    if(direction == NORTH) then
        position.y = position.y - n
    elseif(direction == SOUTH) then
        position.y = position.y + n
    elseif(direction == WEST) then
        position.x = position.x - n
    elseif(direction == EAST) then
        position.x = position.x + n
    elseif(direction == NORTHWEST) then
        position.y = position.y - n
        position.x = position.x - n
    elseif(direction == NORTHEAST) then
        position.y = position.y - n
        position.x = position.x + n
    elseif(direction == SOUTHWEST) then
        position.y = position.y + n
        position.x = position.x - n
    elseif(direction == SOUTHEAST) then
        position.y = position.y + n
        position.x = position.x + n
    end

    return position
end

function doComparePositions(position, positionEx)
    return position.x == positionEx.x and position.y == positionEx.y and position.z == positionEx.z
end

function getArea(position, x, y)
    local t = {}
    for i = (position.x - x), (position.x + x) do
        for j = (position.y - y), (position.y + y) do
            table.insert(t, {x = i, y = j, z = position.z})
        end
    end

    return t
end
 
Upvote 0 Downvote
niti said:
Hi, could you edit it to my script? Would be helpful since I dunno how to do it.


Code: 
function isInRange(position, fromPosition, toPosition)
    return (position.x >= fromPosition.x and position.y >= fromPosition.y and position.z >= fromPosition.z and position.x <= toPosition.x and position.y <= toPosition.y and position.z <= toPosition.z)
end

function getDistanceBetween(fromPosition, toPosition)
    local x, y = math.abs(fromPosition.x - toPosition.x), math.abs(fromPosition.y - toPosition.y)
    local diff = math.max(x, y)
    if(fromPosition.z ~= toPosition.z) then
        diff = diff + 9 + 6
    end

    return diff
end

function getDirectionTo(pos1, pos2)
    local dir = NORTH
    if(pos1.x > pos2.x) then
        dir = WEST
        if(pos1.y > pos2.y) then
            dir = NORTHWEST
        elseif(pos1.y < pos2.y) then
            dir = SOUTHWEST
        end
    elseif(pos1.x < pos2.x) then
        dir = EAST
        if(pos1.y > pos2.y) then
            dir = NORTHEAST
        elseif(pos1.y < pos2.y) then
            dir = SOUTHEAST
        end
    else
        if(pos1.y > pos2.y) then
            dir = NORTH
        elseif(pos1.y < pos2.y) then
            dir = SOUTH
        end
    end

    return dir
end

function getCreatureLookPosition(cid)
    return getPosByDir(getThingPos(cid), getCreatureLookDirection(cid))
end

function getPositionByDirection(position, direction, size)
    local n = size or 1
    if(direction == NORTH) then
        position.y = position.y - n
    elseif(direction == SOUTH) then
        position.y = position.y + n
    elseif(direction == WEST) then
        position.x = position.x - n
    elseif(direction == EAST) then
        position.x = position.x + n
    elseif(direction == NORTHWEST) then
        position.y = position.y - n
        position.x = position.x - n
    elseif(direction == NORTHEAST) then
        position.y = position.y - n
        position.x = position.x + n
    elseif(direction == SOUTHWEST) then
        position.y = position.y + n
        position.x = position.x - n
    elseif(direction == SOUTHEAST) then
        position.y = position.y + n
        position.x = position.x + n
    end

    return position
end

function doComparePositions(position, positionEx)
    return position.x == positionEx.x and position.y == positionEx.y and position.z == positionEx.z
end

function getArea(position, x, y)
    local t = {}
    for i = (position.x - x), (position.x + x) do
        for j = (position.y - y), (position.y + y) do
            table.insert(t, {x = i, y = j, z = position.z})
        end
    end

    return t
end
Click to expand...
Your script is fine. Update your library in data/lib/ as instructed.
If we edit your script, then you'll have to patch every script that wants to use this function.
 
Upvote 0 Downvote
Xikini said:
Your script is fine. Update your library in data/lib/ as instructed.
If we edit your script, then you'll have to patch every script that wants to use this function.
Click to expand...
Thanks for helping me, but what should I edit there? and where in LIB what lua should I ediT?
 
Upvote 0 Downvote
niti said:
Thanks for helping me, but what should I edit there? and where in LIB what lua should I ediT?
Click to expand...
imkingran said:
Anytime you see a nil value for a function that usually means the function doesn't exist. In this case that function is: isValidPosition(position)

Add this function to your 032-position.lua lib:

Code: 
function isValidPosition(position)
    return (isNumeric(position.x .. position.y .. position.z) and position.x > 0
        and position.y > 0 and position.z >= 0 and position.z <= 15)
end

Also if you continue to run into missing functions then maybe you need to update your libraries.
Click to expand...
 
Upvote 0 Downvote
Hi! I just did what you told me to now this came up,


Code: 
[12:40:17.957] [Error - NpcScript Interface]
[12:40:17.957] data/npc/scripts/default.lua:onCreatureSay
[12:40:17.957] Description:
[12:40:17.957] data/lib/032-position.lua:78: attempt to call global 'isNumeric' (a nil value                        )
[12:40:17.957] stack traceback:
[12:40:17.957]  data/lib/032-position.lua:78: in function 'isValidPosition'
[12:40:17.957]  data/npc/lib/npc.lua:51: in function 'getNpcDistanceTo'
[12:40:17.957]  data/npc/lib/npcsystem/npchandler.lua:631: in function 'isInRange'
[12:40:17.957]  data/npc/lib/npcsystem/npchandler.lua:446: in function 'onCreatureSay'
[12:40:17.957]  data/npc/scripts/default.lua:7: in function <data/npc/scripts/default.lua:7>
And this is how I added the script that you told me to add:
Data/lib/032-position.lua:

Code: 
function isInRange(position, fromPosition, toPosition)
    return (position.x >= fromPosition.x and position.y >= fromPosition.y and position.z >= fromPosition.z and position.x <= toPosition.x and position.y <= toPosition.y and position.z <= toPosition.z)
end

function getDistanceBetween(fromPosition, toPosition)
    local x, y = math.abs(fromPosition.x - toPosition.x), math.abs(fromPosition.y - toPosition.y)
    local diff = math.max(x, y)
    if(fromPosition.z ~= toPosition.z) then
        diff = diff + 9 + 6
    end

    return diff
end

function getDirectionTo(pos1, pos2)
    local dir = NORTH
    if(pos1.x > pos2.x) then
        dir = WEST
        if(pos1.y > pos2.y) then
            dir = NORTHWEST
        elseif(pos1.y < pos2.y) then
            dir = SOUTHWEST
        end
    elseif(pos1.x < pos2.x) then
        dir = EAST
        if(pos1.y > pos2.y) then
            dir = NORTHEAST
        elseif(pos1.y < pos2.y) then
            dir = SOUTHEAST
        end
    else
        if(pos1.y > pos2.y) then
            dir = NORTH
        elseif(pos1.y < pos2.y) then
            dir = SOUTH
        end
    end

    return dir
end

function getCreatureLookPosition(cid)
    return getPosByDir(getThingPos(cid), getCreatureLookDirection(cid))
end

function getPositionByDirection(position, direction, size)
    local n = size or 1
    if(direction == NORTH) then
        position.y = position.y - n
    elseif(direction == SOUTH) then
        position.y = position.y + n
    elseif(direction == WEST) then
        position.x = position.x - n
    elseif(direction == EAST) then
        position.x = position.x + n
    elseif(direction == NORTHWEST) then
        position.y = position.y - n
        position.x = position.x - n
    elseif(direction == NORTHEAST) then
        position.y = position.y - n
        position.x = position.x + n
    elseif(direction == SOUTHWEST) then
        position.y = position.y + n
        position.x = position.x - n
    elseif(direction == SOUTHEAST) then
        position.y = position.y + n
        position.x = position.x + n
    end

    return position
end

function doComparePositions(position, positionEx)
    return position.x == positionEx.x and position.y == positionEx.y and position.z == positionEx.z
end

function isValidPosition(position)
    return (isNumeric(position.x .. position.y .. position.z) and position.x > 0
        and position.y > 0 and position.z >= 0 and position.z <= 15)
end

function getArea(position, x, y)
    local t = {}
    for i = (position.x - x), (position.x + x) do
        for j = (position.y - y), (position.y + y) do
            table.insert(t, {x = i, y = j, z = position.z})
        end
    end

    return t
end
I dunno if it's right, but yea check it out^^
 
Upvote 0 Downvote
You just have to find the correct name of the function in your files. A function in a code is a reference to another .cpp file (depending on language) that has another code on it. You just need to find the correct name of the file, if missing replace it.
 
Upvote 0 Downvote

Similar threads

S
  • Question
TFS 1.3 upgrade to TFS 1.5 Attempt to index global 'Storage' (a nil value)
Replies
3
Views
198
Mateus Robeerto
Mateus Robeerto
irishman
  • Question
npc not talking
Replies
6
Views
569
Evil Puncker
E
E
  • Solved
TFS 1.X+ Promotion errors after upgrading to tfs 1.5.
Replies
4
Views
407
Erna
E
erikbs
  • Question
NPC console error
Replies
1
Views
316
domciacho
D
J
  • Solved
Problem with npc missions
Replies
4
Views
373
jareczekjsp
J
Michcol94
  • Question
opcode instalation doSendPlayerExtendedOpcode 1.5 Nekiro downgrade 8.6
Replies
7
Views
771
Michcol94
Michcol94
peteralto
  • Solved
TFS 1.X+ attempt to call method getId
Replies
4
Views
334
peteralto
peteralto
OTcreator
  • Question
TFS 1.X+ [1.4.2] Killing in the name of - Rank Problem.
Replies
2
Views
286
Fortera Global
Fortera Global
Z
  • Question
cannot open data/npc/lib/npcsystem/main.lua: No such file or directory
Replies
9
Views
314
ralke
ralke
H
  • Question
TFS 1.X+ data/npc/lib/npcsystem/modules items[itemid] == nil error
Replies
6
Views
391
Mateus Robeerto
Mateus Robeerto
Back
Top Bottom