{NPC + Elfbot}

[LucasFerraz]

I'm using dev 0.4, rev 3884 (8.6).
How to protect NPCs against Elfbot? People are buying itens for free with elfbot. How can I protect NPCs?

This is a CRITICAL BUG that can crash this rev easy. When people start buy itens with Elfbot in any NPCs (Example: Perac) this messages spam the console and don't stop.
I think if more than 10 guys start it in different NPCs the server will crash.

This time my friend was doing in NPC Perac.
PS.: The messages in console show another NPC, I don't know why. Just me and my friend online. (Test Server)

<?xml version="1.0" encoding="UTF-8"?>
<npc name="Perac" script="data/npc/scripts/default.lua" walkinterval="2000" floorchange="0">
    <health now="100" max="100"/>
    <look type="129" head="78" body="52" legs="68" feet="114" addons="0"/>
    <parameters>
        <parameter key="message_greet" value="Oh, please come in, |PLAYERNAME|. What do you need? I sell fine distance weapons and ammunition."/>
        <parameter key="message_farewell" value="Good bye, |PLAYERNAME|."/>
        <parameter key="module_keywords" value="1" />
        <parameter key="keywords" value="job;" />
        <parameter key="keyword_reply1" value="I am the fletcher of Carlin. I am selling bows, crossbows, and ammunition. Do you need anything?" />
        <parameter key="module_shop" value="1"/>
        <parameter key="shop_buyable" value="crossbow,2455,500;bow,2456,400;bolt,2543,4;arrow,2544,3;spear,2389,10;assassin star,7368,100" />
        <parameter key="shop_sellable" value="spear,2389,3;" />

    </parameters>
</npc>

-----------------------------------------------
I'm using libs and npc/libs from rev3884.
-----------------------------------------------
I followed this tutorial and nothing solved.
http://otland.net/f16/cloning-elfbot-urgently-104658/
-----------------------------------------------
Cykotitan said: I don't think that's the lib you're using with the server, because the errors you're getting are from lib files of different version.
Check here.
-----------------------------------------------






SOLUTION:
modules.lua

-- Callback onBuy() function. If you wish, you can change certain Npc to use your onBuy().
	function ShopModule:callbackOnBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks)
		local shopItem = nil
		for _, item in ipairs(self.npcHandler.shopItems) do
			if(item.id == itemid and item.subType == subType) then
				shopItem = item
				break
			end
		end

		if(shopItem == nil) then
			print('[Warning - ' .. getCreatureName(getNpcId()) .. '] NpcSystem:', 'ShopModule.onBuy - Item not found on shopItems list')
			return false
		end

		if(shopItem.buy == -1) then
			print('[Warning - ' .. getCreatureName(getNpcId()) .. '] NpcSystem:', 'ShopModule.onBuy - Attempt to purchase an item which only sellable')
			return false
		end

		if(amount <= 0) then
			print('[Warning - ' .. getCreatureName(getNpcId()) .. '] NpcSystem:', 'ShopModule.onBuy - Attempt to purchase ' .. amount .. ' items')
			return false
		end

		local backpack, totalCost = 1988, amount * shopItem.buy
		if(inBackpacks) then
			totalCost = totalCost + (math.max(1, math.floor(amount / getContainerCapById(backpack))) * 20)
		end

		local parseInfo = {
			[TAG_PLAYERNAME] = getPlayerName(cid),
			[TAG_ITEMCOUNT] = amount,
			[TAG_TOTALCOST] = totalCost,
			[TAG_ITEMNAME] = shopItem.name
		}

		if(getPlayerMoney(cid) < totalCost) then
			local msg = self.npcHandler:getMessage(MESSAGE_NEEDMONEY)
			doPlayerSendCancel(cid, self.npcHandler:parseMessage(msg, parseInfo))
			return false
		end

		local subType = shopItem.subType or 1
		local a, b = doNpcSellItem(cid, itemid, amount, subType, ignoreCap, inBackpacks, backpack)
		if(a < amount) then
			local msgId = MESSAGE_NEEDMORESPACE
			if(a == 0) then
				msgId = MESSAGE_NEEDSPACE
			end

			local msg = self.npcHandler:getMessage(msgId)
			parseInfo[TAG_ITEMCOUNT] = a

			doPlayerSendCancel(cid, self.npcHandler:parseMessage(msg, parseInfo))
			if(NPCHANDLER_CONVBEHAVIOR ~= CONVERSATION_DEFAULT) then
				self.npcHandler.talkStart[cid] = os.time()
			else
				self.npcHandler.talkStart = os.time()
			end

			if(a > 0) then
				doPlayerRemoveMoney(cid, ((a * shopItem.buy) + (b * 20)))
				return true
			end

			return false
		end

		local msg = self.npcHandler:getMessage(MESSAGE_BOUGHT)
		doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, self.npcHandler:parseMessage(msg, parseInfo))

		doPlayerRemoveMoney(cid, totalCost)
		if(NPCHANDLER_CONVBEHAVIOR ~= CONVERSATION_DEFAULT) then
			self.npcHandler.talkStart[cid] = os.time()
		else
			self.npcHandler.talkStart = os.time()
		end

		return true
	end

I just removed this line, no more bugs in console, is there any problem?

			print('[Warning - ' .. getCreatureName(getNpcId()) .. '] NpcSystem:', 'ShopModule.onBuy - Item not found on shopItems list')

Just 1 problem:
When I select 'buy with backpack' do not have effect.

 

[LucasFerraz]

What's the most recent distro 8.6? (Stablest)

 

[Cykotitan]

An upgraded 0.3.6 would be most bugfree from what i saw.

 

[LucasFerraz]

Can you post code here?

 

[LucasFerraz]

Can you post code here please? :/
bump

 

[1268995]

The player log into tibia, go to npc ah say hi, trade; than, they open
the elf bot (need the bp open) and activate the hotkey that i will not pass here for no bugging teaching :w00t:
an than they buy potions for 0 gp... i guess the solution is find some place that we can put that only can buy
a potion if value is >1, maybe in .lua config, but i dont know, i dont find...
If someone know, please, tell us.
Cya, and sorry for noob brazilian english