Solved Npc trade window when greet

[silveralol]

Hello, I'm here trying making my npcs open the trade window when I say "hi", but I did not find the way....
TFS 1.2
in data/npc/lib/npcsystem/npchandler,lua
I find the function of greet players, then I want to do something to get working what I'm asking for..

function NpcHandler:greet(cid, message)
        if cid ~= 0  then
            local callback = self:getCallback(CALLBACK_GREET)
            if callback == nil or callback(cid, message) then
                if self:processModuleCallback(CALLBACK_GREET, cid) then
                    local msg = self:getMessage(MESSAGE_GREET)
                    local parseInfo = { [TAG_PLAYERNAME] = Player(cid):getName() }
                    msg = self:parseMessage(msg, parseInfo)
                    self:say(msg, cid, true)
                else
                    return
                end
            else
                return
            end
        end
        self:addFocus(cid)
    end

I don't find the function that call the trade window... :/
thanks

 

[pasiak12]

check modules.lua (its in the same file as npchandler.lua)

    -- The words for requesting trade window.
    SHOP_TRADEREQUEST = {"trade"}

 

[silveralol]

checked and test, if I put "hi" in the SHOP_TRADEREQUEST don't work, and same saying trade the npc don't open the window

 

[pasiak12]

changed the

    -- The word for requesting trade window. For more information look at the top of modules.lua
    SHOP_TRADEREQUEST = {'trade'}

in npcsystem.lua (still same folder)

Worked for me

 

[silveralol]

already do it...
the npc only open the window if I say "hi" again...
you don't understand what I trying to do...

 

[pasiak12]

modules.lua

find function FocusModule.onGreet(cid, message, keywords, parameters) and replace with this

    function FocusModule.onGreet(cid, message, keywords, parameters)
    
        local module = parameters.module

        if not module.npcHandler:onTradeRequest(cid) then
            parameters.module.npcHandler:onGreet(cid)
            return true
        end
        

        local itemWindow = {}
        for i = 1, #module.npcHandler.shopItems do
            itemWindow[#itemWindow + 1] = module.npcHandler.shopItems[i]
        end

        if itemWindow[1] == nil then
            local parseInfo = { [TAG_PLAYERNAME] = getPlayerName(cid) }
            local msg = module.npcHandler:parseMessage(module.npcHandler:getMessage(MESSAGE_NOSHOP), parseInfo)
            module.npcHandler:say(msg, cid)
            return true
        end

        local parseInfo = { [TAG_PLAYERNAME] = getPlayerName(cid) }
        local msg = module.npcHandler:parseMessage(module.npcHandler:getMessage(MESSAGE_SENDTRADE), parseInfo)
        openShopWindow(cid, itemWindow,
            function(cid, itemid, subType, amount, ignoreCap, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks) end,
            function(cid, itemid, subType, amount, ignoreCap, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, ignoreCap, inBackpacks) end)
        module.npcHandler:say(msg, cid)

    
        parameters.module.npcHandler:onGreet(cid)
        return true
    end

 

[silveralol]

works with the npcs that have offers to sell/buy, but when I try talk with banker for exemple he say "I'm not offering anything...", so, need to check if the npc have offers or not

 

[pasiak12]

Yeah it was blocked for npc that doesnt sell anything

    function FocusModule.onGreet(cid, message, keywords, parameters)
    
        local module = parameters.module

        if not module.npcHandler:onTradeRequest(cid) then
            parameters.module.npcHandler:onGreet(cid)
            return true
        end
        

        local itemWindow = {}
        for i = 1, #module.npcHandler.shopItems do
            itemWindow[#itemWindow + 1] = module.npcHandler.shopItems[i]
        end

        if itemWindow[1] == nil then
            parameters.module.npcHandler:onGreet(cid)
            return true
        end

        local parseInfo = { [TAG_PLAYERNAME] = getPlayerName(cid) }
        local msg = module.npcHandler:parseMessage(module.npcHandler:getMessage(MESSAGE_SENDTRADE), parseInfo)
        openShopWindow(cid, itemWindow,
            function(cid, itemid, subType, amount, ignoreCap, inBackpacks) module.npcHandler:onBuy(cid, itemid, subType, amount, ignoreCap, inBackpacks) end,
            function(cid, itemid, subType, amount, ignoreCap, inBackpacks) module.npcHandler:onSell(cid, itemid, subType, amount, ignoreCap, inBackpacks) end)
        module.npcHandler:say(msg, cid)

    
        parameters.module.npcHandler:onGreet(cid)
        return true
    end

I cant check it now, but should work

 

[silveralol]

thank you very much, it worked!