NPC Walkaway message send really slow

[henkas]

Hi
does anyone have any ideas how to fix this slow sending message?

<?xml version="1.0" encoding="UTF-8"?>
<npc name="Yama" script="yama.lua" walkinterval="0" floorchange="0">
    <health now="100" max="100" />
    <look type="464"/>
    <parameters>
    <parameter key="message_greet" value="Hiho, |PLAYERNAME|."/>   <!-- This one send perfect 10/10 -->
    <parameter key="message_walkaway" value="Let's go"/>    <!-- This one kinda fucked up i have to wait 2-4seconds to get message -->
    </parameters>
</npc>

 

[Znote]

Based on this:
forgottenserver/npchandler.lua at master · otland/forgottenserver · GitHub

It appears that the NpcHandler: OnWalkAway function triggers from an onThink callback. onThink code executes on an interval based on time like some globalevents do.

This means that the walkaway code does not trigger exacly after you have moved out of the radius, but after the next time the NPC "thinks". And it will then check if you are out of the radius.

 

[henkas]

Based on this:
forgottenserver/npchandler.lua at master · otland/forgottenserver · GitHub

It appears that the NpcHandler: OnWalkAway function triggers from an onThink callback. onThink code executes on an interval based on time like some globalevents do.

This means that the walkaway code does not trigger exacly after you have moved out of the radius, but after the next time the NPC "thinks". And it will then check if you are out of the radius.

So solution is?

 

[Znote]

So solution is?

There isn't one. This is normal behavior in all OT servers?

 

[henkas]

There isn't one. This is normal behavior in all OT servers?

Ech if you say so

 

[Night Wolf]

make it trigger by a onStepOut instead of onThink, or create a special onThink that executes faster just to checking this.

 

[henkas]

make it trigger by a onStepOut instead of onThink, or create a special onThink that executes faster just to checking this.

I never heard about onStepOut function so i have no idea how should i make it.

 

[Night Wolf]

basically you would need at least some familiarity with the C++ and the source code of tfs to do this, I think it would be alot easier for you to just accept this natural delay, as it is the same for all otservers.

This change would make the npc function onWalkAway be executed everytime you walk instead of every 500ms, this could affect negatively your server because it would escalate with the number of interactions between npcs/players.