• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

On Trade Accept Create Log.txt

L

Larb

New Member
Joined
Nov 26, 2016
Messages
85
Reaction score
1
i need script if player accept trade by player create log with itens trade and player's name
TFS 1.2
 
Last edited:
Solution
Aled
Xeraphus said:
use a recursive container search:
Lua: 
function searchContainer(container, items)
    items = items or {}
    for i = container:getSize()-1, 0, -1 do
        local item = container:getItem(i)
        if item:getType():isContainer() then
            searchContainer(item, items)
        else
            items[#items+1] = item
        end
    end
    return items
end
Click to expand...
Very nice, added to the script
Lua: 
function Player:onTradeAccept(target, item, targetItem)
    file = io.open('data/logs/trade.log',"a")
    file:write(""..os.date("%c")..": "..self:getName().." traded:")
    if item:isContainer() then
        local pitems = searchContainer(item)
        for i = 1, #pitems do
            file:write(string.format(' %s (%s)(%s),'...
Sort by date Sort by votes
In events/scripts/player.lua put
Lua: 
function Player:onTradeAccept(target, item, targetItem)
    local currenttime = tonumber(os.date("%H%M", os.time()))
    file = io.open('data/logs/tradelog.txt',"w")
    file:write(""..currenttime..": "..player:getName().." traded "..item:getName().." for "..targetItem:getName().." with "..target:getName()...".")
    file:close()
    return true
end
I don't know if it will work and I don't think 0.4 has onTradeAccept
 
Last edited:
Upvote 0 Downvote
Aled said:
In events/scripts/player.lua put
Lua: 
function Player:onTradeAccept(target, item, targetItem)
    local currenttime = tonumber(os.date("%H%M", os.time()))
    file = io.open('data/logs/tradelog.txt',"w")
    file:write(""..currenttime..": "..player.." traded "..item.." for "..targetItem.." with "..target..".")
    file:close()
    return true
end
I don't know if it will work and I don't think 0.4 has onTradeAccept
Click to expand...

erro

Lua Script Error: [Event Interface]
data/events/scripts/player.lua:player@onTradeAccept
data/events/scripts/player.lua:151: attempt to concatenate local 'target' (a use
rdata value)
stack traceback:
[C]: in function '__concat'
data/events/scripts/player.lua:151: in function <data/events/scripts/pla
yer.lua:148>
 
Upvote 0 Downvote
cbrm said:
if it's a container it'll need description of items inside
Click to expand...
That's one thing I couldn't be bothered to do
EDIT:
I don't know if this will work or what it will look like:
Lua: 
function Player:onTradeAccept(target, item, targetItem)
    local currenttime = tonumber(os.date("%H%M", os.time()))
    file = io.open('data/logs/tradelog.txt',"w")
    file:write(""..currenttime..": "..self:getName().." traded")
    if item:isContainer() then
    local pitems = item:getItemHoldingCount()
        for i, pitems do
            file:write(" "..item:getItem(i):getName()..",")
        end
    else
        file:write(" "..item:getName().."")
    end
    file:write(" with "..target:getName().." for")
    if targetItem:isContainer() then
    local titems = targetItem:getItemHoldingCount()
        for i, titems do
            file:write(" "..targetItem:getItem(i):getName()..",")
        end
    else
        file:write(" "..targetItem:getName()..".")
    end
    file:close()
    return true
end
 
Last edited:
Upvote 0 Downvote
Aled said:
That's one thing I couldn't be bothered to do
EDIT:
I don't know if this will work or what it will look like:
Lua: 
function Player:onTradeAccept(target, item, targetItem)
    local currenttime = tonumber(os.date("%H%M", os.time()))
    file = io.open('data/logs/tradelog.txt',"w")
    file:write(""..currenttime..": "..player.." traded")
    if item:isContainer() then
        for i, #item:getItemHoldingCount() do
            file:write(" "..item:getItem(i)..",")
        end
    else
        file:write(" "..item.."")
    end
    file:write(" with "..target.." for")
    if targetItem:isContainer() then
        for i, #targetItem:getItemHoldingCount() do
            file:write(" "..targetItem:getItem(i)..",")
        end
    else
        file:write(" "..targetItem..".")
    end
    file:close()
    return true
end
Click to expand...
i have erro 1
[Warning - Events::load] Can not load script: player.lua
data/events/scripts/player.lua:153: '<name>' expected near '#'
removed
for i, #
erro 2
Lua Script Error: [Event Interface]
data/events/scripts/player.lua:player@onTradeAccept
data/events/scripts/player.lua:151: attempt to concatenate global 'player' (a ni
l value)
stack traceback:
[C]: in function '__concat'
data/events/scripts/player.lua:151: in function <data/events/scripts/pla
yer.lua:148>
 
Upvote 0 Downvote
Aled said:
That's one thing I couldn't be bothered to do
EDIT:
I don't know if this will work or what it will look like:
Lua: 
function Player:onTradeAccept(target, item, targetItem)
    local currenttime = tonumber(os.date("%H%M", os.time()))
    file = io.open('data/logs/tradelog.txt',"w")
    file:write(""..currenttime..": "..self:getName().." traded")
    if item:isContainer() then
    local pitems = item:getItemHoldingCount()
        for i, #pitems do
            file:write(" "..item:getItem(i):getName()..",")
        end
    else
        file:write(" "..item:getName().."")
    end
    file:write(" with "..target:getName().." for")
    if targetItem:isContainer() then
    local titems = targetItem:getItemHoldingCount()
        for i, #titems do
            file:write(" "..targetItem:getItem(i):getName()..",")
        end
    else
        file:write(" "..targetItem:getName()..".")
    end
    file:close()
    return true
end
Click to expand...

Some of my thoughts.
Converting local currenttime to number is unnecessary.
You can use "%c" in os.date() to call date and time at once wich i think will be better than just a time. Remember to not to convert it to number then.
io.file "w" mode will overwrite every previous change. Use "a" instead.
'getItemHoldingCount()' returns just a number not items table.

Keep it up mate!
Cheers
 
Upvote 0 Downvote
2Rec said:
'getItemHoldingCount()' returns just a number not items table.
Click to expand...
Eeuuuuughhhhhhh thats what you call overthinking (or not reading about functions properly and just whacking them in).. fixed

Thanks a lot

EDIT:
Is there a function that returns the items contained in the container and will it return items in the container within the container?
How would you go about doing that?
 
Upvote 0 Downvote
Aled said:
Eeuuuuughhhhhhh thats what you call overthinking (or not reading about functions properly and just whacking them in).. fixed

Thanks a lot

EDIT:
Is there a function that returns the items contained in the container and will it return items in the container within the container?
How would you go about doing that?
Click to expand...
[Warning - Events::load] Can not load script: player.lua
data/events/scripts/player.lua:154: 'in' expected near 'do'

@Aled
 
Upvote 0 Downvote
Aled said:
Eeuuuuughhhhhhh thats what you call overthinking (or not reading about functions properly and just whacking them in).. fixed

Thanks a lot

EDIT:
Is there a function that returns the items contained in the container and will it return items in the container within the container?
How would you go about doing that?
Click to expand...

container:getItem(index)
You have to loop over every slot(index) of container.
Remember that indexes starts from 0.
 
Last edited:
Upvote 0 Downvote
Aled said:
Eeuuuuughhhhhhh thats what you call overthinking (or not reading about functions properly and just whacking them in).. fixed

Thanks a lot

EDIT:
Is there a function that returns the items contained in the container and will it return items in the container within the container?
How would you go about doing that?
Click to expand...

use a recursive container search:
Lua: 
function searchContainer(container, items)
    items = items or {}
    for i = container:getSize()-1, 0, -1 do
        local item = container:getItem(i)
        if item:getType():isContainer() then
            searchContainer(item, items)
        else
            items[#items+1] = item
        end
    end
    return items
end

Lua: 
local items = searchContainer(item)
 
Upvote 0 Downvote
Xeraphus said:
use a recursive container search:
Lua: 
function searchContainer(container, items)
    items = items or {}
    for i = container:getSize()-1, 0, -1 do
        local item = container:getItem(i)
        if item:getType():isContainer() then
            searchContainer(item, items)
        else
            items[#items+1] = item
        end
    end
    return items
end

Lua: 
local items = searchContainer(item)
Click to expand...
where i add it ?
 
Upvote 0 Downvote
Xeraphus said:
use a recursive container search:
Lua: 
function searchContainer(container, items)
    items = items or {}
    for i = container:getSize()-1, 0, -1 do
        local item = container:getItem(i)
        if item:getType():isContainer() then
            searchContainer(item, items)
        else
            items[#items+1] = item
        end
    end
    return items
end
Click to expand...
Very nice, added to the script
Lua: 
function Player:onTradeAccept(target, item, targetItem)
    file = io.open('data/logs/trade.log',"a")
    file:write(""..os.date("%c")..": "..self:getName().." traded:")
    if item:isContainer() then
        local pitems = searchContainer(item)
        for i = 1, #pitems do
            file:write(string.format(' %s (%s)(%s),',  pitems[i]:getName(), pitems[i]:getId(), pitems[i]:getCount() > 1 and pitems[i]:getCount()))
        end
    else
        file:write(string.format(' %s (%s)(%s),', item:getName(), item:getId(), item:getCount() > 1 and item:getCount()))
    end
    file:write(" with "..target:getName().." for:")
    if targetItem:isContainer() then
        local titems = searchContainer(targetItem)
        for i = 1, #titems do
            file:write(string.format(' %s (%s)(%s),', titems[i]:getName(), titems[i]:getId(), titems[i]:getCount() > 1 and titems[i]:getCount()))
        end
    else
        file:write(string.format(' %s (%s)(%s).', targetItem:getName(), targetItem:getId(), targetItem:getCount() > 1 and targetItem:getCount()))
    end
    file:write('\n-------------------------\n\n')
    file:close()
    return true
end
Credits to lay for much better string format:
Lay said:
I made some changes:
Lua: 
function Player:onTradeAccept(target, item, targetItem)
    file = io.open('data/logs/trade.log',"a")
    file:write(""..os.date("%c")..": "..self:getName().." traded:")
    if item:isContainer() then
        local pitems = searchContainer(item)
        for i = 1, #pitems do
            file:write(string.format(' %s (%s)(%s),',  pitems[i]:getName(), pitems[i]:getId(), pitems[i]:getCount() > 1 and pitems[i]:getCount()))
        end
    else
        file:write(string.format(' %s (%s)(%s),', item:getName(), item:getId(), item:getCount() > 1 and item:getCount()))
    end
    file:write(" with "..target:getName().." for:")
    if targetItem:isContainer() then
        local titems = searchContainer(targetItem)
        for i = 1, #titems do
            file:write(string.format(' %s (%s)(%s),', titems[i]:getName(), titems[i]:getId(), titems[i]:getCount() > 1 and titems[i]:getCount()))
        end
    else
        file:write(string.format(' %s (%s)(%s).', targetItem:getName(), targetItem:getId(), targetItem:getCount() > 1 and targetItem:getCount()))
    end
    file:write('\n-------------------------\n\n')
    file:close()
    return true
end

Code: 
Thu Apr 20 12:12:18 2017: Knight traded: soul orb (5944)(6), with Druid for: giant sword (2393)(false).
-------------------------

Thu Apr 20 12:12:48 2017: Knight traded: platinum coin (2152)(78), with Druid for: lightning boots (7893)(false).
-------------------------

But someone can help me with this (false) if count is 1, want to looks like:
Code: 
Thu Apr 20 12:12:48 2017: Knight traded: platinum coin (2152)(78), with Druid for: lightning boots (7893).
Click to expand...
 
Last edited:
Upvote 0 Downvote
Solution
@Aled very thanks
1926: Test traded book of lies with Test2 for addon doll.
work fine by trade items if i trade bp have this erro
Lua Script Error: [Event Interface]
data/events/scripts/player.lua:player@onTradeAccept
data/events/scripts/player.lua:166: attempt to call method 'getSize' (a nil valu
e)
stack traceback:
[C]: in function 'getSize'
data/events/scripts/player.lua:166: in function <data/events/scripts/pla
yer.lua:160>
--
Log clean if i make new trade
 
Last edited:
Upvote 0 Downvote
Log ok :D
now
Lua Script Error: [Event Interface]
data/events/scripts/player.lua:player@onTradeAccept
data/events/scripts/player.lua:167: attempt to index a nil value
stack traceback:
[C]: in function '__index'
data/events/scripts/player.lua:167: in function <data/events/scripts/pla
yer.lua:160>
 
Upvote 0 Downvote

Similar threads

elnelson
  • Question
Lua [TFS 1.2] Party finder
Replies
3
Views
523
elnelson
elnelson
Engradiel
  • Question
Lua How I do that?
Replies
4
Views
298
Engradiel
Engradiel
J
  • Solved
Lua Warn to gods when a player log in to the game
Replies
8
Views
538
Jeyci
J
Shoorkill
  • Question
Lua TFS 1.5 NPC GUILD MASTER
Replies
0
Views
291
Shoorkill
Shoorkill
O
  • Solved
Lua TFS 1.4 Reset all to preset eq lvl on log out or death
Replies
1
Views
197
Evil Puncker
E
G
  • Question
Lua How Get Freeze Rune Script/Freeze the entire person (tibia 8.60)
Replies
0
Views
105
Gaber Zen
G
bpm91
  • Question
AAC create guild in db
Replies
0
Views
260
bpm91
bpm91
F
  • Solved
help with npc shop
Replies
8
Views
810
Flagton
F
D
  • Question
Lua [TFS 0.4] log out player when logging in for the first time
Replies
6
Views
447
potinho
potinho
E
  • Question
C++ Simulate Online Players.
Replies
7
Views
412
samco
samco
Back
Top