oh yeah, sorry
by bonuses I mean HP, Mana, Critical chance/damage, Armor, HP Regen etc
data/creaturescripts/scripts/bonuslevel.lua:local config = {
--avaliable bonus
--["bonusName"] = {min = Min Bonus Value, max = Max Bonus Value}
bonus = {
["hp"] = {min = 100, max = 200},
["mp"] = {min = 100, max = 200},
["critchance"] = {min = 10, max = 20},
["critdamage"] = {min = 10, max = 50},
},
lastRecivedBonusLevel = 2000, --storage to hold the last level that player recived the bonus
bonusInEachLevel = 3, --the player will recive bonus in each 3 levels
}
function onAdvance(player, skill, oldLevel, newLevel)
if skill ~= SKILL_LEVEL then --check if skill is LEVEL type
return true
end
local lastLevel = player:getStorageValue(config.lastRecivedBonusLevel)--Get the last level that player recived the bonus
if not lastLevel or lastLevel < 0 then --if nil or lower than 0(default is -1)
lastLevel = 0 --set to 0, to calculate how many times player will recive the bonus
end
local timesToGiveBonus = math.floor((newLevel - lastLevel)/config.bonusInEachLevel)--calculate how many times player will recive the bonus
if timesToGiveBonus >= 1 then--if more than 1 time
for times = 1, timesToGiveBonus do--for each time
local randomIndex = math.random(1, table.size(config.bonus)) --get a random index of table
local indexCount = 1 --instantiate a counter to bonus table index starting by 1(default)
for bonusName, bonusInfo in pairs(config.bonus) do --for each key, value in table
--NOTE: pairs() will be unordained a iteration, but always will be the same unordained order
if indexCount == randomIndex then--if the randomIndex is equal to the indexCount
giveBonus(player, bonusName, bonusInfo)--call a giveBonus function passing the bonusName and bonusInfo
break--break the loop and go for next bonus
end
indexCount = indexCount + 1 --incress the indexCount by 1
end
end
player:setStorageValue(config.lastRecivedBonusLevel, newLevel)--Set the last level that player recived the bonus, to newLevel
end
return true
end
--this can be better
function giveBonus(player, bonusName, bonusInfo)
local bonusAmount = math.random(bonusInfo.min, bonusInfo.max)--get a random value from min and max value of bonusInfo
if bonusName == "hp" then--if bonus is Hp
player:setMaxHealth(player:getMaxHealth() + bonusAmount)--set maxHP to current player maxHP + bonusAmount
elseif bonusName == "mp" then--if bonus if Mp
player:setMaxMana(player:getMaxMana() + bonusAmount)--set maxMP to current player maxMP + bonusAmount
elseif bonusName == "critchance" then--if bonus is critchance
--add your crit chance
elseif bonusName == "critdamage" then--if bonus is critdamage
--add your crit damage
else--if bonus type don't exist, report error by PRINT on console
print("[ERROR BONUS LEVEL] The player: "..player:getName().." recived a bonus that don't exist. BonusName = "..bonusName..".")
end
return true
enddata/creaturescripts/creaturescripts.xml:<event type="advance" name="bonusLevel" script="bonuslevel.lua" />data/creaturescripts/scripts/login.lua above return true put:player:registerEvent("bonusLevel")function table.size(t)
local size = 0
for k, v in pairs(t) do
size = size + 1
end
return size
endconfig.bonus table, add to giveBonus function too.
playerBonusConfig = {
--[[
type: Unique identifier for the bonus, will automatically be configured to a constant as well (e.g. PLAYERBONUS_ARMOR)
readableString: String used when showing the player they received the bonus
roll: Obvious, but math.random(min, max)
loadOnLogin: Load the bonus when player logs in, since it's not saved to database
callback: Callback for when you require special functionality (aka when basic storages aren't enough)
]]
bonuses = {
{
type = "armor",
readableString = "Armor",
loadOnLogin = false,
roll = {min = 5, max = 10},
-- We don't need a callback for armor since it's handled by storage value in onHealth/onManaChange events
},
{
type = "health",
readableString = "Maximum Health",
roll = {min = 5, max = 10},
loadOnLogin = false,
callback = function(player, currentBonus, modifier)
player:setMaxHealth(player:getMaxHealth() + modifier)
player:addHealth(modifier)
end
},
{
type = "mana",
readableString = "Maximum Mana",
roll = {min = 5, max = 10},
loadOnLogin = false,
callback = function(player, currentBonus, modifier)
player:setMaxMana(player:getMaxMana() + modifier)
player:addMana(modifier)
end
},
{
type = "criticalChance",
readableString = "Critical Hit Chance",
roll = {min = 5, max = 10},
loadOnLogin = true,
callback = function(player, currentBonus, modifier)
player:addSpecialSkill(SPECIALSKILL_CRITICALHITCHANCE, modifier)
end
},
{
type = "criticalAmount",
readableString = "Critical Hit Amount",
roll = {min = 5, max = 10},
loadOnLogin = true,
callback = function(player, currentBonus, modifier)
player:addSpecialSkill(SPECIALSKILL_CRITICALHITAMOUNT, modifier)
end
},
{
type = "healthRegeneration",
readableString = "Health Regeneration",
roll = {min = 5, max = 10},
loadOnLogin = true,
condition = Condition(CONDITION_REGENERATION, CONDITIONID_DEFAULT),
callback = function(player, currentBonus, modifier)
local subId = 501
local condition = player:getCondition(CONDITION_REGENERATION, CONDITIONID_DEFAULT, subId)
if condition then
condition:setParameter(CONDITION_PARAM_HEALTHGAIN, currentBonus + modifier)
else
condition = playerBonusConfig.bonuses[6].condition
condition:setTicks(-1)
condition:setParameter(CONDITION_PARAM_SUBID, subId)
condition:setParameter(CONDITION_PARAM_HEALTHTICKS, 1000)
condition:setParameter(CONDITION_PARAM_HEALTHGAIN, currentBonus + modifier)
player:addCondition(condition)
end
end
},
{
type = "manaRegeneration",
readableString = "Mana Regeneration",
roll = {min = 5, max = 10},
loadOnLogin = true,
condition = Condition(CONDITION_REGENERATION, CONDITIONID_DEFAULT),
callback = function(player, currentBonus, modifier)
local subId = 502
local condition = player:getCondition(CONDITION_REGENERATION, CONDITIONID_DEFAULT, subId)
if condition then
condition:setParameter(CONDITION_PARAM_MANAGAIN, currentBonus + modifier)
else
condition = playerBonusConfig.bonuses[7].condition
condition:setTicks(-1)
condition:setParameter(CONDITION_PARAM_SUBID, subId)
condition:setParameter(CONDITION_PARAM_MANATICKS, 1000)
condition:setParameter(CONDITION_PARAM_MANAGAIN, currentBonus + modifier)
player:addCondition(condition)
end
end
}
},
baseStorage = 12345, -- Base storage key to start from, the rest are assigned based on baseStorage and adds + 1 for each bonus in the config
perLevel = 5, -- Random bonus applied at each level interval defined here
msg = {
type = MESSAGE_STATUS_CONSOLE_ORANGE,
--[[
%s : readableString
%d (1): Bonus modifier (current + >>modifier<<)
%d (2): Total bonus (value of current + modifier)
]]
string = "Your %s has been increased by %d, your total is now %d."
}
}
for i, bonus in ipairs(playerBonusConfig.bonuses) do
-- Add constants for bonus types, e.g. PLAYERBONUS_ARMOR -> "armor"
_G["PLAYERBONUS_" .. bonus.type:upper()] = bonus.type
-- Automatically assign storage keys because fuck doing them all manually
playerBonusConfig.bonuses[i].storage = playerBonusConfig.baseStorage + i
end
-- Lib functions
function getBonusByType(bonusType)
for _, bonus in ipairs(playerBonusConfig.bonuses) do
if bonus.type == bonusType then
return bonus
end
end
return nil
end
function Player.addRandomBonus(self)
local bonus = playerBonusConfig.bonuses[math.random(#playerBonusConfig.bonuses)]
return self:addBonus(bonus.type, math.random(bonus.roll.min, bonus.roll.max))
end
function Player.addBonus(self, bonusType, modifier)
local bonus = bonusType
if type(bonus) == "string" then
bonus = getBonusByType(bonus)
end
if not bonus then
print("[Player.addBonus] Invalid bonus type given (".. tostring(bonusType) ..")")
return false
end
-- Add modifier to the cumulative bonus
local currentBonus = self:getBonus(bonus)
self:setStorageValue(bonus.storage, currentBonus + modifier)
if bonus.callback then
bonus.callback(self, currentBonus, modifier)
end
-- bonus, modifier, total
return bonus, modifier, currentBonus + modifier
end
function Player.getBonus(self, bonusType)
local bonus = bonusType
if type(bonus) == "string" then
bonus = getBonusByType(bonus)
end
if not bonus then
print("[Player.getBonus] Invalid bonus type given (".. tostring(bonusType) ..")")
return 0
end
local value = self:getStorageValue(bonus.storage)
return value == -1 and 0 or value
end
-- Below are all events, no touchy touchy
local function armorFormula(player, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType)
-- Make sure we're being hit and the damage is negative (avoid the formula on healing)
if not attacker or primaryType == COMBAT_HEALING then
return primaryDamage, secondaryDamage
end
local armor = player:getBonus(PLAYERBONUS_ARMOR)
if armor == 0 then
return primaryDamage, secondaryDamage
end
-- Apply default armor formula from Creature::blockHit
if armor > 3 then
primaryDamage = primaryDamage - (math.random(armor / 2, armor - (armor % 2 + 1)))
secondaryDamage = secondaryDamage - (math.random(armor / 2, armor - (armor % 2 + 1)))
else
primaryDamage = primaryDamage - 1
secondaryDamage = secondaryDamage - 1
end
return math.max(0, primaryDamage), math.max(0, secondaryDamage)
end
-- HealthChange Armor mitigation event
local eventHpChange = CreatureEvent("bonuses_armorHpEvent")
eventHpChange:type("healthChange")
function eventHpChange.onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
primaryDamage, secondaryDamage = armorFormula(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType)
return primaryDamage, primaryType, secondaryDamage, secondaryType
end
eventHpChange:register()
-- ManaChange Armor mitigation event
local eventMpChange = CreatureEvent("bonuses_armorMpEvent")
eventMpChange:type("manaChange")
function eventMpChange.onManaChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
primaryDamage, secondaryDamage = armorFormula(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType)
return primaryDamage, primaryType, secondaryDamage, secondaryType
end
eventMpChange:register()
-- Advance event to give random bonuses to the player
local eventAdvance = CreatureEvent("bonuses_onAdvance")
eventAdvance:type("advance")
function eventAdvance.onAdvance(player, skill, oldLevel, newLevel)
if skill ~= SKILL_LEVEL or newLevel < oldLevel then
return true
end
-- Apply a new random bonus for each level interval reached
local levelGain = newLevel - oldLevel
while true do
levelGain = levelGain - playerBonusConfig.perLevel
if levelGain < 0 then
break
end
local bonus, modifier, totalBonus = player:addRandomBonus()
if bonus and modifier and totalBonus then
player:sendTextMessage(playerBonusConfig.msg.type, string.format(playerBonusConfig.msg.string, bonus.readableString, modifier, totalBonus))
end
end
return true
end
eventAdvance:register()
-- Login event to register above events
local eventLogin = CreatureEvent("bonuses_eventRegister")
eventLogin:type("login")
function eventLogin.onLogin(player)
local events = {"bonuses_armorHpEvent", "bonuses_armorMpEvent", "bonuses_onAdvance"}
for _, eventName in ipairs(events) do
player:registerEvent(eventName)
end
for _, bonus in ipairs(playerBonusConfig.bonuses) do
if bonus.loadOnLogin then
-- Loads the storage value of the bonus and applies it to the player
bonus.callback(player, 0, player:getBonus(bonus.type))
end
end
return true
end
eventLogin:register()player:getBonus("armor"))
You can, addBonus adds the modifier to the cumulative value, meaning you can pass negative values to subtract from that bonus and it updates.
No, my item abilities are just that, items, not players.@Delusion through player:addSpecialSkill I can use any of your custom item abilities, right?
thanks
Bonus attack speed:I wish I could give random attack speed % for players, or even bonus to healing spells but its awesome already
player:setAttackSpeed(player:getAttackSpeed() + modifier)events table in the login event I createdprimaryType = primaryType + (primaryType * player:getBonus(PLAYERBONUS_HEALING))
First of all thanks for this script.
playerBonusConfig = {
--[[
type: Unique identifier for the bonus, will automatically be configured to a constant as well (e.g. PLAYERBONUS_ARMOR)
readableString: String used when showing the player they received the bonus
roll: Obvious, but math.random(min, max)
loadOnLogin: Load the bonus when player logs in, since it's not saved to database
callback: Callback for when you require special functionality (aka when basic storages aren't enough)
]]
bonuses = {
{
type = "armor",
readableString = "Armor",
loadOnLogin = true,
roll = {min = 5, max = 10},
-- We don't need a callback for armor since it's handled by storage value in onHealth/onManaChange events
},
{
type = "attackspeed",
readableString = "Attack Speed",
roll = {min = 5, max = 10},
loadOnLogin = true,
callback = function(player, currentBonus, modifier)
player:setAttackSpeed(player:getAttackSpeed() + modifier)
end
},
{
type = "health",
readableString = "Maximum Health",
roll = {min = 5, max = 10},
loadOnLogin = true,
callback = function(player, currentBonus, modifier)
player:setMaxHealth(player:getMaxHealth() + modifier)
player:addHealth(modifier)
end
},
{
type = "mana",
readableString = "Maximum Mana",
roll = {min = 5, max = 10},
loadOnLogin = true,
callback = function(player, currentBonus, modifier)
player:setMaxMana(player:getMaxMana() + modifier)
player:addMana(modifier)
end
},
{
type = "criticalChance",
readableString = "Critical Hit Chance",
roll = {min = 5, max = 10},
loadOnLogin = true,
callback = function(player, currentBonus, modifier)
player:addSpecialSkill(SPECIALSKILL_CRITICALHITCHANCE, modifier)
end
},
{
type = "criticalAmount",
readableString = "Critical Hit Amount",
roll = {min = 5, max = 10},
loadOnLogin = true,
callback = function(player, currentBonus, modifier)
player:addSpecialSkill(SPECIALSKILL_CRITICALHITAMOUNT, modifier)
end
},
{
type = "healthRegeneration",
readableString = "Health Regeneration",
roll = {min = 5, max = 10},
loadOnLogin = true,
condition = Condition(CONDITION_REGENERATION, CONDITIONID_DEFAULT),
callback = function(player, currentBonus, modifier)
local subId = 501
local condition = player:getCondition(CONDITION_REGENERATION, CONDITIONID_DEFAULT, subId)
if condition then
condition:setParameter(CONDITION_PARAM_HEALTHGAIN, currentBonus + modifier)
else
condition = playerBonusConfig.bonuses[6].condition
condition:setTicks(-1)
condition:setParameter(CONDITION_PARAM_SUBID, subId)
condition:setParameter(CONDITION_PARAM_HEALTHTICKS, 1000)
condition:setParameter(CONDITION_PARAM_HEALTHGAIN, currentBonus + modifier)
player:addCondition(condition)
end
end
},
{
type = "manaRegeneration",
readableString = "Mana Regeneration",
roll = {min = 5, max = 10},
loadOnLogin = true,
condition = Condition(CONDITION_REGENERATION, CONDITIONID_DEFAULT),
callback = function(player, currentBonus, modifier)
local subId = 502
local condition = player:getCondition(CONDITION_REGENERATION, CONDITIONID_DEFAULT, subId)
if condition then
condition:setParameter(CONDITION_PARAM_MANAGAIN, currentBonus + modifier)
else
condition = playerBonusConfig.bonuses[7].condition
condition:setTicks(-1)
condition:setParameter(CONDITION_PARAM_SUBID, subId)
condition:setParameter(CONDITION_PARAM_MANATICKS, 1000)
condition:setParameter(CONDITION_PARAM_MANAGAIN, currentBonus + modifier)
player:addCondition(condition)
end
end
}
},
baseStorage = 12345, -- Base storage key to start from, the rest are assigned based on baseStorage and adds + 1 for each bonus in the config
perLevel = 5, -- Random bonus applied at each level interval defined here
msg = {
type = MESSAGE_STATUS_CONSOLE_ORANGE,
--[[
%s : readableString
%d (1): Bonus modifier (current + >>modifier<<)
%d (2): Total bonus (value of current + modifier)
]]
string = "Your %s has been increased by %d, your total is now %d."
}
}
for i, bonus in ipairs(playerBonusConfig.bonuses) do
-- Add constants for bonus types, e.g. PLAYERBONUS_ARMOR -> "armor"
_G["PLAYERBONUS_" .. bonus.type:upper()] = bonus.type
-- Automatically assign storage keys because fuck doing them all manually
playerBonusConfig.bonuses[i].storage = playerBonusConfig.baseStorage + i
end
-- Lib functions
function getBonusByType(bonusType)
for _, bonus in ipairs(playerBonusConfig.bonuses) do
if bonus.type == bonusType then
return bonus
end
end
return nil
end
function Player.addRandomBonus(self)
local bonus = playerBonusConfig.bonuses[math.random(#playerBonusConfig.bonuses)]
return self:addBonus(bonus.type, math.random(bonus.roll.min, bonus.roll.max))
end
function Player.addBonus(self, bonusType, modifier)
local bonus = bonusType
if type(bonus) == "string" then
bonus = getBonusByType(bonus)
end
if not bonus then
print("[Player.addBonus] Invalid bonus type given (".. tostring(bonusType) ..")")
return false
end
-- Add modifier to the cumulative bonus
local currentBonus = self:getBonus(bonus)
self:setStorageValue(bonus.storage, currentBonus + modifier)
if bonus.callback then
bonus.callback(self, currentBonus, modifier)
end
-- bonus, modifier, total
return bonus, modifier, currentBonus + modifier
end
function Player.getBonus(self, bonusType)
local bonus = bonusType
if type(bonus) == "string" then
bonus = getBonusByType(bonus)
end
if not bonus then
print("[Player.getBonus] Invalid bonus type given (".. tostring(bonusType) ..")")
return 0
end
local value = self:getStorageValue(bonus.storage)
return value == -1 and 0 or value
end
-- Below are all events, no touchy touchy
local function armorFormula(player, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType)
-- Make sure we're being hit and the damage is negative (avoid the formula on healing)
if not attacker or primaryType == COMBAT_HEALING then
return primaryDamage, secondaryDamage
end
local armor = player:getBonus(PLAYERBONUS_ARMOR)
if armor == 0 then
return primaryDamage, secondaryDamage
end
-- Apply default armor formula from Creature::blockHit
if armor > 3 then
primaryDamage = primaryDamage - (math.random(armor / 2, armor - (armor % 2 + 1)))
secondaryDamage = secondaryDamage - (math.random(armor / 2, armor - (armor % 2 + 1)))
else
primaryDamage = primaryDamage - 1
secondaryDamage = secondaryDamage - 1
end
return math.max(0, primaryDamage), math.max(0, secondaryDamage)
end
-- HealthChange Armor mitigation event
local eventHpChange = CreatureEvent("bonuses_armorHpEvent")
eventHpChange:type("healthChange")
function eventHpChange.onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
primaryDamage, secondaryDamage = armorFormula(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType)
return primaryDamage, primaryType, secondaryDamage, secondaryType
end
eventHpChange:register()
-- ManaChange Armor mitigation event
local eventMpChange = CreatureEvent("bonuses_armorMpEvent")
eventMpChange:type("manaChange")
function eventMpChange.onManaChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
primaryDamage, secondaryDamage = armorFormula(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType)
return primaryDamage, primaryType, secondaryDamage, secondaryType
end
eventMpChange:register()
-- Advance event to give random bonuses to the player
local eventAdvance = CreatureEvent("bonuses_onAdvance")
eventAdvance:type("advance")
function eventAdvance.onAdvance(player, skill, oldLevel, newLevel)
if skill ~= SKILL_LEVEL or newLevel < oldLevel then
return true
end
-- Apply a new random bonus for each level interval reached
local levelGain = newLevel - oldLevel
while true do
levelGain = levelGain - playerBonusConfig.perLevel
if levelGain < 0 then
break
end
local bonus, modifier, totalBonus = player:addRandomBonus()
if bonus and modifier and totalBonus then
player:sendTextMessage(playerBonusConfig.msg.type, string.format(playerBonusConfig.msg.string, bonus.readableString, modifier, totalBonus))
end
end
return true
end
eventAdvance:register()
-- Login event to register above events
local eventLogin = CreatureEvent("bonuses_eventRegister")
eventLogin:type("login")
function eventLogin.onLogin(player)
local events = {"bonuses_armorHpEvent", "bonuses_armorMpEvent", "bonuses_onAdvance"}
for _, eventName in ipairs(events) do
player:registerEvent(eventName)
end
for _, bonus in ipairs(playerBonusConfig.bonuses) do
if bonus.loadOnLogin then
-- Loads the storage value of the bonus and applies it to the player
bonus.callback(player, 0, player:getBonus(bonus.type))
end
end
return true
end
eventLogin:register()GM mRefaat has logged in.
Lua Script Error: [Scripts Interface]
G:\Work\Tibia\NEW Project 2020 TFS 1.3 10.98\OT\data\scripts\creaturescripts\custom\bonus_on_level.lua:callback
...T\data\scripts\creaturescripts\custom\bonus_on_level.lua:280: attempt to call field 'callback' (a nil value)
stack traceback:
[C]: in function 'callback'
...T\data\scripts\creaturescripts\custom\bonus_on_level.lua:280: in function <...T\data\scripts\creaturescripts\custom\bonus_on_level.lua:270>
GM mRefaat has logged out.Because it shouldn't be loaded on login, there are no values set to the player required on login for it to function through other things because armor is manually defined and handled.
