Lua onDeath or onKill?

[Il Knight]

hi, i am triying to make this script work

Lua:
_____________________________
local chance = math.random(100)
local send = "asd"

function onDeath(creature, target, mostDamageKiller)

if getCreatureName(target) == "rat" then
player:setBankBalance(player:getBankBalance() + chance)
player:sendTextMessage(MESSAGE_STATUS_DEFAULT, send)

end
return true
end
______________________________

i need when you kill a "rat" in this case you get 0-100 gold coins in your bank balance but nothing happend :/
its possible to add more monsters in one script? like local monsters "rat", "rotworm" etc?

 

[president vankk]

Maybe something like this?

local config = {
    monstersNames = {"Rotworm", "Rat"},
    maxGold = 100
}

function onKill(player, target)
    local monster = target:getMonster()
    if not monster then
        return true
    end
   
    if not isInArray({config.monstersNames}, monster:getName()) then
        return true
    end
   
    player:setBankBalance(player:getBankBalance() + math.random(1, maxGold)
    player:sendTextMessage(MESSAGE_STATUS_DEFAULT, string.format('You recived %d gold coin%s.', config.maxGold, config.maxGold ~= 1 and "s" or ""))
    return true
end

 

[Il Knight]

thanks for your help its give me an error on line 16 expect to close because need other ")"
and give other error in getmonster

i resolve that with

local value = math.random(0, 10)

function onKill(player, target, mostDamageKiller)

if getCreatureName(target) == "Rat" then
player:setBankBalance(player:getBankBalance() + value)
player:sendTextMessage(MESSAGE_STATUS_DEFAULT, value)

end
return true
end

but i need add something like
local config = {
monstersNames = {"Rotworm", "Rat"},

and have other problem if you kill a rat and give 5 gp, all the other rats give 5gp-- how i can resolve this?

 

[president vankk]

Update the L16 of the script which I did to

player:setBankBalance(player:getBankBalance() + math.random(1, maxGold))

and test with it.

 

[Il Knight]

done, still giving the same amount to all the monsters but if i reload creaturescripts change to other value
need to add something more after end? to change the amount of the math to the next monster

 

[president vankk]

Hm, don't know how I use to stop giving the same amount of every monsters, may you can use this script made by zbizu. You may do a few modifications to achieve what you want.

 

[Il Knight]

i will try, thanks bro

 

[Xikini]

Put the table inside the function.
When the table is outside of the function, math.random only executes once, at the time of the script loading into the server.

Put like this.

function onKill(player, target)

local config = {
    monstersNames = {"Rotworm", "Rat"},
    maxGold = 100
}
.
.
rest of script

 

[Il Knight]

give me error on getmonster

 

[Xikini]

give me error on getmonster

What TFS are you using?

 

[Il Knight]

tfs 1.2 latest sources

 

[Xikini]

idk.
instead of using 'monster' use a different name?

local targetMonster = target:getMonster()
if not targetMonster then
     return true
end

(For future posts, can you post your current script, and any errors you get?
Kind of hard to troubleshoot based on what we think the script looks like atm.)

 

[Il Knight]

Okay this is the current script (working but still need some things)

local value = math.random(0, 10)

function onKill(player, target, mostDamageKiller)

    if getCreatureName(target) == "Rat" then
    player:setBankBalance(player:getBankBalance() + value)
    player:sendTextMessage(MESSAGE_STATUS_DEFAULT, value)

    end
    return true
    end

when you kill a "RAT" this script add to your balance a math number 0-10 and give a default message saying the number but if you kill more rats all give the same amount of the first__ if i close and open the server or use /reload creaturescript the number change and stuck again

 

[Xikini]

Try this.

local monsters = {"rat", "cave rat"}

function onKill(creature, target)
    local targetMonster = target:getMonster()
    if not targetMonster then
        return true
    end

    if not isInArray(monsters, targetMonster:getName():lower()) then
        return true
    end

    local value = math.random(0, 10)

    player:setBankBalance(player:getBankBalance() + value)
    player:sendTextMessage(MESSAGE_STATUS_DEFAULT, value)

    return true
end

 

[Il Knight]

attempt to call method "getmonster" (a nil value)

function onKill(player, target, mostDamageKiller)

local value = math.random(0, 10)

    if getCreatureName(target) == "Rat" then
    player:setBankBalance(player:getBankBalance() + value)
    player:sendTextMessage(MESSAGE_STATUS_DEFAULT, value)

    end
    return true
    end

this work! only need to use local value before function like you say thanks, now i need to edit the player:sendtext.. (to say correct message XXX gold coins gained in the battle) and add local config ( monsters)

 

[Xikini]

attempt to call method "getmonster" (a nil value)

Sorry, I'll stop using stuff copied from vankk. lmao

local monsters = {"rat", "cave rat"}

function onKill(creature, target)
    if not target:isMonster() then
        return true
    end

    if not isInArray(monsters, target:getName():lower()) then
        return true
    end

    local value = math.random(0, 10)

    player:setBankBalance(player:getBankBalance() + value)
    player:sendTextMessage(MESSAGE_STATUS_DEFAULT, value)

    return true
end

 

[Il Knight]

How i can add a math.random for each creature name?

 

[Xikini]

How i can add a math.random for each creature name?

Just going to put this out there, that I'm not a great scripter.
But this is how I would personally do it.

function onKill(creature, target)
    if not target:isMonster() then
        return true
    end

    local monsters = {
        [1] = { name = "rat",      min_gold = 1, max_gold = 100 },
        [2] = { name = "cave rat", min_gold = 1, max_gold = 100 }
    }

    for i = 1, #monsters do
        if monsters[i].name == target:getName():lower() then
            local value = math.random(monsters[i].min_gold, monsters[i].max_gold)
            player:setBankBalance(player:getBankBalance() + value)
            player:sendTextMessage(MESSAGE_STATUS_DEFAULT, value)
            break
        end
    end

    return true
end

 

[Omni Cloud]

@Xikini what if target is a summon?
Because then I could summon a rat and kill it and get gold

 

[Il Knight]

@Xikini what if target is a summon?
Because then I could summon a rat and kill it and get gold

thanks!
if isPlayer(target) or isSummon(target) then
return true
end