onKill help.

[Ninja Bodil]

So this script should give a storage value when you kill a monster, but nothing happens.
I've put the name of the event in login.lua but nothing. And I get no errors.

function onKill(cid, target, lastHit)
    if getCreatureName(target) == "Test Monster" then
    if isPlayer(target) then return true end
		if getCreatureStorage(cid, 6501) > 0 then
			if getCreatureStorage(cid, 6501) < 50 then
			    if getCreatureStorage(cid, 6501) < 0 then
					doCreatureSetStorage(cid, 6501, 0)
				end
	            doCreatureSetStorage(cid, 6501, getCreatureStorage(cid, 6501) + 1)
	            doSendAnimatedText(cid, getCreatureStorage(cid, 6501), 255)
			end	
	    end
	end
	return true
end

 

[Gesior.pl]

if getCreatureStorage(cid, 6501) > 0 then -- higher then 0
if getCreatureStorage(cid, 6501) < 50 then -- lower then 50
if getCreatureStorage(cid, 6501) < 0 then -- lower then 0?!!? how can it be lower then zero if you checked 2 line over that it's higher then 0

try debug:

function onKill(cid, target, lastHit) 
print('1' .. getCreatureName(target)
    if getCreatureName(target) == "Test Monster" then 
print('2 name valid')
    if isPlayer(target) then print('3 fail! is player') return true end 
print('3 all ok, add count')
           doCreatureSetStorage(cid, 6501, math.max(0, getCreatureStorage(cid, 6501)) + 1) 
           doSendAnimatedText(cid, getCreatureStorage(cid, 6501), 255) 
    end 
print('4 finish')
    return true 
end

It will show in console of server what script execute and what not.
I removed check how many is killed, because I don't see any reason why it should limit it to 50.
math.max(0, getCreatureStorage(cid, 6501)) - function 'max' will return 0 when storage will be lower then 0

 

[Ninja Bodil]

Thx alot Gesior, it was kind of an easy problem. But I've never thought of that print thing. It can be rly usefull. thx alot and rep+!