Lua onPrepareDeath problem...help please

[kird]

Well i took this script from mock's post and modified it a bit. It's a script so the players gets teleported to the temple if its health goes to 0. (yes, like in pvp arena script)
Everything goes fine but i just cant modify the players health after it "dies".

It stands on the temple with 0 health and nither the spells or the functions (doAddCreatureHealth) works.

Seems like you cant modify the health variable anymore once your health goes under 0.
what's wrong?

local templePos = {x = 1011, y = 1008, z = 6}

function onPrepareDeath(cid,aa) -- Script by mock the bear

	doPlayerAddHealth(cid,getCreatureMaxHealth(cid))
	doCreatureAddMana(cid,getCreatureMaxMana(cid))
	doTeleportThing(cid,getTownTemplePosition(getPlayerTown(cid)))
        return false
end

It's 0.3.6pl1

Thanx in advance
Kird~

 

[cbrm]

what about if the cid is a monster? you want it to teleport to temple oO

function onPrepareDeath(cid, deathlist)
    if isPlayer(cid) then
        doCreatureAddHealth(cid,getCreatureMaxHealth(cid)-getCreatureHealth(cid)) 
        doCreatureAddMana(cid, getCreatureMaxMana(cid)-getCreatureMana(cid))
        doTeleportThing(cid,getTownTemplePosition(getPlayerTown(cid)))
        return false    
    end
return true
end

 

[Ecstacy]

use this function.

function onStatsChange(cid, attacker, type, combat, value) //creaturescripts

 

[cbrm]

@up: what for?
EDIT:

function onPrepareDeath(cid, deathlist)
    if isPlayer(cid) then
        doRemoveConditions(cid)
        doCreatureAddHealth(cid,getCreatureMaxHealth(cid)-getCreatureHealth(cid)) 
        doCreatureAddMana(cid, getCreatureMaxMana(cid)-getCreatureMana(cid))
        doTeleportThing(cid,getTownTemplePosition(getPlayerTown(cid)))
        return false    
    end
return true
end

 

[kird]

Its for a OB System, there will be no mosnters, anyway i'll use ur advice

@unKnown666--I tried this function,and worked 2 days ago, but i was afraid of the server lagging because of an event checking on statschange on every player in the server.
is that possble or I am wrong with that?

Thnx for the replis btw

 

[Ecstacy]

You're wrong.

 

[cbrm]

Its for a OB System, there will be no mosnters, anyway i'll use ur advice

@unKnown666--I tried this function,and worked 2 days ago, but i was afraid of the server lagging because of an event checking on statschange on every player in the server.
is that possble or I am wrong with that?

Thnx for the replis btw

what about mine? it worked?

 

[kird]

My script is working already, its just that the function doPLayerAddHealth doesnt work on this script. Didn't test yours, bt i guess if you only added the isPlayer line it'll work

btw, im gonna use the statsChange function, lets see how it beheaves
Thnx both of you for ur help

 

[cbrm]

return true must always be before the end of all creature scripts
ahm use mine, it's the one you're looking for

 

[kird]

Im sry but you are wrong this time.
When you use the onPrepareDeat function if it returns true the char will die, in the other hand if it return false the char won't die its when u can use all those teleport and addhealth functions etc..

 

[cbrm]

lol you don't get it, anyways return true must always be there, when we want to make the creature not to die we use return false, but return true has to be down there

 

[kird]

mhmm
U think it might be the problem for the addCreatureHealth not working?
appart from that the whole script is working

 

[cbrm]

man, has MY script actually worked for you?

 

[kird]

No
I mean, it works fine except for the addPlayerHealth
it gets tpped but stands on the tmple with 0 health, and the console is looping over this script as the char has 0 health all the time.
Neither addPlayerHealth or healing spells in-game seems to be changeing the health variable.

But its not your script, all i used ended up the same way

 

[cbrm]

well, lets see then

local templePos = {x = 1011, y = 1008, z = 6} --USELESS

function onPrepareDeath(cid,aa) -- Script by mock the bear --aa should be deathlist, but it doesn't matter, it isn't being used

doPlayerAddHealth(cid,getCreatureMaxHealth(cid)) --maybe won't work, doPlayerAddHealth doesn't exist!
doCreatureAddMana(cid,getCreatureMaxMana(cid)) --maybe it will work
doTeleportThing(cid,getTownTemplePosition(getPlayerTown(cid)))
return false --WRONG, MONSTERS, PLAYERS, EVERYONE WONT DIE AND MONSTERS WILL DEBUG, THEY DONT HAVE TEMPLE!
end --MISSING RETURN TRUE

return false is badly placed

compare:

  function  onPrepareDeath(cid, deathlist)
    if isPlayer(cid) then
        doRemoveConditions(cid)
        doCreatureAddHealth(cid,getCreatureMaxHealth(cid)-getCreatureHealth(cid))
        doCreatureAddMana(cid, getCreatureMaxMana(cid)-getCreatureMana(cid))
        doTeleportThing(cid,getTownTemplePosition(getPlayerTown(cid)))
        return false    
    end
return true
end

 

[kird]

doPlayerAddhealth does exist, else it would debug
anyway, i tries doPlayerAddHealth as doCreatureAddHealth wasnt working either.

And its not this script, i tried a whole bunch of pvp-arena scripts and everytime is the same.
It seems like doCreatureAddHealth isn't compatible with onPrepareDeath

 

[cbrm]

they are comp. man are you using TFS 0.3.6 patch level 1?

//do*
doCreatureAddHealth(cid, health[, force])
doCreatureAddMana(cid, mana)

 

[kird]

yes, i guess u mean 0.3.6pl1

 

[cbrm]

ahm just test my script, then tell me what happens

 

[Rexxar]

So wait... doCreatureAddMana works, but not doCreatureAddHealth?