Action [onUse] Diamond of Life.

[Zatjin]

Hi there!

This is one of my first scripts so don't flame me

local gain = 250
function onUse(cid, item, fromPosition, itemEx, toPosition)

if item.uid = 2153 then
	if getPlayerLevel(cid) == 20 then
		doPlayerSendTextMessage(cid, 21, "You have gained some health and mana!")
		doCreatureAddHealth(cid, gain)
		doPlayerAddMana(cid, gain)
	else
		doPlayerSendCancel(cid, "You dont have the required level")
	end
end
return TRUE
end

Add this to your actions.xml

<action itemid="2153" event="script" value="diamondoflife.lua"/>

Please do tell if my tabbing is correct I feel it's much cleaner if it's done that way..

It's probably wrong

Sincerely,
Zatjin

 

[Clint]

It's nice, I'm not a scripter, but it looks fine to me.

 

[Bogart]

You forgot an end. remember, for each if, loop, and function there must be an end.
Also, if you want the players that are level 20 or higher use getPlayerLevel(cid) >= 20

> doSendPlayerCancel (cid, "You don't have the required level")
there's a space between 'doSendPlayerCancel' and '('
and it's doPlayerSendCancel(cid, "You don't have the required level")
also, doCreatureAddHealth(cid, gain) and doPlayerSendTextMessage(cid, 21, "You have gained some health and mana")

 

[Zatjin]

You forgot an end. remember, for each if, loop, and function there must be an end.
Also, if you want the players that are level 20 or higher use getPlayerLevel(cid) >= 20

> doSendPlayerCancel (cid, "You don't have the required level")
there's a space between 'doSendPlayerCancel' and '('
and it's doPlayerSendCancel(cid, "You don't have the required level")
also, doCreatureAddHealth(cid, gain) and doPlayerSendTextMessage(cid, 21, "You have gained some health and mana")

Say whaat?
And I want the player to be exactly 20.
It should be like this?

function onUse (cid, item, fromPosition, ItemEx, toPosition)
local gain = 250
	if item.itemuid ==  2153 and getPlayerLevel(cid) == 20
	doSendPlayerTextMessage (cid,21,"You have gained some health and mana!")
	doAddPlayerHealth(cid,gain)
	doAddPlayerMana(cid,gain)
	end
else
	doSendPlayerCancel (cid,"You don't have the required level")
	return TRUE
end

 

[Bogart]

function onUse(cid, item, fromPosition, itemEx, toPosition)
local gain = 250
if item.uid = 2153 then
	if getPlayerLevel(cid) == 20 then
		doPlayerSendTextMessage(cid, 21, "You have gained some health and mana!")
		doCreatureAddHealth(cid, gain)
		doPlayerAddMana(cid, gain)
	else
		doPlayerSendCancel(cid, "You dont have the required level")
	end
end
return TRUE
end

 

[president vankk]

doPlayerSendCancel(cid, "You dont have the required level"=

>>= ? gzz


doPlayerSendCancel(cid, "You dont have the required level")

 

[Bogart]

doPlayerSendCancel(cid, "You dont have the required level"=

>>= ? gzz


doPlayerSendCancel(cid, "You dont have the required level")

Ah, yeah.
a little typo, thanks for pointing it out.

 

[Zatjin]

function onUse(cid, item, fromPosition, itemEx, toPosition)
local gain = 250
if item.uid = 2153 then
	if getPlayerLevel(cid) == 20 then
		doPlayerSendTextMessage(cid, 21, "You have gained some health and mana!")
		doCreatureAddHealth(cid, gain)
		doPlayerAddMana(cid, gain)
	else
		doPlayerSendCancel(cid, "You dont have the required level")
	end
end
return TRUE
end

Thanks Bogart!

I'll update my MP