Param problem, everytime printing wrong

[vexler222]

Hi, can someone tell me why this script printing everytime wrong? When i put good answer, still i got wrong in console.
(Im in area, script what check if player is in area working good)

local answer = TalkAction("!as")

local function isInArena(player)
    local pos = player:getPosition()
    local rooms = {
    [1] = {as = "t", rPos  = {{x = 2850, y = 2133, z = 7},{x = 2865, y = 2146, z = 7}}},
    [2] = {as = "", rPos = {{x = 2891, y = 2134, z = 7},{x = 2904, y = 2151, z = 7}}},
}
local room_x = player:getStorageValue(as.room)

    if pos.z == rooms[room_x].rPos[1].z then
        if pos.x >= rooms[room_x].rPos[1].x and pos.y >= rooms[room_x].rPos[1].y then
            if pos.x <= rooms[room_x].rPos[2].x and pos.y <= rooms[room_x].rPos[2].y then
                if param == rooms[room_x].as then
                    print("good")
                else
                    print("wrong")
                end
                return true
            end
        end
    end
    player:sendTextMessage(MESSAGE_EVENT_DEFAULT,"Poff Poff")
    return true
end

function answer.onSay(player, words, param)

    isInArena(player)

end

answer:separator(" ")
answer:register()

 

[Boy67]

you're not passing param to isInArena...

 

[vexler222]

you're not passing param to isInArena...

You mean add param in isInArena function? - local function isInArena(player, param)

If u meand it, not work still ;p Btw im using function isInArena, inside onSay function, so it not passing param to isInArena function?

Post automatically merged: Jul 26, 2022

Ok, nvm!
When i put local function (all code) inside onsay, it work ;p

 

[Gesior.pl]

You call function isInArena without passing param variable.
Fixed version:

local answer = TalkAction("!as")

-- move config out of function
local rooms = {
    [1] = {as = "t", rPos  = {{x = 2850, y = 2133, z = 7},{x = 2865, y = 2146, z = 7}}},
    [2] = {as = "", rPos = {{x = 2891, y = 2134, z = 7},{x = 2904, y = 2151, z = 7}}},
}

local function isInArena(player, param) -- HERE add `param`
    local pos = player:getPosition()
    local room_x = player:getStorageValue(as.room)

    if pos.z == rooms[room_x].rPos[1].z then
        if pos.x >= rooms[room_x].rPos[1].x and pos.y >= rooms[room_x].rPos[1].y then
            if pos.x <= rooms[room_x].rPos[2].x and pos.y <= rooms[room_x].rPos[2].y then
                if param == rooms[room_x].as then
                    print("good")
                else
                    print("wrong")
                end
                return true
            end
        end
    end
    player:sendTextMessage(MESSAGE_EVENT_DEFAULT,"Poff Poff")
    return true
end

function answer.onSay(player, words, param)
    isInArena(player, param) -- HERE add `param`

end

answer:separator(" ")
answer:register()

 

[Xikini]

You call function isInArena without passing param variable.
Fixed version:

local answer = TalkAction("!as")

-- move config out of function
local rooms = {
    [1] = {as = "t", rPos  = {{x = 2850, y = 2133, z = 7},{x = 2865, y = 2146, z = 7}}},
    [2] = {as = "", rPos = {{x = 2891, y = 2134, z = 7},{x = 2904, y = 2151, z = 7}}},
}

local function isInArena(player, param) -- HERE add `param`
    local pos = player:getPosition()
    local room_x = player:getStorageValue(as.room)

    if pos.z == rooms[room_x].rPos[1].z then
        if pos.x >= rooms[room_x].rPos[1].x and pos.y >= rooms[room_x].rPos[1].y then
            if pos.x <= rooms[room_x].rPos[2].x and pos.y <= rooms[room_x].rPos[2].y then
                if param == rooms[room_x].as then
                    print("good")
                else
                    print("wrong")
                end
                return true
            end
        end
    end
    player:sendTextMessage(MESSAGE_EVENT_DEFAULT,"Poff Poff")
    return true
end

function answer.onSay(player, words, param)
    isInArena(player, param) -- HERE add `param`

end

answer:separator(" ")
answer:register()

While we're at it, use the pre-built function from core to check if is in range

local answer = TalkAction("!as")

-- move config out of function
local rooms = {
    [1] = {as = "t", rPos  = {Position(2850, 2133, 7), Position(2865, 2146, 7)}},
    [2] = {as = "", rPos = {Position(2891, 2134, 7), Position(2904, 2151, 7)}},
}

local function isInArena(player, param) -- HERE add `param`
    local room_x = player:getStorageValue(as.room) -- assuming 'as' table is loaded globally somewhere..?  
    if not rooms[room_x] then
        print("room_x doesn't exist in table. -> " .. room_x)
        return true
    end
  
    if player:getPosition():isInRange(rooms[room_x].rPos[1], rooms[room_x].rPos[2]) -- Position:isInRange(from, to)
        if param == rooms[room_x].as then
            print("good")
        else
            print("wrong")
        end
        return true
    end
    player:sendTextMessage(MESSAGE_EVENT_DEFAULT,"Poff Poff")
    return true
end

function answer.onSay(player, words, param)
    isInArena(player, param) -- HERE add `param`
  
end

answer:separator(" ")
answer:register()

 

[Boy67]

and also while we're at it, its good to learn how to debug. There are not many options when debugging in LUA so just print a few variables that affect the desired output.

print(pos.z)
print(rooms[room_x].rPos[1].z)
--and so on....
print(param) --would of returned nil...

if pos.z == rooms[room_x].rPos[1].z then
    if pos.x >= rooms[room_x].rPos[1].x and pos.y >= rooms[room_x].rPos[1].y then
        if pos.x <= rooms[room_x].rPos[2].x and pos.y <= rooms[room_x].rPos[2].y then
            if param == rooms[room_x].as then
                print("good")
            else
                print("wrong")
            end
            return true
        end
    end
end

 

[Gesior.pl]

but be wary when you see nil as a print, it can mean 0 too

What? How? 0 is logic true and nil is false. It would be serious Lua bug, if print shows wrong value. nil means 'undefined'.
My 3 points instruction to start Lua programming:

LUA BASICS for other language programmers – HALP!

 

[Boy67]

Yup my bad. Was late when I wrote it and I had been working with 5 different languages yesterday. But the principles behind the post still stand, most people just don't even bother checking/printing variables at all.