Fix/Patch Parsing Storage Values Inside of Quest.xml

[QuaS]

Hi Otlanders. I'll give you quest system which parse storage values from players questlog.

Here We go:

Replace whole

std::string Mission::getDescription(Player* player)

from quests.cpp to

std::string Mission::getDescription(Player* player)
{
	std::string value;
	int32_t find_storage;
	player->getStorage(storageId, value);
	if(state.size())
	{
		std::string ret = state;
		while((find_storage=ret.find("|STORAGE:"))>-1)
		{
              int32_t parsing_storage = find_storage+9;
              std::string temp;
              while((int) ret[parsing_storage] != (int)'|')
              {
                   temp += ret[parsing_storage];
                   parsing_storage++;
              }
              parsing_storage -=find_storage-1;
              player->getStorage(atoi(temp.c_str()), temp);
              ret.replace(find_storage, parsing_storage, temp);
        }
		replaceString(ret, "|STATE|", value);
		return ret;
	}

	if(atoi(value.c_str()) >= endValue)
	{
		std::string ret = states.rbegin()->second;
		while((find_storage=ret.find("|STORAGE:"))>-1)
		{
              int32_t parsing_storage = find_storage+9;
              std::string temp;
              while((int) ret[parsing_storage] != (int)'|')
              {
                   temp += ret[parsing_storage];
                   parsing_storage++;
              }
              parsing_storage -=find_storage-1;
              player->getStorage(atoi(temp.c_str()), temp);
              ret.replace(find_storage, parsing_storage, temp);
        }
		replaceString(ret, "|STATE|", value);
		return ret;
	}

	for(int32_t i = endValue; i >= startValue; --i)
	{
		player->getStorage(storageId, value);
		if(atoi(value.c_str()) != i)
			continue;

		std::string ret = states[i - startValue];
		while((find_storage=ret.find("|STORAGE:"))>-1)
		{
              int32_t parsing_storage = find_storage+9;
              std::string temp;
              while((int) ret[parsing_storage] != (int)'|')
              {
                   temp += ret[parsing_storage];
                   parsing_storage++;
              }
              parsing_storage -=find_storage-1;
              player->getStorage(atoi(temp.c_str()), temp);
              ret.replace(find_storage, parsing_storage, temp);
        }
		replaceString(ret, "|STATE|", value);
		return ret;

	}

	return "Couldn't retrieve any mission description, please report to a gamemaster.";
}

How make it works? Write in ur quest message a "|STORAGE:NUMBER|"
For Example:

<mission name="The head of Kiper" storageid="1001" startvalue="1" endvalue="3">
<missionstate id="0" description="Kill Rotworms to summon a Kiper!! You've killed already |STORAGE:1002|/50 Rotworms and |STORAGE:1500|/2 Carrion Rotworms."/>
<missionstate id="1" description="Give his head to Talaturen!"/>
<missionstate id="2" description="Take the medal you got from Talaturen to Ruly!"/>
</mission>

Screenshot Ingame:

It's kinda good for such quests like "Killin in the name of.." Quest.

Btw: this are my first litte steps in TFS enviroment

//Tested on trunk 3660.

 

[JDB]

Cool, good one. :thumbup:

 

[Legnak Bqm]

nice man, really nice, thanks for sharing

 

[Fallen]

very nice

 

[zakius]

luv ya :*
but to pwn Cyko you need some more great stuff xD

 

[Exedion]

Nice Script!!! i will use for my achievements system, can you add the feature to use "/n" like lua scripts?

 

[Sync]

very nice

 

[calum69]

good job il def use it rep ++

 

[chojrak]

Great job, sir.

 

[VirrageS]

Nice man
Thx

 

[Tairens]

Great man! Very useful code. Rep++

 

[richux]

luv ya :*
but to pwn Cyko you need some more great stuff xD

is Cyko even into C++? :d

 

[BeniS]

you are the bestest lol xD

 

[JuanC]

Replace whole

std::string Mission::getDescription(Player* player)

from quests.cpp to

std::string Mission::getDescription(Player* player)
{
	std::string value;
	int32_t find_storage;
	player->getStorage(storageId, value);
	if(state.size())
	{
		std::string ret = state;
		while((find_storage=ret.find("|STORAGE:"))>-1)
		{
              int32_t parsing_storage = find_storage+9;
              std::string temp;
              while((int) ret[parsing_storage] != (int)'|')
              {
                   temp += ret[parsing_storage];
                   parsing_storage++;
              }
              parsing_storage -=find_storage-1;
              player->getStorage(atoi(temp.c_str()), temp);
              ret.replace(find_storage, parsing_storage, temp);
        }
		replaceString(ret, "|STATE|", value);
		return ret;
	}

	if(atoi(value.c_str()) >= endValue)
	{
		std::string ret = states.rbegin()->second;
		while((find_storage=ret.find("|STORAGE:"))>-1)
		{
              int32_t parsing_storage = find_storage+9;
              std::string temp;
              while((int) ret[parsing_storage] != (int)'|')
              {
                   temp += ret[parsing_storage];
                   parsing_storage++;
              }
              parsing_storage -=find_storage-1;
              player->getStorage(atoi(temp.c_str()), temp);
              ret.replace(find_storage, parsing_storage, temp);
        }
		replaceString(ret, "|STATE|", value);
		return ret;
	}

	for(int32_t i = endValue; i >= startValue; --i)
	{
		player->getStorage(storageId, value);
		if(atoi(value.c_str()) != i)
			continue;

		std::string ret = states[i - startValue];
		while((find_storage=ret.find("|STORAGE:"))>-1)
		{
              int32_t parsing_storage = find_storage+9;
              std::string temp;
              while((int) ret[parsing_storage] != (int)'|')
              {
                   temp += ret[parsing_storage];
                   parsing_storage++;
              }
              parsing_storage -=find_storage-1;
              player->getStorage(atoi(temp.c_str()), temp);
              ret.replace(find_storage, parsing_storage, temp);
        }
		replaceString(ret, "|STATE|", value);
		return ret;

	}

	return "Couldn't retrieve any mission description, please report to a gamemaster.";
}

How i can set this?

 

[Diath]

<missionstate id="1" description="You have killed |STORAGE:1337| crocodiles."/>

 

[Cykotitan]

is Cyko even into C++? :d

nop

 

[Stewie]

very nice ;d

 

[Dankoo]

Dude, take a look:

I have replaced the whole code:

std::string Mission::getDescription(Player* player)
{
	std::string value;
	player->getStorage(storageId, value);
	if(state.size())
		return parseStorages(state, value);

	if(atoi(value.c_str()) >= endValue)
		return parseStorages(states.rbegin()->second, value);

	for(int32_t i = endValue; i >= startValue; --i)
	{
		player->getStorage(storageId, value);
		if(atoi(value.c_str()) == i)
			return parseStorages(states[i - startValue], value);
	}

	return "Couldn't retrieve any mission description, please report to a gamemaster.";
}

With the code you've posted, but I receive this error:

Any ideas? Using REV 3884

 

[Sheinen Highfive]

# same error with rev3882, using windows 7 32bit to compile...

 

[Dankoo]

Solutions? *-*