[PHP] Simple Content Display class

[Zonet]

Hey, here is my simple content display!

    <?PHP
            class View
            {
            public $_show = null;
                    public function __construct( $subtopic, $_404 = 'not_found' )
                    {
                            if( file_exists( './pages/'.$subtopic.'.php' ) && isset( $subtopic ) )
                            {
                                            $this->_show = './pages/'.$subtopic.'.php';
                            }
                            else
                            {
                                    header( 'Location: ?subtopic='.$_404 );
                            }                      
                    }
                   
                    public function display() {
                        require_once( $this->_show );
                    }
            }
    ?>

Usage:

<?PHP
            echo $view->display();  
?>

etc ..

What do you think, is it a good way?

 

[Cykotitan]

always hated classes and OOP, but ok. just feels like bloat

 

[Zonet]

nonono! i love oop<3

 

[Chris]

OOP is great for somewhat larger projects (smaller ones as well in my opinion, but I can see how someone may dislike it (especially if that person have not worked with it before (or at least not much (many parenthesis!)))).

As for your content displayer, you should make it a habit of always adding the underscore to private/protected variables, not public ones (same goes for methods) as this is the most common and widely known use of it.

The isset( $subtopic ) within the if statement is also unnecessary as $subtopic always has to have a value (whether it be NULL or not, it still has to be defined).

What I would also do is change;

if( file_exists( './pages/'.$subtopic.'.php' ) && isset( $subtopic ) )
{
     $this->_show = './pages/'.$subtopic.'.php';
}
else
{
     header( 'Location: ?subtopic='.$_404 );
}

to something like;

if( !file_exists( './pages/'.$subtopic.'.php' ) )
{
     header( 'Location: ?subtopic='.$_404 );
     exit;
}

$this->_show = './pages/'.$subtopic.'.php';

Other than that, it looks good!

 

[Zonet]

Thank you Chris!

 

[christiandb]

OOP is the best, I hate functional languages like fkin Scala.