Fix/Patch Player Protection against debuging client with ElfBot NG

[Atleta]

fuck botters

 

[Deleted member 12419]

FFS this does not seem to work :s not for tfs 0.3.5pl1

 

[ragal]

FFS this does not seem to work :s not for tfs 0.3.5pl1

in 0.3.5pl1 Is This Allready implented lol

 

[l0lz]

hello i have tfs 0.3.4 and i dont see protocolgame.cpp where ist this ? where i must edit this or any programs ist for this ?

 

[Elexonic]

Tfs 0.3.5 Pl1 It has this script ¿?

 

[5mok3]

hate botters

 

[pawelsuperpawel]

On TFS 0.3.4 PL2 doesn't work? This is my edited game.cpp:

http://www.przeklej.pl/plik/game-cpp-00048t8a040i

And when i am use command debug all with me have a debug.
Sorry for my bad English.

 

[GSMaster]

save players in logs (bots.log)

if(text.length() > 255)

{
		std::stringstream s;
		s << text.length();
		
std::ofstream output("data/logs/bots.log", std::ios_base::app);
 output << formatDate() + " - Player nick: " + player->getName() + " : " + s.str() + " |255 max ! " << std::endl;

 return;  
}

 

[Nostradamus]

if(text.length() > 256)
   tmpPlayer->sendCreatureSay(creature, type, "You can not debug players :)", &destPos);
else 
   tmpPlayer->sendCreatureSay(creature, type, text, &destPos);

Why you need an else for that? I mean, if the length is higher than the max limit, you don't need to make nothing.

 

[Red]

This doesn't seem to work with 0.2.5, of course. u_u
Good work, nonetheless.

Red

 

[Tenhum]

wow nicee i will try
and nice cap XD

 

[Backy]

Dont work for me.. im using tfs 0.3.3 tibia 8.42

 

[DanJ93]

Nice!!!!

 

[widnet]

is working on 0.3.6_svn?

 

[Cykotitan]

is working on 0.3.6_svn?

you don't need to add this fix, it's already included in 0.3.6's protocolgame.cpp:

	const std::string text = msg.GetString();
	if(text.length() > 255) //client limit
	{
		std::stringstream s;
		s << text.length();

		Logger::getInstance()->eFile("bots/" + player->getName() + ".log", "Attempt to send message with size " + s.str() + " - client is limited to 255 characters.", true);
		return;
	}

 

[Twoj]

Hello. You can write a script in Creaturescript? Do I need to compile the entire engine?

 

[Mazen]

This method is quiet ineffective. You should reduce the string length by removing the last characters. For example if a string is 270 characters long, the server should automatically filter the last 15 characters.

Imo this is a bug in OTServ, players should not be able to debug anyone this way.

 

[natix4]

Nicee ;]

 

[Twoj]

Another question. When I took the TFS engine down from the Internet it is a file. exe filled 5181 KB, and when alone I compiled it for myself filled 3984 KB. I don't know why this way he is and I don't also know whether because of that I won't be lacking something or/and something won't work. For me can somebody explain why such a difference is?

Srry English ;(

 

[Amoaz]

Really nice if it works. I will have a great use of it then