TFS 1.X+ Players recieve double damage from other players

[venius]

I have a weird bug where players attacking other players deal double damage. This is only the case for actual health change and NOT for mana change. So if I player hits another player with utamo vita then the damage is calculated properly. Any ideas? I modified something in "game.cpp" a while ago, maybe I messed it up there?

(TFS 1.5, 8.6 downgraded by Nekiro)

 

[Addams]

It could be an onHealthChange script, Do you have any of it?

 

[venius]

Yes, but I think it's a problem tied to sources...

Gyazo (https://gyazo.com/a3b4ffeb174806dfa0ee280297c73d01)

As you can see the player attacking hits 257 on the other player, but the console says it's double that damage, and the actual damage is ~510.
So somehow these have been mixed up by me...

 

[Obito]

Ig you should use

combat:setOrigin(ORIGIN_WAND)

If you are using wand or smth i ran with this before as i remember.

 

[venius]

Ig you should use

combat:setOrigin(ORIGIN_WAND)

If you are using wand or smth i ran with this before as i remember.

It is not exclusive to wand damage, the wand was just to display the bug. All damage is doubled when attacking other players' HP

 

[Evil Puncker]

99% sure it is related to onHealthChange script you got, since no one else using nekiros downgrade reported this issue

 

[venius]

99% sure it is related to onHealthChange script you got, since no one else using nekiros downgrade reported this issue

I was implying that I changed something in sources that messed things up. It was definitely working before...
The only onHealthChange script I have is also paired with an OnManaChange script, so shouldn't both be bugged then? idk

 

[Sarah Wesker]

in case it's something from the sources it's probably in the Game::combatChangeHealth function in game.cpp
if you leave a link to that file in your repository we can review it.

 

[venius]

in case it's something from the sources it's probably in the Game::combatChangeHealth function in game.cpp
if you leave a link to that file in your repository we can review it.

GitHub - SebastianBaba/game.cpp (https://github.com/SebastianBaba/game.cpp) here you go

 

[Obito]

GitHub - SebastianBaba/game.cpp (https://github.com/SebastianBaba/game.cpp) here you go

If you are rebirthed just make sure that your config has this

rebornDmg = 0

or whatever you have just replace it with zero and check the damage

 

[venius]

If you are rebirthed just make sure that your config has this

rebornDmg = 0

or whatever you have just replace it with zero and check the damage

None of my characters are rebirthed

 

[Roddet]

None of my characters are rebirthed

on Game::combatChangeHealth(...)

Look for:

std::cout << bonusRebirth << std::endl;

damage.primary.value = std::abs(damage.primary.value) * bonusRebirth;
damage.secondary.value = std::abs(damage.secondary.value) * bonusRebirth;

Replace with:

std::cout << bonusRebirth << std::endl;

std::clog << "raw-damage: " << std::abs(damage.primary.value) << " - " << std::abs(damage.secondary.value) << std::endl;

damage.primary.value = std::abs(damage.primary.value) * bonusRebirth;
damage.secondary.value = std::abs(damage.secondary.value) * bonusRebirth;

std::clog << "mod-damage: " << damage.primary.value << " - " << damage.secondary.value << std::endl;

Also add this, on here

std::clog << "damageStr: " << damage.primary.value << " - " << damage.secondary.value << std::endl;

Compile and do the same exact test again

 

[venius]

on Game::combatChangeHealth(...)

Look for:

std::cout << bonusRebirth << std::endl;

damage.primary.value = std::abs(damage.primary.value) * bonusRebirth;
damage.secondary.value = std::abs(damage.secondary.value) * bonusRebirth;

Replace with:

std::cout << bonusRebirth << std::endl;

std::clog << "raw-damage: " << std::abs(damage.primary.value) << " - " << std::abs(damage.secondary.value) << std::endl;

damage.primary.value = std::abs(damage.primary.value) * bonusRebirth;
damage.secondary.value = std::abs(damage.secondary.value) * bonusRebirth;

std::clog << "mod-damage: " << damage.primary.value << " - " << damage.secondary.value << std::endl;

Also add this, on here

std::clog << "damageStr: " << damage.primary.value << " - " << damage.secondary.value << std::endl;

Compile and do the same exact test again

All of them print the same number, which is the number that should be there not the 2x value

 

[Sarah Wesker]

GitHub - SebastianBaba/game.cpp (https://github.com/SebastianBaba/game.cpp) here you go

It is possible that this is being repeated twice, since when the onHealthChange events are executed, it calls the same function again but without origin

 

[Roddet]

All of them print the same number, which is the number that should be there not the 2x value

Taking your last gift as example, its printing 255~257 ?

@Sarah Wesker but code is not executed until the second call, since its returned as a bool
Edit: ah nvm, I was looking at the healing code instead damage but still im not sure if that could be the issue

 

[venius]

Taking your last gift as example, its printing 255~257 ?

@Sarah Wesker but code is not executed until the second call, since its returned as a bool
Edit: ah nvm, I was looking at the healing code instead damage still im not sure if that could be the issue

Yeah, it is printing exactly that. I'm not sure either...

 

[Sarah Wesker]

Yeah, it is printing exactly that. I'm not sure either...

ok if you have a bug in game.cpp it can be easily resolved by moving that to combat.cpp, now if you can show us the combat.cpp file to check something else please.

 

[venius]

ok if you have a bug in game.cpp it can be easily resolved by moving that to combat.cpp, now if you can show us the combat.cpp file to check something else please.

Sure thing, GitHub - SebastianBaba/combat.cpp (https://github.com/SebastianBaba/combat.cpp)

 

[venius]

Bump

 

[Roddet]

Yeah, it is printing exactly that. I'm not sure either...

Test again and take an ss to the printed values - also post the onHealthChange script you have