TFS 1.X+ Players recieve double damage from other players

[venius]

I have a weird bug where players attacking other players deal double damage. This is only the case for actual health change and NOT for mana change. So if I player hits another player with utamo vita then the damage is calculated properly. Any ideas? I modified something in "game.cpp" a while ago, maybe I messed it up there?

(TFS 1.5, 8.6 downgraded by Nekiro)

 

[venius]

Gyazo (https://gyazo.com/544996f51ffe30d85d125d461592f220)
I have one active onHealthChange script, I have tried disabling it which did nothing...

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)

    if primaryType == COMBAT_HEALING or secondaryType == COMBAT_HEALING then
        return primaryDamage, primaryType, secondaryDamage, secondaryType
    end
 
    if creature and creature:isPlayer() then
            if creature:getCondition(CONDITION_ATTRIBUTES, CONDITIONID_COMBAT, 56) then
                creature:getPosition():sendMagicEffect(CONST_ME_YELLOWENERGY)
                primaryDamage = 0
                secondaryDamage = 0
            end
    end
return primaryDamage, primaryType, secondaryDamage, secondaryType
end

I have an identical script for mana too.

Maybe I should restore my server to an older version to test if it works?

 

[Roddet]

@venius comment / remove this code, compile and test again

https://github.com/nekiro/TFS-1.5-Downgrades/blob/8.60/src/game.cpp#L3987-L3996

 

[Sarah Wesker]

Ok I know the OP doesn't want a solution for this anymore, but I came to a conclusion about this problem.
there is a creaturescript onHealthChange that is modifying the secondaryType this was confirmed by the prints that @Roddet suggested.
if the type of damage is wrong, then the color will be TEXTCOLOR_NONE, therefore the animated text will not be sent, this makes it look like it is only doing half damage when in fact it is doing full damage as it appears in the message from the player's console.