Solved potions based on maxHP percent

[Amanek]

Hi!

I have a little problem with action script. Console shows error at 33 line.
Somebody see a bug? Need to help.

local config = {
	removeOnUse = "no",
	usableOnTarget = "yes", -- can be used on target? (fe. healing friend)
	splashable = "no",
	realAnimation = "no", -- make text effect visible only for players in range 1x1
	healthMultiplier = 1.0,
	manaMultiplier = 1.0
}

config.removeOnUse = getBooleanFromString(config.removeOnUse)
config.usableOnTarget = getBooleanFromString(config.usableOnTarget)
config.splashable = getBooleanFromString(config.splashable)
config.realAnimation = getBooleanFromString(config.realAnimation)

local POTIONS = {
	[8704] = {empty = 7636, splash = 2,  percent = 0.05,  health = {100, 150}}, -- small health potion
	[7618] = {empty = 7636, splash = 2,  percent = 0.07,  health = {200, 250}}, -- health potion
	[7588] = {empty = 7634, splash = 2,  percent = 0.1,   health = {250, 350}, level = 50, vocations = {3, 4, 7, 8}, vocStr = "knights and paladins"}, -- strong health potion
	[7591] = {empty = 7635, splash = 2,  percent = 0.25,  health = {50, 100}, level = 80, vocations = {4, 8}, vocStr = "knights"}, -- great health potion
	[8473] = {empty = 7635, splash = 2,  mana = {150, 200},  percent = 0.3,  health = {150, 200}, level = 130, vocations = {4, 8}, vocStr = "knights"}, -- ultimate health potion

	[7620] = {empty = 7636, splash = 7,  percent = 0.02,  mana = {110, 190}}, -- mana potion
	[7589] = {empty = 7634, splash = 7,  percent = 0.1,  mana = {10, 40}, level = 50, vocations = {1, 2, 3, 5, 6, 7}, vocStr = "sorcerers, druids and paladins"}, -- strong mana potion
	[7590] = {empty = 7635, splash = 7,  percent = 0.2,  mana = {20, 80}, level = 80, vocations = {1, 2, 5, 6}, vocStr = "sorcerers and druids"}, -- great mana potion

	[8472] = {empty = 7635, splash = 3,  percent = 0.2, health = {300, 400}, mana = {150, 190}, level = 80, vocations = {3, 4, 7, 8}, vocStr = "knights and paladins"}, -- great spirit potion
}

local exhaust = createConditionObject(CONDITION_EXHAUST)
setConditionParam(exhaust, CONDITION_PARAM_TICKS, (getConfigInfo('timeBetweenExActions') - 1000))

function onUse(cid, item, fromPosition, itemEx, toPosition)
	local potion = POTIONS[item.itemid]
	if(not potion) then
		return false
	end

	if(not isPlayer(itemEx.uid) or (not config.usableOnTarget and cid ~= itemEx.uid)) then
		if(not config.splashable) then
			return false
		end

		if(toPosition.x == CONTAINER_POSITION) then
			toPosition = getThingPos(item.uid)
		end

		doDecayItem(doCreateItem(2016, potion.splash, toPosition))
		return true
	end

	if(hasCondition(cid, CONDITION_EXHAUST_HEAL)) then
		doPlayerSendDefaultCancel(cid, RETURNVALUE_YOUAREEXHAUSTED)
		return true
	end

	if(((potion.level and getPlayerLevel(cid) < potion.level) or (potion.vocations and not isInArray(potion.vocations, getPlayerVocation(cid)))) and
		not getPlayerCustomFlagValue(cid, PLAYERCUSTOMFLAG_GAMEMASTERPRIVILEGES))
	then
		doCreatureSay(itemEx.uid, "Only " .. potion.vocStr .. (potion.level and (" of level " .. potion.level) or "") .. " or above may drink this fluid.", TALKTYPE_ORANGE_1)
		return true
	end

	local health = potion.health
	if(health and not doCreatureAddHealth(itemEx.uid, math.ceil((math.random(health[1], health[2])+(percent * getCreatureMaxHealth(cid))) * config.healthMultiplier))) then
		return false
	end

	local mana = potion.mana
	if(mana and not doPlayerAddMana(itemEx.uid, math.ceil((math.random(mana[1], mana[2])+(percent * getCreatureMaxMana(cid))) * config.manaMultiplier))) then
		return false
	end

	doSendMagicEffect(getThingPos(itemEx.uid), CONST_ME_MAGIC_BLUE)
	if(not realAnimation) then
		doCreatureSay(itemEx.uid, "Yeach Bunny...", TALKTYPE_ORANGE_1)
	else
		for i, tid in ipairs(getSpectators(getCreaturePosition(cid), 1, 1)) do
			if(isPlayer(tid)) then
				doCreatureSay(itemEx.uid, "Yeach Bunny..", TALKTYPE_ORANGE_1, false, tid)
			end
		end
	end

	doAddCondition(cid, exhaust)
	if(not potion.empty or config.removeOnUse) then
		return true
	end

	return true
end

 

[Limos]

Post the error and which server you are using.

 

[WiLDTuRTLE]

the thing you could do is delete the potions you want to heal % of full mp/hp and do a "manarune" but works as a potion,
ill check if i got the script on this computer, if not then i cant help you my other computer is broke.


---Edit----

I think its that, just read it and you'll see what to change,

local exhaust = createConditionObject(CONDITION_EXHAUST)
setConditionParam(exhaust, CONDITION_PARAM_TICKS, (getConfigInfo('timeBetweenExActions') - 1000))

function onUse(cid, item, fromPosition, itemEx, toPosition)
	local level = getPlayerLevel(cid)
	local mlevel = getPlayerMagLevel(cid)
	local mana_minimum = (level * 2.5) - 50
	local mana_maximum = (level * 2.8)
	local mana_add = math.random(mana_minimum, mana_maximum)
	

	if((not(isSorcerer(itemEx.uid) or isDruid(itemEx.uid)) or getPlayerLevel(itemEx.uid) < 1) and getPlayerCustomFlagValue(itemEx.uid, PlayerCustomFlag_GamemasterPrivileges) == FALSE) then
		doCreatureSay(itemEx.uid, "Only paladins of level 1 or above may drink this fluid.", TALKTYPE_ORANGE_1)
		return TRUE
	end

	doPlayerAddMana(cid, mana_add)
	doSendMagicEffect(getThingPos(itemEx.uid), CONST_ME_MAGIC_BLUE)
	doCreatureSay(itemEx.uid, "Aaaah...", TALKTYPE_ORANGE_1)
	return TRUE
end

action.xml

<action itemid="7590" event="script" value="new/magemana.lua" allowfaruse="1"/>

7590 is great mana pot,

 

[Amanek]

next error.. I added math.ceil before .. as here local mana_add = math.ceil(math.random(mana_minimum, mana_maximum))

what's wrong?

 

[Limos]

Post the script of the monster.

 

[Amanek]

thank you for time, I solved it. I replace doPlayerAddHealth to Creature