Lua Potions Bug

poopsiedoodle · Sep 15, 2012

I tried editing strong health, great health, and strong mana potions so that my new vocation could use them, and got this:

Here is my potions.lua.

NEVERMIND! I FIXED IT!

But now, I get this when I try to use it in game:

Dalt0n · Sep 15, 2012

LUA:

local ultimateHealthPot = 8473
local greatHealthPot = 7591
local greatManaPot = 7590
local greatSpiritPot = 8472
local strongHealthPot = 7588
local strongManaPot = 7589
local healthPot = 7618
local manaPot = 7620
local smallHealthPot = 8704
local antidotePot = 8474
local greatEmptyPot = 7635
local strongEmptyPot = 7634
local emptyPot = 7636

local antidote = createCombatObject()
setCombatParam(antidote, COMBAT_PARAM_TYPE, COMBAT_HEALING)
setCombatParam(antidote, COMBAT_PARAM_EFFECT, CONST_ME_MAGIC_BLUE)
setCombatParam(antidote, COMBAT_PARAM_TARGETCASTERORTOPMOST, TRUE)
setCombatParam(antidote, COMBAT_PARAM_AGGRESSIVE, FALSE)
setCombatParam(antidote, COMBAT_PARAM_DISPEL, CONDITION_POISON)

local exhaust = createConditionObject(CONDITION_EXHAUST_HEAL)
setConditionParam(exhaust, CONDITION_PARAM_TICKS, (getConfigInfo('timeBetweenExActions') - 100))
-- 1000 - 100 due to exact condition timing. -100 doesn't hurt us, and players don't have reminding ~50ms exhaustion.

function onUse(cid, item, fromPosition, itemEx, toPosition)
	if(itemEx.uid ~= cid or itemEx.itemid ~= 1) then
		return TRUE
	end

	if(getCreatureCondition(cid, CONDITION_EXHAUST_HEAL) == TRUE) then
		doPlayerSendDefaultCancel(cid, RETURNVALUE_YOUAREEXHAUSTED)
		return TRUE
	end

	if(item.itemid == antidotePot) then
		if(doCombat(cid, antidote, numberToVariant(cid)) == LUA_ERROR) then
			return FALSE
		end
		doAddCondition(cid, exhaust)
		doCreatureSay(cid, "Aaaah...", TALKTYPE_ORANGE_1)
		doRemoveItem(item.uid, 1)
		doPlayerAddItem(cid, emptyPot, 1)
	elseif(item.itemid == smallHealthPot) then
		if(doTargetCombatHealth(0, cid, COMBAT_HEALING, 50, 100, CONST_ME_MAGIC_BLUE) == LUA_ERROR) then
			return FALSE
		end
		doAddCondition(cid, exhaust)
		doCreatureSay(cid, "Aaaah...", TALKTYPE_ORANGE_1)
		doRemoveItem(item.uid, 1)
		doPlayerAddItem(cid, emptyPot, 1)
	elseif(item.itemid == healthPot) then
		if(doTargetCombatHealth(0, cid, COMBAT_HEALING, 100, 200, CONST_ME_MAGIC_BLUE) == LUA_ERROR) then
			return FALSE
		end
		doAddCondition(cid, exhaust)
		doCreatureSay(cid, "Aaaah...", TALKTYPE_ORANGE_1)
		doRemoveItem(item.uid, 1)
		doPlayerAddItem(cid, emptyPot, 1)
	elseif(item.itemid == manaPot) then
		if(doTargetCombatMana(0, cid, 70, 130, CONST_ME_MAGIC_BLUE) == LUA_ERROR) then
			return FALSE
		end
		doAddCondition(cid, exhaust)
		doCreatureSay(cid, "Aaaah...", TALKTYPE_ORANGE_1)
		doRemoveItem(item.uid, 1)
		doPlayerAddItem(cid, emptyPot, 1)
	elseif(item.itemid == strongHealthPot) then
		if(not(isKnight(cid) or isPaladin(cid) or isJack 'of' 'all' 'trades'(cid)) or (getPlayerLevel(cid) < 50)) and not(getPlayerGroupId(cid) >= 2) then
			doCreatureSay(cid, "This potion can only be consumed by paladins, Jacks 'of' 'all' 'trades', and knights of level 50 or higher.", TALKTYPE_ORANGE_1)
			return TRUE
		end

		if(doTargetCombatHealth(0, cid, COMBAT_HEALING, 200, 400, CONST_ME_MAGIC_BLUE) == LUA_ERROR) then
			return FALSE
		end
		doAddCondition(cid, exhaust)
		doCreatureSay(cid, "Aaaah...", TALKTYPE_ORANGE_1)
		doRemoveItem(item.uid, 1)
		doPlayerAddItem(cid, strongEmptyPot, 1)
	elseif(item.itemid == strongManaPot) then
		if(not(isSorcerer(cid) or isDruid(cid) or isPaladin(cid) or isJack 'of' 'all' 'trades'(cid)) or (getPlayerLevel(cid) < 50)) and not(getPlayerGroupId(cid) >= 2) then
			doCreatureSay(cid, "This potion can only be consumed by sorcerers, druids, Jacks 'of' 'all' 'trades' and paladins of level 50 or higher.", TALKTYPE_ORANGE_1)
			return TRUE
		end

		if(doTargetCombatMana(0, cid, 110, 190, CONST_ME_MAGIC_BLUE) == LUA_ERROR) then
			return FALSE
		end
		doAddCondition(cid, exhaust)
		doCreatureSay(cid, "Aaaah...", TALKTYPE_ORANGE_1)
		doRemoveItem(item.uid, 1)
		doPlayerAddItem(cid, strongEmptyPot, 1)
	elseif(item.itemid == greatSpiritPot) then
		if(not(isPaladin(cid)) or (getPlayerLevel(cid) < 80)) and not(getPlayerGroupId(cid) >= 2) then
			doCreatureSay(cid, "This potion can only be consumed by paladins of level 80 or higher.", TALKTYPE_ORANGE_1)
			return TRUE
		end

		if(doTargetCombatHealth(0, cid, COMBAT_HEALING, 200, 400, CONST_ME_MAGIC_BLUE) == LUA_ERROR or doTargetCombatMana(0, cid, 110, 190, CONST_ME_MAGIC_BLUE) == LUA_ERROR) then
			return FALSE
		end
		doAddCondition(cid, exhaust)
		doCreatureSay(cid, "Aaaah...", TALKTYPE_ORANGE_1)
		doRemoveItem(item.uid, 1)
		doPlayerAddItem(cid, greatEmptyPot, 1)
	elseif(item.itemid == greatHealthPot) then
		if(not(isKnight(cid) or isJack 'of' 'all' 'trades'(cid)) or (getPlayerLevel(cid) < 80)) and not(getPlayerGroupId(cid) >= 2) then
			doCreatureSay(cid, "This potion can only be consumed by knights and Jacks 'of' 'all' 'trades' of level 80 or higher.", TALKTYPE_ORANGE_1)
			return TRUE
		end

		if(doTargetCombatHealth(0, cid, COMBAT_HEALING, 500, 700, CONST_ME_MAGIC_BLUE) == LUA_ERROR) then
			return FALSE
		end
		doAddCondition(cid, exhaust)
		doCreatureSay(cid, "Aaaah...", TALKTYPE_ORANGE_1)
		doRemoveItem(item.uid, 1)
		doPlayerAddItem(cid, greatEmptyPot, 1)
	elseif(item.itemid == greatManaPot) then
		if(not(isSorcerer(cid) or isDruid(cid)) or (getPlayerLevel(cid) < 80)) and not(getPlayerGroupId(cid) >= 2) then
			doCreatureSay(cid, "This potion can only be consumed by sorcerers and druids of level 80 or higher.", TALKTYPE_ORANGE_1)
			return TRUE
		end

		if(doTargetCombatMana(0, cid, 200, 300, CONST_ME_MAGIC_BLUE) == LUA_ERROR) then
			return FALSE
		end
		doAddCondition(cid, exhaust)
		doCreatureSay(cid, "Aaaah...", TALKTYPE_ORANGE_1)
		doRemoveItem(item.uid, 1)
		doPlayerAddItem(cid, greatEmptyPot, 1)
	elseif(item.itemid == ultimateHealthPot) then
		if(not(isKnight(cid)) or (getPlayerLevel(cid) < 130)) and not(getPlayerGroupId(cid) >= 2) then
			doCreatureSay(cid, "This potion can only be consumed by knights of level 130 or higher.", TALKTYPE_ORANGE_1)
			return TRUE
		end

		if(doTargetCombatHealth(0, cid, COMBAT_HEALING, 800, 1000, CONST_ME_MAGIC_BLUE) == LUA_ERROR) then
			return FALSE
		end
		doAddCondition(cid, exhaust)
		doCreatureSay(cid, "Aaaah...", TALKTYPE_ORANGE_1)
		doRemoveItem(item.uid, 1)
		doPlayerAddItem(cid, greatEmptyPot, 1)
	end
	return TRUE
end

Try this..

poopsiedoodle · Sep 15, 2012

Nope.

By the way, I edited the vocation name to where it has no spaces.

- - - Updated - - -

Bump.

Cronox · Sep 15, 2012

what is
isJack 'of' 'all' 'trades'(cid)) or

poopsiedoodle · Sep 15, 2012

that's my new vocation.

Cykotitan · Sep 16, 2012

you can't use functions just like that without defining them somewhere in the libs.. presumably 031-vocations.lua

LUA:

function isJack(cid)
	return isInArray({9}, getPlayerVocation(cid))
end

edit the number or add several more as needed

poopsiedoodle · Sep 16, 2012

do I put this in the vocations.xml or the potions .lua?

Cykotitan · Sep 17, 2012

031-vocations.lua, not vocations.xml

it won't matter, but put them in the lib file (031~) if you want to use this function elsewhere

poopsiedoodle · Sep 17, 2012

I didn't find a vocations.lua anywhere.

Tevo · Sep 17, 2012

Lib/031-vocations.lua

poopsiedoodle · Sep 17, 2012

No lib folder.

Tevo · Sep 17, 2012

post your whole global.lua with tags...

poopsiedoodle · Sep 17, 2012

and, by tags, you mean what?

I think I just found out where to put it:

function isSorcerer(cid)
if(isPlayer(cid) == FALSE) then
debugPrint("isSorcerer: Player not found.")
return false
end

return (isInArray({1,5}, getPlayerVocation(cid)) == TRUE)
end

function isDruid(cid)
if(isPlayer(cid) == FALSE) then
debugPrint("isDruid: Player not found.")
return false
end

return (isInArray({2,6}, getPlayerVocation(cid)) == TRUE)
end

function isPaladin(cid)
if(isPlayer(cid) == FALSE) then
debugPrint("isPaladin: Player not found.")
return false
end

return (isInArray({3,7}, getPlayerVocation(cid)) == TRUE)
end

function isKnight(cid)
if(isPlayer(cid) == FALSE) then
debugPrint("isKnight: Player not found.")
return false
end

return (isInArray({4,8}, getPlayerVocation(cid)) == TRUE)
end

function isJack(cid)
if(isPlayer(cid) == FALSE) then
debugPrint("isJack: Player not found.")
return false
end

return isInArray({9}, getPlayerVocation(cid))
end

Cykotitan · Sep 18, 2012

this should be good, you may have to add == TRUE depending on your distro

poopsiedoodle · Sep 18, 2012

Uhh, I did it, and it didn't work still. Said I wasn't the right vocation, even though I was.

poopsiedoodle · Sep 19, 2012

Bump.

Cykotitan · Sep 19, 2012

i would try print(getPlayerVocation(cid)) to make sure

poopsiedoodle · Sep 19, 2012

oops, forgot the second ). gonna try it as soon as I get this connection failure figured out.

- - - Updated - - -

edited it with that, and now it can't load the global.lua.

Lua Potions Bug

poopsiedoodle

Gibe moni plos

Dalt0n

Hiho:)

poopsiedoodle

Gibe moni plos

Cronox

www.Searz-Online.com

poopsiedoodle

Gibe moni plos

Cykotitan

Experienced G'

poopsiedoodle

Gibe moni plos

Cykotitan

Experienced G'

poopsiedoodle

Gibe moni plos

Tevo

New Member

poopsiedoodle

Gibe moni plos

Tevo

New Member

poopsiedoodle

Gibe moni plos

Cykotitan

Experienced G'

poopsiedoodle

Gibe moni plos

poopsiedoodle

Gibe moni plos

Cykotitan

Experienced G'

poopsiedoodle

Gibe moni plos