C++ Problem with new coin

[_M4G0_]

I have two editeds coins in my server
bar of gold and vampire coin. one bar of gold = 1000000 and vampire = 100000000
if i deposit 50x100 bar of gold all good
Naji: Would you really like to deposit 5000000000 gold?
but if i deposit 50 vampire
Naji: Would you really like to deposit 705032704 gold?

change in source
luascript.cpp

registerEnum(ITEM_VAMPIRE_COIN)

item.cpp

uint32_t Item::getWorth() const
{
    switch (id) {
        case ITEM_GOLD_COIN:
            return count;

        case ITEM_PLATINUM_COIN:
            return count * 100;

        case ITEM_CRYSTAL_COIN:
            return count * 10000;
           
        case ITEM_BAR_OF_GOLD:
            return count * 1000000;   
           
        case ITEM_VAMPIRE_COIN:
            return count * 100000000;
           
        default:
            return 0;
    }
}

const.h

ITEM_BAR_OF_GOLD = 15515,
ITEM_VAMPIRE_COIN = 9020,

game.cpp

    uint32_t tgold = money / 100000000;
    money -= tgold * 100000000;
    while (tgold > 0) {
        const uint16_t count = std::min<uint32_t>(100, tgold);

        Item* remaindItem = Item::CreateItem(ITEM_VAMPIRE_COIN, count);

        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }

        tgold -= count;
    }
   
    uint32_t barofgold = money / 1000000;
    money -= barofgold * 1000000;
    while (barofgold > 0) {
        const uint16_t count = std::min<uint32_t>(100, barofgold);

        Item* remaindItem = Item::CreateItem(ITEM_BAR_OF_GOLD, count);

        ReturnValue ret = internalAddItem(cylinder, remaindItem, INDEX_WHEREEVER, flags);
        if (ret != RETURNVALUE_NOERROR) {
            internalAddItem(cylinder->getTile(), remaindItem, INDEX_WHEREEVER, FLAG_NOLIMIT);
        }

        barofgold -= count;
    }

player.cpp

    if (itemId != ITEM_GOLD_COIN && itemId != ITEM_PLATINUM_COIN && itemId != ITEM_CRYSTAL_COIN && itemId != ITEM_BAR_OF_GOLD && itemId != ITEM_VAMPIRE_COIN) {

 

[Michael Orsino]

Result too large for uint32_t causing some crazy shit to happen?

(I don't know much about c++ at all)

 

[K243]

Result too large for uint32_t causing some crazy shit to happen?

(I don't know much about c++ at all)

yes because he passed the max value of what a unassigned 32 bit integer can hold/handle.

The value is: 4,294,967,295

 

[_M4G0_]

Result too large for uint32_t causing some crazy shit to happen?

(I don't know much about c++ at all)

if the problem is uint32_t why bar of gold its work ?
i already changed it to uint64_t , but no effect
50 bar of gold * 100 = 5000000000
50 vampires = 5000000000

 

[K243]

1000000*50 = 50 million

 

[_M4G0_]

1000000*50 = 50 million

Yes, but work =x

 

[K243]

Yes, but work =x

? do you even read my post? Your code can only hold 4,2 billion. which is 4,2xx,xxx,xxx

50 million is, 50,xxx,xxx
Vampire:
100000000*50 = 5,000,000,000

That's apox. 800 million more than what your code hold.

 

[_M4G0_]

? do you even read my post? Your code can only hold 4,2 billion. which is 4,2xx,xxx,xxx

50 million is, 50,xxx,xxx

Yes i read your post, but i just dont understand why bar of gold work
if i deposit 50 million in item bar of gold is function.
how i can solve it ?

 

[K243]

Yes i read your post, but i just dont understand why bar of gold work
if i deposit 50 million in item bar of gold is function.
how i can solve it ?

holy shit you cant read. max value is 4,2 billion not 42 million or 4,2 million.


only way to solve it is to raise the limit to uint_64t or something dont ask me how to do it

 

[_M4G0_]

ok, thanks for help

 

[Infernum]

Integer overflow - Wikipedia
increase your integer sizes to hold uint64_t or else the number will keep overflowing
100,000,000 * 50 = 5 billion
uint32_t holds 4,294,967,295
5,000,000,000 is the amount of money needed, 4,294,967,295 is the limit
once 4,294,967,295 is surpasssed, it starts counting from 0 again
5,000,000,000 - 4,294,967,295 = 705,032,704

 

[tokenzz]

Integer overflow - Wikipedia
increase your integer sizes to hold uint64_t or else the number will keep overflowing
100,000,000 * 50 = 5 billion
uint32_t holds 4,294,967,295
5,000,000,000 is the amount of money needed, 4,294,967,295 is the limit
once 4,294,967,295 is surpasssed, it starts counting from 0 again
5,000,000,000 - 4,294,967,295 = 705,032,704

jajajajajajaja

 

[Infernum]

jajajajajajaja

hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh