Problem with one creaturescripts

[BugaS]

Hey guys!

I've got:

function onLogin(cid)

return true
end
local arena = {
     from = {x = 459, y = 15, z = 7}, -- left top corner of  arena
     to = {x = 470, y = 18, z = 7}, -- right bottom corner of  arena
     temple = { x = 472, y = 11, z = 7 } -- change it to temple pos
}
function onPrepareDeath(cid, killer)
    if isInRange(getPlayerPosition(cid), arena.from,arena.to) then
        if isPlayer(cid) then
            Player(cid):addHealth(Player(cid):getMaxHealth())
            Player(cid):addMana(Player(cid):getMaxMana())
            Player(cid):teleportTo(arena.temple, true)
            return false
        end
    end
   return true
end
function isInRange(pos, fromPos, toPos)
   return pos.x >= fromPos.x and pos.y >= fromPos.y and pos.z >= fromPos.z and pos.x <= toPos.x and pos.y <= toPos.y and pos.z <= toPos.z
end

And on death there I'm getting this error and standing without HP:

1:28:38.785] [Error - CreatureScript Interface]
[1:28:38.785] data/creaturescripts/scripts/Arena_Ups.lua:onPrepareDeath
[1:28:38.785] Description:
[1:28:38.785] data/creaturescripts/scripts/Arena_Ups.lua:15: attempt to call global 'Player' (a nil value)
[1:28:38.786] stack traceback:
[1:28:38.786]   data/creaturescripts/scripts/Arena_Ups.lua:15: in function <data/creaturescripts/scripts/Arena_Ups.lua:12>

[1:28:39.293] [Error - CreatureScript Interface]
[1:28:39.293] data/creaturescripts/scripts/Arena_Ups.lua:onPrepareDeath

Where is the problem? I think, that this is script for 1.x but i need it for 0.4

 

[Infernum]

its simple
dont use Player(cid)
turn the function names into doCreatureXXXX
example:
Player(cid):addHealth(Player(cid):getMaxHealth())
to
doCreatureAddHealth(cid, getCreatureMaxHealth(cid)

 

[BugaS]

its simple
dont use Player(cid)
turn the function names into doCreatureXXXX
example:
Player(cid):addHealth(Player(cid):getMaxHealth())
to
doCreatureAddHealth(cid, getCreatureMaxHealth(cid)

Thanks!

Is it okay?

function onLogin(cid)
return true
end
local arena = {
     from = {x = 459, y = 15, z = 7}, -- left top corner of  arena
     to = {x = 470, y = 18, z = 7}, -- right bottom corner of  arena
     temple = { x = 472, y = 11, z = 7 } -- change it to temple pos
}
function onPrepareDeath(cid, killer)
    if isInRange(getPlayerPosition(cid), arena.from,arena.to) then
        if isPlayer(cid) then
            doCreatureAddHealth(cid, getCreatureMaxHealth(cid)
            doCreatureAddMana(cid, getCreatureMaxMana(cid)
            doTeleportThing(arena.temple, true)
            return false
        end
    end
   return true
end
function isInRange(pos, fromPos, toPos)
   return pos.x >= fromPos.x and pos.y >= fromPos.y and pos.z >= fromPos.z and pos.x <= toPos.x and pos.y <= toPos.y and pos.z <= toPos.z
end

#EDIT

I'm getting:

[10:2:56.476] [Error - CreatureScript Interface]
[10:2:56.476] data/creaturescripts/scripts/Arena_Ups.lua:onPrepareDeath
[10:2:56.476] Description:
[10:2:56.476] (luaDoTeleportThing) Thing not found

@Xeraphus

 

[Elgenady]

doTeleportThing(cid,arena.temple, true)

 

[BugaS]

doTeleportThing(cid,arena.temple, true)

It's works but it's works like that, I teleported from the arena and then i this temple I die

 

[Elgenady]

u can do it from map better

 

[BugaS]

u can do it from map better

You mean PVP tiles? Nope, I need it for a quest, which player MUST DIE

 

[Elgenady]

u can make this arena only if you dead don't losse anything just tp to temple

 

[Infernum]

then remove the teleportThing function since it's useless if the player MUST DIE

 

[BugaS]

then remove the teleportThing function since it's useless if the player MUST DIE

DIE but not die like a normal He must be defeated to 0 HP and teleported but no DIE.

 

[Infernum]

DIE but not die like a normal He must be defeated to 0 HP and teleported but no DIE.

then that's not dying
either way you might have to use onDeath instead of onPrepareDeath and return false