• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!

TFS 1.X+ Promotion bug TFS 1.3

Vantoria

Vantoria

www.ClassicOT.us
Joined
Jun 6, 2014
Messages
186
Reaction score
16
Location
USA
hello recently i start working on my server based on TFS 1.3 7.72 downgraded by @Nekiro so my problem is after character reach level 8 and going to main throught the npc The Oracle after they relog they automatically become promotion i dont know if it a source bug or is my npc here is my npc script
Code: 
local keywordHandler = KeywordHandler:new()
local npcHandler = NpcHandler:new(keywordHandler)
NpcSystem.parseParameters(npcHandler)
 
local Topic, vocation, town, destination = {}, {}, {}, {}
local TOWN_ISLANDOFDESTINY = 20
local islandOfDestinyEnabled = false
 
function onCreatureAppear(cid)                npcHandler:onCreatureAppear(cid) end
function onCreatureDisappear(cid)             npcHandler:onCreatureDisappear(cid) end
function onCreatureSay(cid, type, msg)     npcHandler:onCreatureSay(cid, type, msg) end
function onThink()                         npcHandler:onThink() end
 
function greetCallback(cid)
    if(getPlayerLevel(cid) < 8) then
        npcHandler:say("CHILD! COME BACK WHEN YOU HAVE GROWN UP!", cid)
        return false
    elseif(getPlayerLevel(cid) > 9) then
        npcHandler:say(getCreatureName(cid) .. ", I CAN'T LET YOU LEAVE - YOU ARE TOO STRONG ALREADY! YOU CAN ONLY LEAVE WITH LEVEL 9 OR LOWER.", cid)
        return false
    else
        local talkUser = NPCHANDLER_CONVBEHAVIOR == CONVERSATION_DEFAULT and 0 or cid
        Topic[talkUser], vocation[talkUser], town[talkUser], destination[talkUser] = 0, 0, 0, 0
        return true
    end
end
 
function creatureSayCallback(cid, type, msg)
    local talkUser = NPCHANDLER_CONVBEHAVIOR == CONVERSATION_DEFAULT and 0 or cid
    if(not npcHandler:isFocused(cid)) then
        return false
    elseif msgcontains(msg, "yes") and Topic[talkUser] == 0 then
        npcHandler:say(islandOfDestinyEnabled and "I WILL BRING YOU TO THE ISLAND OF DESTINY AND YOU WILL BE UNABLE TO RETURN HERE! ARE YOU SURE?" or "IN WHICH TOWN DO YOU WANT TO LIVE: {CARLIN}, {AB'DENDRIEL}, {KAZORDOON}" .. (isPremium(cid) == TRUE and ", {THAIS}, {VENORE}, {DARASHIA}, {ANKRAHMUN}, OR {EDRON}?" or " OR {THAIS}?"), cid)
        Topic[talkUser] = islandOfDestinyEnabled and 4 or 1
    elseif Topic[talkUser] == 0 then
        npcHandler:unGreet(cid)
    elseif msgcontains(msg, "carlin") and Topic[talkUser] == 1 then
        npcHandler:say("IN CARLIN! AND WHAT PROFESSION HAVE YOU CHOSEN: {KNIGHT}, {PALADIN}, {SORCERER}, OR {DRUID}?", cid)
        Topic[talkUser] = 2
        town[talkUser] = 5
        destination[talkUser] = {x=32360, y=31782, z=7}
    elseif msgcontains(msg, "ab'dendriel") and Topic[talkUser] == 1 then
        npcHandler:say("IN AB'DENDRIEL! AND WHAT PROFESSION HAVE YOU CHOSEN: {KNIGHT}, {PALADIN}, {SORCERER}, OR {DRUID}?", cid)
        Topic[talkUser] = 2
        town[talkUser] = 1
        destination[talkUser] = {x=32732, y=31634, z=7}
    elseif msgcontains(msg, "kazordoon") and Topic[talkUser] == 1 then
        npcHandler:say("IN KAZORDOON! AND WHAT PROFESSION HAVE YOU CHOSEN: {KNIGHT}, {PALADIN}, {SORCERER}, OR {DRUID}?", cid)
        Topic[talkUser] = 2
        town[talkUser] = 2
        destination[talkUser] = {x=32649, y=31925, z=11}
    elseif msgcontains(msg, "thais") and Topic[talkUser] == 1 then
        npcHandler:say("IN THAIS! AND WHAT PROFESSION HAVE YOU CHOSEN: {KNIGHT}, {PALADIN}, {SORCERER}, OR {DRUID}?", cid)
        Topic[talkUser] = 2
        town[talkUser] = 3
        destination[talkUser] = {x=32369, y=32241, z=7}
    elseif msgcontains(msg, "venore") and Topic[talkUser] == 1 then
        npcHandler:say("IN VENORE! AND WHAT PROFESSION HAVE YOU CHOSEN: {KNIGHT}, {PALADIN}, {SORCERER}, OR {DRUID}?", cid)
        Topic[talkUser] = 2
        town[talkUser] = 4
        destination[talkUser] = {x=32957, y=32076, z=7}
    elseif msgcontains(msg, "darashia") and Topic[talkUser] == 1 then
        if isPremium(cid) == TRUE then
            npcHandler:say("IN DARASHIA! AND WHAT PROFESSION HAVE YOU CHOSEN: {KNIGHT}, {PALADIN}, {SORCERER}, OR {DRUID}?", cid)
            Topic[talkUser] = 2
            town[talkUser] = 7
            destination[talkUser] = {x=33213, y=32454, z=1}
        else
            npcHandler:say("YOU NEED A PREMIUM ACCOUNT IN ORDER TO GO THERE!", cid)
            Topic[talkUser] = 1
        end
    elseif msgcontains(msg, "ankrahmun") and Topic[talkUser] == 1 then
        if isPremium(cid) == TRUE then
            npcHandler:say("IN ANKRAHMUN! AND WHAT PROFESSION HAVE YOU CHOSEN: {KNIGHT}, {PALADIN}, {SORCERER}, OR {DRUID}?", cid)
            Topic[talkUser] = 2
            town[talkUser] = 6
            destination[talkUser] = {x=33194, y=32853, z=8}
        else
            npcHandler:say("YOU NEED A PREMIUM ACCOUNT IN ORDER TO GO THERE!", cid)
            Topic[talkUser] = 1
        end
    elseif msgcontains(msg, "edron") and Topic[talkUser] == 1 then
        if isPremium(cid) == TRUE then
            npcHandler:say("IN EDRON! AND WHAT PROFESSION HAVE YOU CHOSEN: {KNIGHT}, {PALADIN}, {SORCERER}, OR {DRUID}?", cid)
            Topic[talkUser] = 2
            town[talkUser] = 8
            destination[talkUser] = {x=33217, y=31814, z=8}
        else
            npcHandler:say("YOU NEED A PREMIUM ACCOUNT IN ORDER TO GO THERE!", cid)
            Topic[talkUser] = 1
        end
    elseif Topic[talkUser] == 1 then
        npcHandler:say("{CARLIN}, {AB'DENDRIEL}, {KAZORDOON}" .. (isPremium(cid) == TRUE and ", {THAIS}, {VENORE}, {DARASHIA}, {ANKRAHMUN}, {EDRON}?" or " OR {THAIS}?"), cid)
        Topic[talkUser] = 1
    elseif msgcontains(msg, "sorcerer") and Topic[talkUser] == 2 then
        npcHandler:say("A SORCERER! ARE YOU SURE? THIS DECISION IS IRREVERSIBLE!", cid)
        Topic[talkUser] = 3
        vocation[talkUser] = 1
    elseif msgcontains(msg, "druid") and Topic[talkUser] == 2 then
        npcHandler:say("A DRUID! ARE YOU SURE? THIS DECISION IS IRREVERSIBLE!", cid)
        Topic[talkUser] = 3
        vocation[talkUser] = 2
    elseif msgcontains(msg, "paladin") and Topic[talkUser] == 2 then
        npcHandler:say("A PALADIN! ARE YOU SURE? THIS DECISION IS IRREVERSIBLE!", cid)
        Topic[talkUser] = 3
        vocation[talkUser] = 3
    elseif msgcontains(msg, "knight") and Topic[talkUser] == 2 then
        npcHandler:say("A KNIGHT! ARE YOU SURE? THIS DECISION IS IRREVERSIBLE!", cid)
        Topic[talkUser] = 3
        vocation[talkUser] = 4
    elseif Topic[talkUser] == 2 then
        npcHandler:say("{KNIGHT}, {PALADIN}, {SORCERER}, OR {DRUID}?", cid)
        Topic[talkUser] = 2
    elseif msgcontains(msg, "yes") and Topic[talkUser] == 3 then
        npcHandler:say("SO BE IT!", cid)
        Topic[talkUser] = 0
        doPlayerSetVocation(cid, vocation[talkUser])
        doPlayerSetTown(cid, town[talkUser])
        npcHandler:releaseFocus(cid)
        doSendMagicEffect(getCreaturePosition(cid), CONST_ME_TELEPORT)
        doTeleportThing(cid, destination[talkUser])
        doPlayerAddItem(cid, 1988, 1) -- Backpack
        doPlayerAddItem(cid, 2480) -- legion helmet
        doPlayerAddItem(cid, 2484) -- studded armor
        doPlayerAddItem(cid, 2530) -- cooper shield
        doPlayerAddItem(cid, 2649) -- leather legs
        doPlayerAddItem(cid, 2643) -- leather boots
        doPlayerAddItem(cid, 2120, 1) -- rope
        doPlayerAddItem(cid, 2554, 1) -- shovel
        doPlayerAddItem(cid, 2789, 5) -- brown mushroom
        doPlayerAddItem(cid, 2160, 1) -- Crystal coin
        doSendMagicEffect(destination[talkUser], CONST_ME_TELEPORT)
    elseif Topic[talkUser] == 3 then
        npcHandler:unGreet(cid)
    elseif Topic[talkUser] == 4 then
        if msgcontains(msg, "yes") then
            npcHandler:say("SO BE IT!", cid)
            Topic[talkUser] = 0
            doPlayerSetTown(cid, TOWN_ISLANDOFDESTINY)
            npcHandler:releaseFocus(cid)
            doSendMagicEffect(getCreaturePosition(cid), CONST_ME_TELEPORT)
            doTeleportThing(cid, {x=32091,y=32027,z=7})
            doSendMagicEffect({x=32091,y=32027,z=7}, CONST_ME_TELEPORT)
            doPlayerSendTextMessage(cid, MESSAGE_EVENT_ADVANCE, "Welcome to the Island of Destiny. Walk north to find trainers who will help you find a suitable vocation.")
            doPlayerSendTextMessage(cid, MESSAGE_EVENT_ADVANCE, "The surface of this island is a protection zone. You can't attack or regain health here. If you need healing, talk to Yandur.")
            doAddMapMark(cid, {x=32091,y=32027,z=7}, MAPMARK_EXCLAMATION, "Island of Destiny - Training Centre")
            doAddMapMark(cid, {x=32091,y=32027,z=7}, MAPMARK_GREENNORTH, "Ship to Mainland")
        else
            npcHandler:unGreet(cid)
        end
    end
    return TRUE
end
 
npcHandler:setMessage(MESSAGE_GREET, "|PLAYERNAME|, ARE YOU PREPARED TO FACE YOUR DESTINY?")
npcHandler:setMessage(MESSAGE_WALKAWAY, "COME BACK WHEN YOU ARE PREPARED TO FACE YOUR DESTINY!")
npcHandler:setMessage(MESSAGE_FAREWELL, "COME BACK WHEN YOU ARE PREPARED TO FACE YOUR DESTINY!")
 
npcHandler:setCallback(CALLBACK_GREET, greetCallback)
npcHandler:setCallback(CALLBACK_MESSAGE_DEFAULT, creatureSayCallback)
npcHandler:addModule(FocusModule:new())
 
Solution
Leo32
Vantoria said:
i search in all files and the promotion storage is on Global.lua in this engine nekiro/forgottenserver (https://github.com/nekiro/forgottenserver/tree/7.72-downgrade) there are no more 30018 in all the datapack
Click to expand...

Irrelevant.
You need to find if 30018 is being used in your DATAPACK files, not the engine files.
Or your ACC Maker, if you use an old achievements script:
github.com

ZnoteAAC/config.php at 6fd5aa5409234601043d71e48116103c00ed4742 · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC
github.com github.com

Leo32 said:
Then use a test char.
  1. What is test chars ID.
  2. Go through rook and use oracle to set vocation.
  3. Logout and login, are they automatically promoted?
Then look for their ID in player_storage and see if they have 30018 set for...
Click to expand...
Sort by date Sort by votes
Have you accidentally re-used this storage ID for a quest or something?

github.com

forgottenserver/data/lib/core/storages.lua at 676f57392037c3221651e04aa4d06f32c338cb78 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver
github.com github.com

github.com

forgottenserver/data/npc/lib/npcsystem/modules.lua at b6dd28fa2c287ece3dc2e3765b973e0dd725c613 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver
github.com github.com

github.com

forgottenserver/data/creaturescripts/scripts/login.lua at 437419d38ee9d24b19d779fc72c56ecd12d342b2 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver
github.com github.com
 
Last edited:
Upvote 0 Downvote
Upvote 0 Downvote
Upvote 0 Downvote
Vantoria said:
to normal accounts too

i did seach in db and i see they have the storage since they already have promotion i think
Click to expand...

Then use a test char.
  1. What is test chars ID.
  2. Go through rook and use oracle to set vocation.
  3. Logout and login, are they automatically promoted?
Then look for their ID in player_storage and see if they have 30018 set for no reason.
Use your legs mate.

Either a different login script or that storage is causing it.
Using a notepad++ search (as per the above post) and looking for promotion or setStorageValue should allow to you find it.
 
Last edited:
Upvote 0 Downvote
Leo32 said:
Then use a test char.
  1. What is test chars ID.
  2. Go through rook and use oracle to set vocation.
  3. Logout and login, are they automatically promoted?
Then look for their ID in player_storage and see if they have 30018 set for no reason.
Use your legs mate.

Tbh - Either a login script or that storage is causing it.
Using a notepad++ search (as per the above post) and looking for promotion should allow to you find it.
Click to expand...
i search in all files and the promotion storage is on Global.lua in this engine nekiro/forgottenserver (https://github.com/nekiro/forgottenserver/tree/7.72-downgrade) there are no more 30018 in all the datapack
 
Upvote 0 Downvote
Last edited:
Upvote 0 Downvote
Vantoria said:
i search in all files and the promotion storage is on Global.lua in this engine nekiro/forgottenserver (https://github.com/nekiro/forgottenserver/tree/7.72-downgrade) there are no more 30018 in all the datapack
Click to expand...

Irrelevant.
You need to find if 30018 is being used in your DATAPACK files, not the engine files.
Or your ACC Maker, if you use an old achievements script:
github.com

ZnoteAAC/config.php at 6fd5aa5409234601043d71e48116103c00ed4742 · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC
github.com github.com

Leo32 said:
Then use a test char.
  1. What is test chars ID.
  2. Go through rook and use oracle to set vocation.
  3. Logout and login, are they automatically promoted?
Then look for their ID in player_storage and see if they have 30018 set for no reason.
Use your legs mate.
Click to expand...

Or add print(player:getStorageValue(30018)) to your login.lua script.
Confirm the issue before trying to fix anything.


👇
 
Last edited:
Upvote 0 Downvote
Solution
Leo32 said:
Irrelevant.
You need to find if 30018 is being used in your DATAPACK files, not the engine files.
Or your ACC Maker, example:
github.com

ZnoteAAC/config.php at 6fd5aa5409234601043d71e48116103c00ed4742 · Znote/ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server. - Znote/ZnoteAAC
github.com github.com



Or add print(player:getStorageValue(30018)) to your login.lua script.
Confirm the issue before trying to fix anything.
Click to expand...
well as i said before im using this engine nekiro/forgottenserver (https://github.com/nekiro/forgottenserver/tree/7.72-downgrade) everything looks good in files, right now i fixed it disabling free premium on config.lua so atm i will let it like that but thank you guys for the help
 
Upvote 0 Downvote
Recently noticed a similar behaviour in my datapack.

New character gets vocation in Oracle (knight for example) -> look myself and displays as knigth -> logout (no 30018 storage in database yet) -> login (while premium) -> look myself and display as elite knight (storage 30018 is added once database saves)

Added print(player:getStorageValue(30018)) to login.lua and it prints everytime I login.

Searching for 30018 brings no results except for the achievement in config.php in Znote ACC and in storages.lua promotion = 30018,

I'm running out of ideas here so if anyone can send some light please. It may be the most stupid thing but I just can't figure it out.
 
Last edited:
Upvote 0 Downvote
Evil Puncker said:
change 30018 to a very different value and see if this still happens
Click to expand...

They get the new promotion storage instead.

I found something new. Only characters with no vocation are getting the promotion storage on login. So basically any new character starting at level 1/no vocation are getting the promotion storage upon first login and consecuent logins (they will still be no vocation) and upon getting their vocation at level +8 the oracle sets them as their basic (non promoted) vocation. Once they relog, as they had the promotion storage, they get promoted aslong as they are premium.

I've been able to reproduce even using default /data folder. If someone can try it and see if they can reproduce aswell that'd be great - this thing is driving me insane already :)
 
Last edited:
Upvote 0 Downvote
hmm
Lua: 
-- Promotion
    local vocation = player:getVocation()
    local promotion = vocation:getPromotion()
    if player:isPremium() then
        local value = player:getStorageValue(PlayerStorageKeys.promotion)
        if not promotion and value ~= 1 then -- maybe this is wrong logically speaking
            player:setStorageValue(PlayerStorageKeys.promotion, 1)
        elseif value == 1 then
            player:setVocation(promotion)
        end
    elseif not promotion then
        player:setVocation(vocation:getDemotion())
    end
 
Upvote 0 Downvote

Similar threads

E
  • Question
TFS 0.X 8.60 0.4 NPC Promotion with VIP coin price ID: 11192 Amount: 100 script no function
Replies
2
Views
145
Mateus Robeerto
Mateus Robeerto
Mateus Robeerto
  • Question
npc who exchange item for another item that gives storage only once exchange TFS 1.5 NEKIRO
Replies
8
Views
603
Idletibia
I
bolachapanco
  • Question
NPC Addoner - Canary Source
Replies
0
Views
434
bolachapanco
bolachapanco
E
  • Question
TFS 0.X 0.4 Recovery Exp only recovers levels from level 1 to 100, it does not recover levels from level 717217, I want it to recover levels 1 until 717217
Replies
1
Views
144
Enderlop
E
J
  • Question
Npc Problem Help Please
Replies
2
Views
317
Mateus Robeerto
Mateus Robeerto
J
  • Solved
Grizzly Adams tfs1.5 problem
Replies
10
Views
650
jareczekjsp
J
Mateus Robeerto
  • Question
TFS 1.X+ I want to learn basic TFS 1X functions
Replies
13
Views
787
Mateus Robeerto
Mateus Robeerto
Back
Top