Solved remove default combat effects

[whitevo]

I find it quite annoying that every time I want to some certain type of damage it always comes with the default magic effect.

Where in source I can remove them so that if I use this function, there wont be any fire effect on target.
doTargetCombatHealth(cid, targetID, FIRE, min, max, effect, origin)

Also the other thing what is bugging me is that, if effect is nil. it also crashes the client.
doTargetCombatHealth(cid, targetID, type, min, max, NIL, origin)

It would be awesome If function looks like this doTargetCombatHealth(cid, targetID, type, damage, origin)
But it would be good enough if all types would loose their DEFAULT effect

 

[Mkalo]

I find it quite annoying that every time I want to some certain type of damage it always comes with the default magic effect.

Where in source I can remove them so that if I use this function, there wont be any fire effect on target.
doTargetCombatHealth(cid, targetID, FIRE, min, max, effect, origin)

Also the other thing what is bugging me is that, if effect is nil. it also crashes the client.
doTargetCombatHealth(cid, targetID, type, min, max, NIL, origin)

It would be awesome If function looks like this doTargetCombatHealth(cid, targetID, type, damage, origin)
But it would be good enough if all types would loose their DEFAULT effect

Did you try CONST_ME_NONE?

 

[whitevo]

Did you try CONST_ME_NONE?

The type fire will still make the fire effect.

 

[Mkalo]

The type fire will still make the fire effect.

True, I'm pretty sure this is a bug (if you use something like effect ice it will show 2 effects.). I'll try to fix it and edit this post.

 

[Jano]

it should be game.cpp -> combatChangeHealth in older TFS
or game.cpp -> combatGetTypeInfo in newer TFS

 

[Nenth]

@whitevo It's simple to do, you need to add empty effect in tibia.dat, then you need register it in sources, for example:
const.h

CONST_ME_CONFETTI_HORIZONTAL = 75,
CONST_ME_CONFETTI_VERTICAL = 76,
CONST_ME_EMPTY = 77,   --- this is empty effect

Then you need to change default effect for your damage type, for example:
game.cpp

case COMBAT_EARTHDAMAGE: {
            color = TEXTCOLOR_LIGHTGREEN;
            effect = CONST_ME_EMPTY;   --- here you set default effect
            break;
        }

That's all.
Tested on TFS 1.0! For 99,99%, it will work also on other versions
Cheers.

 

[whitevo]

you need to add empty effect in tibia.dat

no idea how do to that, but would this work?

case COMBAT_EARTHDAMAGE: {
            color = TEXTCOLOR_LIGHTGREEN;
            effect = CONST_ME_NONE;
            break;
        }

 

[Nenth]

no idea how do to that, but would this work?

case COMBAT_EARTHDAMAGE: {
            color = TEXTCOLOR_LIGHTGREEN;
            effect = CONST_ME_NONE;
            break;
        }

No, I don't know why at all, but I had same problem at 0.3 version.

I checked TFS 1.2 sources.
If you can see, in your const.h, there are already empty effects, so you don't have to add new one in tibia.dat:

// 77-157 are empty

So just do like I said, register effect number 77:

CONST_ME_EMPTY = 77,

and set default effect like this:

case COMBAT_EARTHDAMAGE: {
            color = TEXTCOLOR_LIGHTGREEN;
            effect = CONST_ME_EMPTY;
            break;
        }

My english isn't good, but I hope you understood!

 

[Mkalo]

no idea how do to that, but would this work?

case COMBAT_EARTHDAMAGE: {
            color = TEXTCOLOR_LIGHTGREEN;
            effect = CONST_ME_NONE;
            break;
        }

Thats a hacky solution, creating new combats just to have a combat with no effect is stupid.
The function is bugged, it should force the magic effect not add another above it. So i'm fixing it and sending a pull request, plus I'm adding a new effect "CONST_ME_DEFAULT", that will use the default effect from the combat and not force anything (Kinda what const_me_none is doing now).

 

[whitevo]

@whitevo It's simple to do, you need to add empty effect in tibia.dat, then you need register it in sources, for example:
const.h

CONST_ME_CONFETTI_HORIZONTAL = 75,
CONST_ME_CONFETTI_VERTICAL = 76,
CONST_ME_EMPTY = 77,   --- this is empty effect

Then you need to change default effect for your damage type, for example:
game.cpp

case COMBAT_EARTHDAMAGE: {
            color = TEXTCOLOR_LIGHTGREEN;
            effect = CONST_ME_EMPTY;   --- here you set default effect
            break;
        }

That's all.
Tested on TFS 1.0! For 99,99%, it will work also on other versions
Cheers.

Cheers.