( REMOVE ) Move through other players!

[Hashirama479]

As the title says how can I remove so players cant move through other players? I know its in source but I dont know the code which I need xD im using tfs 0.4 rev3777

bool Player::canWalkthrough(const Creature* creature) const
{
    if(creature == this || hasCustomFlag(PlayerCustomFlag_CanWalkthrough) || creature->isWalkable() ||
        (creature->getMaster() && creature->getMaster() != this && canWalkthrough(creature->getMaster())))
        return true;

    const Player* player = creature->getPlayer();
    if(!player)
        return false;

    if((((g_game.getWorldType() == WORLDTYPE_OPTIONAL && !player->isEnemy(this, true) &&
        player->getVocation()->isAttackable()) || player->getTile()->hasFlag(TILESTATE_PROTECTIONZONE) || (player->getVocation()->isAttackable() &&
        player->getLevel() < (uint32_t)g_config.getNumber(ConfigManager::PROTECTION_LEVEL))) && player->getTile()->ground &&
        Item::items[player->getTile()->ground->getID()].walkStack) && (!player->hasCustomFlag(PlayerCustomFlag_GamemasterPrivileges)
        || player->getAccess() <= getAccess()))
        return true;

    return (player->isGhost() && getGhostAccess() < player->getGhostAccess())
        || (isGhost() && getGhostAccess() > player->getGhostAccess());
}

 

[gunz]

bool Player::canWalkthrough(const Creature* creature) const
{
    if(creature == this || hasCustomFlag(PlayerCustomFlag_CanWalkthrough) || creature->isWalkable() ||
       (creature->getMaster() && creature->getMaster() != this && canWalkthrough(creature->getMaster())))
        return true;

    const Player* player = creature->getPlayer();
    if(!player)
        return false;
   else
        return true;

}

 

[Hashirama479]

Do I need to edit this part?

bool Player::canWalkthrough(const Creature* creature) const
{
    if(creature == this || hasCustomFlag(PlayerCustomFlag_CanWalkthrough) || creature->isWalkable() ||
        (creature->getMaster() && creature->getMaster() != this && canWalkthrough(creature->getMaster())))
        return true;

    const Player* player = creature->getPlayer();
    if(!player)
        return false;

 

[Hashirama479]

Bump xd

 

[Joe Rod]

Do I need to edit this part?

bool Player::canWalkthrough(const Creature* creature) const
{
    if(creature == this || hasCustomFlag(PlayerCustomFlag_CanWalkthrough) || creature->isWalkable() ||
        (creature->getMaster() && creature->getMaster() != this && canWalkthrough(creature->getMaster())))
        return true;

    const Player* player = creature->getPlayer();
    if(!player)
        return false;

you have to replace that function... find and replace

 

[Hashirama479]

you have to replace that function... find and replace

my quest was if I need to replace this part

bool Player::canWalkthrough(const Creature* creature) const
{
    if(!creature)
        return true;

    if(creature == this)
        return false;

    const Player* player = creature->getPlayer();
    if(!player)
        return false;

    if(g_game.getWorldType() == WORLD_TYPE_NO_PVP && player->getTile()->ground
        && player->getTile()->ground->getID() != ITEM_GLOWING_SWITCH)
        return true;

    return player->isGhost() && getGhostAccess() < player->getGhostAccess();
}

with this part

bool Player::canWalkthrough(const Creature* creature) const
{
    if(creature == this || hasCustomFlag(PlayerCustomFlag_CanWalkthrough) || creature->isWalkable() ||
       (creature->getMaster() && creature->getMaster() != this && canWalkthrough(creature->getMaster())))
        return true;

    const Player* player = creature->getPlayer();
    if(!player)
        return false;
   else
        return true;

}

 

[Infernum]

my quest was if I need to replace this part

bool Player::canWalkthrough(const Creature* creature) const
{
    if(!creature)
        return true;

    if(creature == this)
        return false;

    const Player* player = creature->getPlayer();
    if(!player)
        return false;

    if(g_game.getWorldType() == WORLD_TYPE_NO_PVP && player->getTile()->ground
        && player->getTile()->ground->getID() != ITEM_GLOWING_SWITCH)
        return true;

    return player->isGhost() && getGhostAccess() < player->getGhostAccess();
}

with this part

yes

 

[Hashirama479]

I did replace but I can still move through other players

 

[Infernum]

I did replace but I can still move through other players

did you recompile

 

[Hashirama479]

yes ofc lul xD

 

[Colandus]

my quest was if I need to replace this part

bool Player::canWalkthrough(const Creature* creature) const
{
    if(!creature)
        return true;

    if(creature == this)
        return false;

    const Player* player = creature->getPlayer();
    if(!player)
        return false;

    if(g_game.getWorldType() == WORLD_TYPE_NO_PVP && player->getTile()->ground
        && player->getTile()->ground->getID() != ITEM_GLOWING_SWITCH)
        return true;

    return player->isGhost() && getGhostAccess() < player->getGhostAccess();
}

with this part

Looks like he just took an old canWalkthrough code which will give you undesired results. For one you won't be able to walk through ghost players. Aside from that it's actually allowing you to pass through players (returning true if creature is player??).

Try this:

bool Player::canWalkthrough(const Creature* creature) const
{
    if(hasCustomFlag(PlayerCustomFlag_CanWalkthrough))
        return true;

    if(!creature)
        return true;

    if(creature == this)
        return false;

    const Player* player = creature->getPlayer();
    if(!player)
        return false;

    return player->isGhost() && getGhostAccess() < player->getGhostAccess();
}

 

[Hashirama479]

Looks like he just took an old canWalkthrough code which will give you undesired results. For one you will be able to walk through ghost players. Aside from that it's actually allowing you to pass through players (returning true if creature is player??).

Try this:

bool Player::canWalkthrough(const Creature* creature) const
{
    if(!creature)
        return true;

    if(creature == this)
        return false;

    const Player* player = creature->getPlayer();
    if(!player)
        return false;

    return player->isGhost() && getGhostAccess() < player->getGhostAccess();
}

Although I still think it might not work flawlessly. Which was the original canWalkthrough from your sources?

It did work thanks!

 

[Colandus]

It did work thanks!

I don't think it will work if a GM is ghost and tries to walk through a player. Can you try that and tell me if it works? So I can fix it if it doesn't.

 

[Hashirama479]

I don't think it will work if a GM is ghost and tries to walk through a player. Can you try that and tell me if it works? So I can fix it if it doesn't.

Nope does not work, is it possible if the god char can move through players and monsters? Doesnt matter if in ghost or not?

 

[Colandus]

Ok I updated post, try it. It expects your char to have flag PlayerCustomFlag_CanWalkthrough

 

[Hashirama479]

its working, thanks mate ! <3333