Request some modifications tfs 1.2

[president vankk]

Hi folks!

I tryed so fucking hard to make the modifications below, but I did not make it
So.. I want make some modifications on Bounty Hunter for TFS 1.2,

• You can't hunt yourself - I mean, you can't pay to hunt yourself.
• You can't hunt the administrador or someone with access.
• When I try use !hunt 1000000,Meu Deus - It keep saying that players does not exist, but it does, seems have some problems with names with space.

Can someone please make theses mofications ? Thanks.

 

[Limos]

local target = Player(t[2]:trim())
if target then
     sp_id = target:getGuid()
else
     player:sendTextMessage(MESSAGE_STATUS_CONSOLE_BLUE, "[BOUNTY HUNTERS] A player with this name does not exist. Remember to write like this: !hunt prize,name.")
     return false
end
  
if target == player then
     player:sendTextMessage(MESSAGE_STATUS_CONSOLE_BLUE, "You can't hunt yourself.")
     return false
end
if target:getGroup():getAccess() then
     player:sendTextMessage(MESSAGE_STATUS_CONSOLE_BLUE, "You can't hunt someone with acces.")
     return false
end

 

[president vankk]

@Limos
Tryed use !hunt 1000000,Meu Deus and !hunt 1000000, Meu Deus and keeping telling 10:19 [BOUNTY HUNTERS] A player with this name does not exist. Remember to write like this: !hunt prize,name.

 

[Limos]

Maybe you use a different string.split function, it works fine for me like this.

string.split = function(str, sep)
   local res = {}
   for v in str:gmatch("([^" .. sep .. "]+)") do
     res[#res + 1] = v
   end
   return res
end

 

[president vankk]

What?

 

[Limos]

I've just tested it with the latest TFS datapack/distribution and also there it works fine for me.
Possible difference could be the string.split function, the trim function, the Player function or if the player isn't online or the name is spelled wrong.

 

[president vankk]

Possible difference could be the string.split function, the trim function, the Player function or if the player isn't online or the name is spelled wrong.

Exactly, how I can fix it?

 

[Limos]

You can check/test which one it could be, is the player online? Is the name spelled correctly? You can test it with the latest distro/datapack.

 

[president vankk]

When the player is online then it spell correctly, maybe add a check if the player is online or not? Don't think that could be a solution for us.

Unfortunately I can not test with the latest revision.

 

[Limos]

If it should also be possible when the player is offline then you can use a query, like this.
https://github.com/otland/forgottenserver/blob/master/data/lib/compat/compat.lua#L340-#L345