OTClient rule violation no work; tfs 1.5 otv8

[bpm91]

Hey guys, I'm using otv8 and I would like to know if anyone knows how to make this thing work. it does not ban or notify. If anyone has had this problem and knows how to solve it, I would appreciate the help.
i use tfs 1.5

 

[bpm91]

I'm looking through several old posts, and it seems to me that no one has ever solved this problem. Is this so complicated that it doesn't work on any server?
this tool would help a lot

 

[Felipe93]

ward

 

[Manigold]

Add deprecated rule violations · rookgaard/optimized_forgottenserver@5640e43

-Add deprecated rule violation system for pre-8.7 protocols -Chat code optimization + auto-detection chaneel ids for hardcoded channels

github.com

 

[Felipe93]

Add deprecated rule violations · rookgaard/optimized_forgottenserver@5640e43

-Add deprecated rule violation system for pre-8.7 protocols -Chat code optimization + auto-detection chaneel ids for hardcoded channels

github.com

how do i enable this in compiler? GAME_FEATURE_RULEVIOLATION where should i set it

 

[bpm91]

Add deprecated rule violations · rookgaard/optimized_forgottenserver@5640e43

-Add deprecated rule violation system for pre-8.7 protocols -Chat code optimization + auto-detection chaneel ids for hardcoded channels

github.com

in tfs 1.5 no have features.h what i do?

 

[Manigold]

in tfs 1.5 no have features.h what i do?

Remove all:
#if GAME_FEATURE_RULEVIOLATION > 0
#endif

 

[bpm91]

Remove all:
#if GAME_FEATURE_RULEVIOLATION > 0
#endif

I tried to adapt several times as I said, but I couldn't, does anyone know how to adapt to nekiro 1.5?

 

[bpm91]

how to adapt in files that do not exist for example? nekiro does not have some files in this tutorial and some functions too

 

[bpm91]

did some good soul get this to work in tfs 1.5? I tried to adapt but some files do not exist in 1.5 until today trying to solve this :/

 

[bpm91]

could anyone help? trying to understand why when banning a player with rule violations, the server crashes, but it doesn't say why. but when banning the player offline the server does not crash. otv8 i use
game.cpp

    uint32_t targetAccId;
            if (targetPlayer) {
                targetAccId = targetPlayer->getAccount();
            } else {
                targetAccId = IOBan::getAccountID(target);
            }
          
            if (targetAccId == 0) {
                player->sendCancelMessage("A player with this name does not exist.");
                return;
            }
            if (IOBan::isAccountBanned(targetAccId, banInfo)) {
                player->sendCancelMessage(target + " is already banned.");
                if (targetPlayer) {
                    targetPlayer->kickPlayer(true);
                }
                return;
            }
            if (targetAccId > 0) {
                db.executeQuery(fmt::format("INSERT INTO `account_bans` (`account_id`, `reason`, `banned_at`, `expires_at`, `banned_by`) VALUES ({:d}, {:s}, {:d}, {:d}, {:d})", targetAccId, db.escapeString(reasonStr), timeNow, (timeNow + timeBan), player->getGUID()));
            }
            player->sendTextMessage(MESSAGE_EVENT_ADVANCE, target + " has been banned.");
            if (targetPlayer) {
                targetPlayer->kickPlayer(true);
            }

Post automatically merged: Aug 5, 2023

this also holds for name_locks

if (action == 1) {
            uint32_t targetPlayerGuid;
            if (targetPlayer) {
                targetPlayerGuid = targetPlayer->getPlayer()->getID();
            } else {
                targetPlayerGuid = IOBan::getPlayerID(target);
            }
            if (targetPlayerGuid > 0) {
                db.executeQuery(fmt::format("INSERT INTO `player_namelocks` (`player_id`, `reason`, `namelocked_at, `namelocked_by`) VALUES ({:d}, {:s}, {:d}, {:d})", targetPlayerGuid, db.escapeString(reasonStr), timeNow, player->getGUID()));
            }
            player->sendTextMessage(MESSAGE_EVENT_ADVANCE, target + " has been namelocked.");
            if (targetPlayer) {
                targetPlayer->kickPlayer(true);
            }
            return;
        }
        else

Post automatically merged: Aug 5, 2023

to name report show this on tfs. i think same problem to banishment.

 

[lursky]

Typo in query, use:

INSERT INTO `player_namelocks` (`player_id`, `reason`, `namelocked_at`, `namelocked_by`) VALUES ({:d}, {:s}, {:d}, {:d})

 

[Error 502]

for while you could modify game_ruleviolation of otc xd

function report()
    local reasonLabel = reasonsTextList:getFocusedChild()
    if not reasonLabel then
        displayErrorBox(tr('Error'), tr('You must select a reason.'))
        return
    end
    local actionLabel = actionsTextList:getFocusedChild()
    if not actionLabel then
        displayErrorBox(tr('Error'), tr('You must select an action.'))
        return
    end
    local target = ruleViolationWindow:getChildById('nameText'):getText()
    local reason = reasonLabel.reasonId
    local action = actionLabel.actionId
    local comment = ruleViolationWindow:getChildById('commentText'):getText()
    local statement = ruleViolationWindow:getChildById('statementText'):getText()
    local statementId = 0 -- TODO: message unique id ?
    local ipBanishment = ruleViolationWindow:getChildById('ipBanCheckBox'):isChecked()
    if action == 6 and statement == '' then
        displayErrorBox(tr('Error'), tr('No statement has been selected.'))
    elseif comment == '' then
        displayErrorBox(tr('Error'), tr('You must enter a comment.'))
    else
        g_game.reportRuleViolation(target, reason, action, comment, statement, statementId, ipBanishment)
 
        g_game.talkChannel(1, 0, "!notate".. target ..", " .. comment)
        hide()
    end
end

g_game.talkChannel(1, 0, "!notate".. target ..", " .. comment)

Lua - notation + ban tfs 1.5 talkaction

hello guys, does anyone have a talkaction script where the person receives the notification from the gm, and if he is notified twice more, he is banned?

otland.net