Linux Segmentation fault

[thomson9292]

What is a segmentation fault?

OTS (1.3 tfs) crash with this communicate in console (ubuntu 16.04 LEMP):
segmentation fault

I guess it's something wrong with memory. How to fix this?

 

[Infernum]

are you using the official tfs or using an edited version of yours?
there's not anything wrong with the memory itself, segfaults are caused by the program attempting to read/write to an illegal memory location
if you changed something provide the code

 

[thomson9292]

I use this one:
data: https://github.com/WibbenZ/server/archive/tfsUpdates.zip
tfs: GitHub - otland/forgottenserver: A free and open-source MMORPG server emulator written in C++

I only changed code in znote acc but not in any ots file.

 

[Milice]

Run it with a debugger, then you can make out what's crashing it i ur lucky.
Instead of doing ./tfs , do gdb ./tfs and then when its loaded tell it to "run"

 

[thomson9292]

Thanks for your answer Milice.
This is what I got.

 

[Infernum]

are you using the absolute latest version?
there was a summon bug that could have affected Monster::death and caused a crash
redownload the latest version which has the fix

 

[thomson9292]

I changed files as you said but problem still exists.

It happens often when I kills groups of monsters. I'm not sure which one could be bugged (maybe summoned slimes?)

Ok I think problem appears when I kill many summoned monsters (didn't noticed any porblem with not summoned monsters). When I kill one summon everything works right.
Do you have any idea how to fix this?

 

[Infernum]

i forgot you're using linux, i was talking about downloading the latest release from appveyor
you'll have to look at the pr and do the source edits yourself to fix the issue
Fix #2190 by Mkalo · Pull Request #2191 · otland/forgottenserver · GitHub

 

[Mkalo]

Can you pull the latest commit from the repository and try again @thomson9292. It should have been fixed.

Thanks.

 

[thomson9292]

It didn't help. I think problem appears when I kill master and summons in the same time but I'm not sure. I will test it in the moment.

I add my changed parts of code to make no doubt about this.

When I kill 2 summons and master nothing happens. When I kill 4 summons and master it crashes the server.

I tried to kill even 10 summons in the same time but without killing the master. It didnt cause the problem. Crash appears when I kill 2+ summons with master in the same time.

 

[Mkalo]

It didn't help. I think problem appears when I kill master and summons in the same time but I'm not sure. I will test it in the moment.

I add my changed parts of code to make no doubt about this.

When I kill 2 summons and master nothing happens. When I kill 4 summons and master it crashes the server.

I tried to kill even 10 summons in the same time but without killing the master. It didnt cause the problem. Crash appears when I kill 2+ summons with master in the same time.

Are you sure that you compiled it again properly? It doesn't happen to me at all anymore.
You have to do rm -rf build and run cmake + make again.

I can try to help you through Team Viewer if you still keep getting the crash. You can just send me id and password through PM.

 

[thomson9292]

I was sure that I compiled it again but I was wrong. It's working now without any problem. Thank you so much for help.

 

[Marcus]

Are you sure that you compiled it again properly? It doesn't happen to me at all anymore.
You have to do rm -rf build and run cmake + make again.

I can try to help you through Team Viewer if you still keep getting the crash. You can just send me id and password through PM.

you don't have to delete build, just write:

make clean
make

and it will re-compile everything