TFS 1.X+ sendCreatureHealth issue with clients 11+

[guiismiti]

Hello!

Clients of version 11+ have an issue with ProtocolGame::sendCreatureHealth (TFS 1.3).

1. it causes the name and health bar of killed monsters to still show after the last hit and before the corpse is created;
2. name and health bar of gods using 'hide' (with setHiddenHealth) can still be seen by players;
3. monsters with hidden health (e. g. magicthrowers) can still be seen by players.

void ProtocolGame::sendCreatureHealth(const Creature* creature)
{
    NetworkMessage msg;
    msg.addByte(0x8C);
    msg.add<uint32_t>(creature->getID());

    if (creature->isHealthHidden()) {
        msg.addByte(0x00);
    } else {
        msg.addByte(std::ceil((static_cast<double>(creature->getHealth()) / std::max<int32_t>(creature->getMaxHealth(), 1)) * 100));
    }
    writeToOutputBuffer(msg);
}

WRONG behavior (clients 11+) - monster is killed with the last hit, but name and health bar are still showing, until the corpse is created:


RIGHT behavior (client 10) - name and health bar stop showing with the last hit, before the monster is removed and the corpse created:


God using 'hide' (with setHiddenHealth) in clients 11+:


Magicthrower in clients 11+:


Has anybody managed to solve this?
Or, has anybody got an idea on how to solve this?

Extra info:
Monsters don't hit the ground immediately when killed because the function that checks for killed monsters is called with a think interval, and not directly after the last hit - (game.cpp) Game::checkCreatures

 

[Leo32]

I stumbled across this a few weeks ago too.
It seems the 0x8c packet has changed, but we haven't aligned it on the TFS end.

monsters with hidehealth is not hidding health · Issue #86 · opentibiabr/otservbr-global-datapack

hidehealth tag is not workingn properly, it is showing creature's hp bar in black to all players (usually only gms+ can see that) It is supposed to hide both the creature hp bar and name, but i...

github.com

fixing hidden creature health by jlcvp · Pull Request #1053 · opentibiabr/otservbr-global

fixes #962

github.com

The solve requires using this to figure out how 0x8c has changed (or does hiding the health now use a different/new packet?):

Tibia 11-12+ Packet Sniffer (RL & OT)

Hail otland! Today i'm releasing this tool where he can track every byte and your structures to files. What i can do with this tool? A: You can use it to get the new bytes of cipsoft/otservers protocol from new client (version 11+) Requirements VC++ 2017 Redistributable Injector .dll Battleye...

otland.net

 

[guiismiti]

It seems the 0x8c packet has changed, but we haven't aligned it on the TFS end.

Yea, I've also posted this earlier today in the conversation in github, to avoid the issue being closed before it is effectively fixed.

 

[fabian766]

The solve requires using this to figure out how 0x8c has changed (or does hiding the health now use a different/new packet?):

On 11+ clients cipsoft changed it so that it need to be handle inside ProtocolGame::AddCreature and to update creature one might want to use packet: {0x03, "protobuf.protocol.GameserverMessageCreatureData"}
Also sending health packet with 0 percent actually make 11+ clients buggy(for example when you move your character clients lags a lot).

Example that it works:

 

[leuofiridia]

Hi guys, Leu here, (jlcvp@github)

The client 10 automatically hides the health bar if a value 0 is sent. clients 11/12 don't.

On cipsoft`s side, they didn't need to handle this kind of logic because they changed how creatures die at all. They remove the creature and creates the body as long as the creature health reaches 0

On the TFS when we kill a creature, first we send health 0 and in the next tick we send the remove creature/body logic. this needs to be changed.


In the last flash client (protocol 11.43) we have this method to handle packet with header 0x8c
As you will see in the image bellow, it had the same structure we have in protocolgame.cpp

(<uint32> creature id)
(<uint8> percent health)