Shield Equipped?

[WarOfTheTitans]

How to check if the player has a shield equipped? I've searched everything and I haven't found anything.

This was what I come up with, but if the player has a empty slot, errors occurs:

function getPlayerShieldEquipped(cid)
	local slotRight = getPlayerSlotItem(cid, CONST_SLOT_RIGHT).uid
	local slotLeft = getPlayerSlotItem(cid, CONST_SLOT_LEFT).uid
	
	if(getItemWeaponType(slotRight) == WEAPON_SHIELD or getItemWeaponType(slotLeft) == WEAPON_SHIELD) then
		return true
	end

end

Thank and rep+

 

[rox666]

shields equipid is in movements? i didnt understand what actually u want :/

 

[WarOfTheTitans]

how to check if the player has a shield equipped, then continue the function...

 

[sn3ejk]

function getPlayerShieldEquipped(cid)
	local slotRight = getPlayerSlotItem(cid, CONST_SLOT_RIGHT).uid
	local slotLeft = getPlayerSlotItem(cid, CONST_SLOT_LEFT).uid
 
	if ((slotRight and getItemWeaponType(slotRight) == WEAPON_SHIELD) or (slotLeft and getItemWeaponType(slotLeft) == WEAPON_SHIELD)) then
		return true
	end
	return false
end

 

[WarOfTheTitans]

still not working. That function is exactly as mine... -.-

I still get this error when I don't have any shield or the hand slot is empty:

[19/05/2012 22:26:02] [Error - Spell Interface] 
[19/05/2012 22:26:02] data/spells/scripts/donspells/shield bash.lua:onCastSpell
[19/05/2012 22:26:02] Description: 
[19/05/2012 22:26:02] (luaGetThing) Thing not found

 

[sn3ejk]

Try it

function isHeldShield(cid)
	local items = {getPlayerSlotItem(cid, CONST_SLOT_RIGHT), getPlayerSlotItem(cid, CONST_SLOT_LEFT)}
	
	if ((items[0] and getItemWeaponType(items[0].uid) == WEAPON_SHIELD) or (items[1] and getItemWeaponType(items[1].uid) == WEAPON_SHIELD)) then
		return true
	end
	return false
end

 

[WarOfTheTitans]

still the same error

 

[sn3ejk]

[19/05/2012 22:26:02] (luaGetThing) Thing not found

This error is to function getThing().

 

[WarOfTheTitans]

It means that there is no item in that slot...

	//getPlayerSlotItem(cid, slot)
	uint32_t slot = popNumber(L);

	ScriptEnviroment* env = getEnv();
	if(const Player* player = env->getPlayerByUID(popNumber(L)))
	{
		if(Thing* thing = player->__[COLOR="#FF0000"]getThing(slot)[/COLOR])
			pushThing(L, thing, env->addThing(thing));
		else
			pushThing(L, NULL, 0);
	}
	else
	{
		errorEx(getError(LUA_ERROR_PLAYER_NOT_FOUND));
		pushThing(L, NULL, 0);
	}
	return 1;

 

[WarOfTheTitans]

[CPP]bool Player::hasShield() const
{
bool result = false;
Item* item = getInventoryItem(SLOT_LEFT);
if(item && item->getWeaponType() == WEAPON_SHIELD)
result = true;

item = getInventoryItem(SLOT_RIGHT);
if(item && item->getWeaponType() == WEAPON_SHIELD)
result = true;

return result;
}[/CPP]

This looks like your function ;o

 

[Cykotitan]

this was solved, but just for reference: xuH1TPGA

 

[WarOfTheTitans]

Thanks alot cykotitan!