TFS 1.X+ Should we always check the checksum of every packet?

[gudan garam]

So, I've been working on understand the network and connection part of TFS and have come across some divergencies regarding checksum checking.

So, on TFS official repository, the Connection::parsePacket method checks the checksum for every packet if it thinks there is a checksum to be checked.

Now, I know this is mainly TFS related but for the sake of learning, I'd like to show other cases.

For example, on OTX they won't check it, they just skip it and also, only if it is the first packet received.

Now, I've seen other repos where they would only check the checksum if it is the first packet aswell, like OTX (but they would actually check it).

So, my question is. Is it because they are on different protocol versions (tfs on 10.98 otx idk and others idk aswell). Or is it something we can actually not check and that would be beneficial in someway? Do we only check it so that we can skip it if there was no checksum?

 

[pasiak12]

usually checksum confirms that packet has not been malformed during transmission

 

[gudan garam]

usually checksum confirms that packet has not been malformed during transmission

Yes, and I get that. But in this case, unless i'm missing something, we literally ignore it if it is not a valid checksum.

And that's why I asked if we check it just to know if we have to skip thoose bytes or not.

 

[Lessaire]

As long as TFS is using the state-of-the-art Adler implementation, it's literally irrelevant as far as CPU impact.