C++ Show ammunition attack value on look

[ralke]

Hi guys! I use TFS 1.5 downgrades 8.6 and I wonder how can I make to show the attack of every ammunition (bolts, arrows, etc). I was looking here

Ammunition attack

Hey guys, I'm wondering if it is possible to show ammunition attack when someone is looking at it, I tried showattributes with no effect, of course it will be cool if it can be done without source edit, but if its only way it will be ok

otland.net

But couldn't find the similitude with my sources here
Greed-TFS-1.5-Downgrades/src/item.cpp at 8.60 · ralke23/Greed-TFS-1.5-Downgrades (https://github.com/ralke23/Greed-TFS-1.5-Downgrades/blob/8.60/src/item.cpp#L942)

Which part I must change to achieve what I need, and exactly which code must be the replacement?
Thanks in advance, regards!

 

[Mateus Robeerto]

I'm not sure it will work, but I'm interested in adding this functionality to my own codebase. I hope to find someone capable of making these modifications.
I haven't tried it yet as I'm at work. As soon as I get home I will test it to see if it works properly.

} else if (it.weaponType != WEAPON_NONE) {
    bool begin = true;
    if (it.weaponType == WEAPON_DISTANCE) {
        int32_t attack, defense;
        int8_t hitChance;
        if (item) {
            attack = item->getAttack();
            defense = item->getDefense();
            hitChance = item->getHitChance();
        } else {
            attack = it.attack;
            defense = it.defense;
            hitChance = it.hitChance;
        }

        if (it.ammoType != AMMO_NONE) {
            s << " (Range:" << static_cast<uint16_t>(item ? item->getShootRange() : it.shootRange);

            if (attack != 0) {
                s << ", Atk" << std::showpos << attack << std::noshowpos;
            }

            if (hitChance != 0) {
                s << ", Hit%" << std::showpos << static_cast<int16_t>(hitChance) << std::noshowpos;
            }

            // Display ammo attack and defense
            if (item) {
                int32_t ammoAttack = item->getAmmoAttack();
                int32_t ammoDefense = item->getAmmoDefense();
                s << ", Ammo Atk:" << std::showpos << ammoAttack << std::noshowpos;
                s << ", Ammo Def:" << std::showpos << ammoDefense << std::noshowpos;
            }
        } else {
            s << " (Atk:" << attack << ", Def:" << defense;
        }

        begin = false;
    }

 

[ralke]

// Display ammo attack and defense if (item) { int32_t ammoAttack = item->getAmmoAttack(); int32_t ammoDefense = item->getAmmoDefense(); s << ", Ammo Atk:" << std::showpos << ammoAttack << std::noshowpos; s << ", Ammo Def:" << std::showpos << ammoDefense << std::noshowpos; }

Tried but didn't work, the ammunition remain with the same description. I wonder if this can be achieved on .lua too since is 1.5 downgrades. Would be very nice is hitChance can be added to description too!

Regards

 

[Michael Orsino]

I haven't tried, but in the onLook event you can probably add something like:

local attack = thing:getAttribute(ITEM_ATTRIBUTE_ATTACK)
if attack > 0 then
  description = string.format("%s, Attack: %d", description, attack)
end

If that works, the same approach should work for other attributes like ITEM_ATTRIBUTE_HITCHANCE

You might need to check if the item isAmmo() before doing this to avoid unintended consequences though!

 

[Roddet]

Its the same in both cases

Lua

TFS-1.5-Downgrades/data/lib/core/item.lua at 8.60 · nekiro/TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - nekiro/TFS-1.5-Downgrades

github.com

C++

TFS-1.5-Downgrades/src/item.cpp at 8.60 · nekiro/TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - nekiro/TFS-1.5-Downgrades

github.com

Just replace that statement with a simple else and obviously dont add any other attribute than attack nor maxHitChance on ammunition
Otherwise the attributes will be displayed but wont work anyway

 

[ralke]

I haven't tried, but in the onLook event you can probably add something like:

local attack = thing:getAttribute(ITEM_ATTRIBUTE_ATTACK)
if attack > 0 then
  description = string.format("%s, Attack: %d", description, attack)
end

If that works, the same approach should work for other attributes like ITEM_ATTRIBUTE_HITCHANCE

You might need to check if the item isAmmo() before doing this to avoid unintended consequences though!

Thanks a lot!! I'll try, @Roddet answer seems more direct so i'm giving a try to it first

Its the same in both cases

Lua

TFS-1.5-Downgrades/data/lib/core/item.lua at 8.60 · nekiro/TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - nekiro/TFS-1.5-Downgrades

github.com

C++

TFS-1.5-Downgrades/src/item.cpp at 8.60 · nekiro/TFS-1.5-Downgrades

Alternative forgottenserver versions for older protocols support - nekiro/TFS-1.5-Downgrades

github.com

Just replace that statement with a simple else and obviously dont add any other attribute than attack nor maxHitChance on ammunition
Otherwise the attributes will be displayed but wont work anyway

I still can't get it how it is supposed to be written, sorry for not catching it, I literally replaced

} else if (it.weaponType != WEAPON_AMMO) {

for an else, but it didn't worked. Tested on .lua lib/core/item.lua

Haven't tried on C++ yet, is the same right? Replace

        } else if (it.weaponType != WEAPON_AMMO) {

for a simple else?

Regards and thanks a lot for the help!

Post automatically merged: Jun 17, 2023

Edit// Worked well! Replaced

} else if (it.weaponType != WEAPON_AMMO) {

for } else {, thanks @Roddet

Post automatically merged: Jun 17, 2023

The only thing that doesn't work is getHitChance, if i'm not wrong, to show the ammunition hitchance you must create a new method for getMaxHitChance instead of getHitChance, since HitChance is related to bows, xbows, and stuff that increases the base HitChance. Thanks a lot and regards!

 

[ralke]

Added Max Hit% to ammunition description, thanks a lot to @Roddet for scripting the code!



Commited here:

Show ammunition attack and max hit% on look · ralke23/Greed-TFS-1.5-Downgrades@4705ce7

Thanks Roddet! https://otland.net/threads/show-ammunition-attack-value-on-look.285216/#post-2726005 Co-Authored-By: roddett <[email protected]>

github.com

Regards!