[Simple] dotradeitem(cid,olditem,count,newitem,amount)

[Andrespro]

Explanation:

-- doTradeItem(cid,olditem,count,newitem,amount)

dotradeitem is used to trade items.

- olditem = Item to be traded
- count = 'olditem' count

- newitem = Item to be given
- amouont = 'newitem' count

-- Examples:
		doTradeItem(cid,2160,50,2472,1)
		-- Change '50' of '2160' for '1' of '2472'
		-- It's useful when you want to trade items with NPC

Well, go to data/lib/ folder and search for function.lua, go to the first line and add:

  function doTradeItem(cid, olditem, count, newitem, amount)
        if getPlayerItemCount(cid, olditem) >= count then
                doPlayerRemoveItem(cid, olditem, count)
                return (doPlayerAddItem(cid, newitem, amount) and TRUE or FALSE
        end
end

Very simple, very useful

 

[Shawak]

Yeah nice one, but you cant't use:

if dotradeitem(..) == TRUE then

Try this one, not tested:

function doTradeItem(cid, olditem, count, newitem, amount)
	if getPlayerItemCount(cid, olditem) >= count then
		doPlayerRemoveItem(cid, olditem, count)
		return doPlayerAddItem(cid, newitem, amount)
	else
		return FALSE
	end
end

Regards,
Shawak

 

[chojrak]

Shawak's one looks neater.

 

[Shawak]

Shawak's one looks neater.

Thanks?

@Script:
Update (shorter):

function doTradeItem(cid, olditem, count, newitem, amount)
        if getPlayerItemCount(cid, olditem) >= count then
                doPlayerRemoveItem(cid, olditem, count)
                return (doPlayerAddItem(cid, newitem, amount) and TRUE or FALSE
        end
end

 

[Andrespro]

Well, Thread Updated (Using Shawak's Update)

Sorry, Never used (if do... == TRUE then)

 

[JDB]

Nice function though.
:thumbup:

 

[Sync]

Very nice

 

[Jano]

function doTradeItem(cid, olditem, count, newitem, amount)
    return (doPlayerRemoveItem(cid, olditem, count) == true) and doPlayerAddItem(cid, newitem, amount) or false
end

??

 

[Shawak]

function doTradeItem(cid, olditem, count, newitem, amount)
    return (doPlayerRemoveItem(cid, olditem, count) == true) and doPlayerAddItem(cid, newitem, amount) or false
end

??

        if getPlayerItemCount(cid, olditem) >= count then

??

 

[chojrak]

@Shawak:

(doPlayerRemoveItem(cid, olditem, count) == true)

It will also check count

 

[Shawak]

My miss, forgott about return of this function .

 

[Andrespro]

Already used test script..

function onUse(cid, item, fromPosition, itemEx, toPosition)
		if doTradeItem(cid, 2472,1,2160,100) == true then
		doSendAnimatedText(fromPosition, "$$$", TEXTCOLOR_YELLOW)
		end
end

Results:

With Shawak's one:

It works fine, and function:

		doSendAnimatedText(fromPosition, "$$$", TEXTCOLOR_YELLOW)

Works when doTradeItem(cid,X,X,X,X) == true

But, using Nahruto's one:

It works, but when you put function:

		doSendAnimatedText(fromPosition, "$$$", TEXTCOLOR_YELLOW)

After:

if doTradeItem(cid, 2472,1,2160,100) == true then

It trade the items but, code:

		doSendAnimatedText(fromPosition, "$$$", TEXTCOLOR_YELLOW)

DOESN'T WORK

So, I recommend to use Shawak's one

 

[Rizz]

    return (doPlayerRemoveItem(cid, olditem, count) == true) and doPlayerAddItem(cid, newitem, amount) and true or false

?!?!

 

[Shawak]

    return (doPlayerRemoveItem(cid, olditem, count) == true) and doPlayerAddItem(cid, newitem, amount) and true or false

?!?!

I think this is right, too .

 

[Jano]

return (doPlayerRemoveItem(cid, olditem, count) == true) and doPlayerAddItem(cid, newitem, amount) or false


if im not wrong

doPlayerAddItem(cid, newitem, amount)

should return true

try

print(pcall(doPlayerAddItem, cid, newitem, amount))


EDITTTTT !!!

use rizz one with the "and true" part <- i think doPlayerAddItem(cid, newitem, amount) dont return anything ;< by itself

but you could do

return (doPlayerRemoveItem(cid, olditem, count) == true) and pcall(doPlayerAddItem, cid, newitem, amount) or false

 

[chojrak]

return (doPlayerRemoveItem(cid, olditem, count) == true) and doPlayerAddItem(cid, newitem, amount) or false


if im not wrong

doPlayerAddItem(cid, newitem, amount)

should return true

try

print(pcall(doPlayerAddItem, cid, newitem, amount))


EDITTTTT !!!

use rizz one with the "and true" part <- i think doPlayerAddItem(cid, newitem, amount) dont return anything ;< by itself

but you could do

return (doPlayerRemoveItem(cid, olditem, count) == true) and pcall(doPlayerAddItem, cid, newitem, amount) or false

I think doPlayerAddItem() returns item's uid.

 

[Jano]

using pcall it should return true >=(


yep it does

try

print(pcall(doPlayerAddItem, cid, 2170, 1))

and you will see

 

[chojrak]

Haven't access to any server atm. will try later ;p