Lua Spell'

[marcos16]

You can magic give critical?
Example:
Attacking a spell with a magic sword that has 50% chance to critical. When the magic goes on the hit player multiply also multiplies the sword attack ... Is it possible? [Varying the critical chance of the value of each item]

 

[marcos16]

up

 

[Shyzoul]

first of all what you mean with critical? it's a custom mod that you have?

 

[marcos16]

No. Every server has. It is a multiplied attack, you choose the percentage that the item will have the critical hit.
But what I am using is a code added.
After adding the code in the source just put it in item.xml in attack item that you want

<attribute key="criticalhitchance" value="5"/>

If I want with the magic item to also multiply the damage

 

[Zothion]

you could have a custom spell function that all spells call with the variables needed to execute combat, so you call it in every spell instead of just doCombat(...) and in there you check for crit chance and change dmg

or you can change the onCombat/onhealthchange function w/e ur code is using to change crit dmg and allow it for spells also

your script probably has COMBAT_MELEE or something in the combat script, if you add COMBAT_SPELL it will work

 

[Shyzoul]

@marcos16 i think can't be done just bacause scripts can't seen the final result of the damage, there is a issue open about this.
https://github.com/otland/forgottenserver/issues/1762

 

[Zothion]

you can, but it depends on how the critical chance is done, if dmg is added in source no, but some scripts add it via onHealthChange or onCombat or w/e its called, and then ez to add to spells

 

[Infernum]

Couldn't you just script the weapon and add a math.random chance to execute critical damage, and if not chance >= x execute regular damage?