• There is NO official Otland's Discord server and NO official Otland's server list. The Otland's Staff does not manage any Discord server or server list. Moderators or administrator of any Discord server or server lists have NO connection to the Otland's Staff. Do not get scammed!
  • 2026 staff recruitment is open! Check it out and consider applying!

Complaint / [Suggestion] 0.3.7 Subversion Logs

J.Dre

J.Dre

Unity Games
Joined
May 18, 2011
Messages
2,643
Solutions
3
Reaction score
639
Location
United States
Hey TFS, I appreciate all of your hard work...please stop saying "Whoops", "shit work", "learn how to code", "are you dumb?" when you're editing the subversion. I know we can see changed files, but letting us know what you changed might be more helpful.

J.Dre said:
I honestly appreciate everything you guys do for us but it's kind of annoying when you have no idea what has been changed, except the knowledge of what file has been edited. It only helps me (and probably others) to determine whether or not they need to update...

Edit:
You have to consider that people who know little to nothing about the code have no idea what is going on. Those types of comments leave questions:

  • What does that mean? (regarding the comment)
  • What has changed?
  • Is it important, should I update?
The reason of this thread is to not cause problems, I am simply trying to recommend that the logs be more informative.
Click to expand...

A tiny description isn't too much to ask, don't be lazy guys! If anything, just prevent this from happening in the future.
 
Last edited:
Upvote 0 Downvote
I did write whoops in the last one but where's the other "messages" from?

Edit: Cool story bro!
 
It's not a story, look back in the past revisions. You obviously don't have to listen to me, I am just complaining / suggesting at the same time. I honestly appreciate everything you guys do for us but it's kind of annoying when you have no idea what has been changed, except the knowledge of what file has been edited. It only helps me (and probably others) to determine whether or not they need to update...

Edit: I believe Elf said some of the other examples I mentioned, but collectively there are quite a few...maybe not as much lately but they exist.
You have to consider that people who know little to nothing about the code have no idea what is going on. Those types of comments leave questions:

  • What does that mean? (regarding the comment)
  • What has changed?
  • Is it important, should I update?
The reason of this thread is to not cause problems, I am simply trying to recommend that the logs be more informative.
 
Last edited:
I'm not trying to be mean, but sometimes when I'm looking to see where something specifically changed, and I see the changelog say "nvm" or "learn to code" or something like J.Dre said, I have to manually see what was changed (takes like 40x longer), and it's especially annoying when there's like 3-4 of these messages in a row >.>

Red
 
Agreed It's one of the main reasons I stopped donating, its a messy area when you update your server and have no idea what's been changed.
 
I approve. This also includes public humiliation among developers. For an example if a coder did something wrong, another coder finds the error, fix it. And write a negative comment to the old coder. The comments are public and for everybody to see. Instead of nagging to each other, they should talk private to each other, and try to teach each other. Encourage each other.

I am not saying this is happening all the time. But it does happen sometimes.

And new revs should be commented with what has been changed or added. If it is a fix, if its just some restructuring, proper commenting. (on the script). Its nice to let us know the development.
 
Znote said:
I approve. This also includes public humiliation among developers. For an example if a coder did something wrong, another coder finds the error, fix it. And write a negative comment to the old coder. The comments are public and for everybody to see. Instead of nagging to each other, they should talk private to each other, and try to teach each other. Encourage each other.

I am not saying this is happening all the time. But it does happen sometimes.

And new revs should be commented with what has been changed or added. If it is a fix, if its just some restructuring, proper commenting. (on the script). Its nice to let us know the development.
Click to expand...

*cough* elf ripping on fallen quite often *cough*
 
Little suggestion to Dalkon especially:
When you want to make 20 commits this day, wait and commit it in the evening... just once. It is even easier when only you (and it usually happens) are editing code at this time.
 
jtv27Kbj6O.png
 
Dalkon is a good programmer. If people do not know what he changed, read the source code if you do not know, you'll learn c + +. Nobody has to explain anything about what they are doing or changing, explaining programming donkeys through logs, it is a waste of time.
 
Kiel said:
Dalkon is a good programmer. If people do not know what he changed, read the source code if you do not know, you'll learn c + +. Nobody has to explain anything about what they are doing or changing, explaining programming donkeys through logs, it is a waste of time.
Click to expand...

Do they have to explain anything? Nope, just a tiny and normal comment about the changes.
 
it actually doesn't bother me, I always remember the last revision I got(well, I save it on a notepad on my desktop :P), and when there's a new version(s), I just check the differences with the previous one and change them manually to the source code I have :)
 
Scarlet Ayleid said:
it actually doesn't bother me, I always remember the last revision I got(well, I save it on a notepad on my desktop :P), and when there's a new version(s), I just check the differences with the previous one and change them manually to the source code I have :)
Click to expand...

Same here, also the comparing option in site thing is very good and shows everything :p
 
Don Daniello said:
Little suggestion to Dalkon especially:
When you want to make 20 commits this day, wait and commit it in the evening... just once. It is even easier when only you (and it usually happens) are editing code at this time.
Click to expand...

No. Each commit should be atomic and only contain one specific change. You fix a bug, you commit. You add a feature, you commit. You don't fix a bug and add a feature and then commit.
 
NAAPV said:
No. Each commit should be atomic and only contain one specific change. You fix a bug, you commit. You add a feature, you commit. You don't fix a bug and add a feature and then commit.
Click to expand...

I disagree. Your idea of recording changes is more time consuming. If Dalkon fixes 10 bugs in one sitting, you're suggesting that he commit ten times. It's very simple, use the logs correctly - simply tell us what has changed or what has been fixed, there's no need to complicate things.
 
Last edited:
J.Dre said:
I disagree. Your idea of recording changes is more time consuming. If Dalkon fixes 10 bugs in one sitting, you're suggesting that he commit ten times. It's very simple, use the logs correctly - simply tell us what has changed or what has been fixed, there's no need to complicate things.
Click to expand...
You don't seem to understand the point of version control system.
 
J.Dre said:
I disagree. Your idea of recording changes is more time consuming.
Click to expand...
I never claimed otherwise.

The idea with atomic commits is not to "be fast" but to be accurate. By having all changes isolated in their own commits, it's also easier to interact with these changes: for example, if a commit breaks something, reverting it is as easy as entering a single svn command with the right revision number.
 
Oh, okay. I seem to have misinterpreted the outcome of your suggestion above. What you are saying makes clear sense now.

:thumbup:
 
Last edited:
Back
Top