Talkaction -.-

[Ninja Bodil]

What's wrong with this script?

function onSay(cid, words, param)
 
	if(param == "Dear God") then
		if(getPlayerStorageValue(20101, 1) == false) then 
	             if(getPlayerPosition(cid) == {x = 1000, y = 993, z = 6}) then
			doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "An angel told you about a message from God. Talk to Father Damien about the message")
			doPlayerSetStorageValue(20101, 1)
			else
			doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "Maybe the isn't the right place to pray?")
		     end
		else
		doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "Angels only show up once")
	        end
		return true
	end
end

 

[Colandus]

if(getPlayerStorageValue(20101, 1) == false) then

should be

if(getPlayerStorageValue(cid, 20101) ~= 1) then


and you cant do like this:
getPlayerPosition(cid) == {x = 1000, y = 993, z = 6}

you have to do comparePos(getPlayerPosition(cid), pOS_HERE)
it returns true/false

if udont have it then:

function comparePos(pos1, pos2)
    return pos1.x==pos2.x and pos1.y==pos2.y and pos1.z==pos2.z
end

and isnt it setPlayerStorageValue, not doPlayerSetStorageValue ??

 

[Ninja Bodil]

Still don't work

function comparePos(pos1, pos2)
    return pos1.x==pos2.x and pos1.y==pos2.y and pos1.z==pos2.z
end

function onSay(cid, words, param)
 
	if(param == "Dear God") then
		if(getPlayerStorageValue(cid, 20101) ~= 1) then 
	         if comparePos(getPlayerPosition(cid), {x = 1000, y = 993, z = 6}) then
			doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "An angel told you about a message from God. Talk to Father Damien about the message")
			setPlayerStorageValue(20101, 1)
			else
			doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "Maybe the isn't the right place to pray?")
		     end
		else
		doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "Angels only show up once")
	        end
		return true
	end
end

Haven't been scripting in 6 months so are abit off atm

 

[Ninja Bodil]

A fast bump because I need this :/

 

[Teckman]

Post an error or something. And I'm wondering whether I get you or not. Is this script supposed to do an action if you say dear god? If so then.

function onSay(cid, words, param)
	if(words == "dear god") then
		if(getPlayerStorageValue(cid, 20101) < 1) then
			if(getPlayerPosition(cid) == {x = 1000, y = 993, z = 6, stackpos = 253}) then
				doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "An angel told you about a message from God. Talk to Father Damien about the message")
				setPlayerStorageValue(cid, 20101, 1)
			else
				doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "Maybe the isn't the right place to pray?")
			end
		else
			doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "Angels only show up once")
		end
	end
	return true
end

<talkaction words="dear god" filter="word-spaced" hide="no" event="script" value="prayer.lua"/>

and isnt it setPlayerStorageValue, not doPlayerSetStorageValue ??

It can be used in either way. And you can compare getPlayerPosition(cid) with a pos. No need of comparePos().

 

[Ninja Bodil]

Error:

[11/09/2010 22:15:07] [Error - TalkAction Interface] 
[11/09/2010 22:15:07] data/talkactions/scripts/prayer.lua:onSay
[11/09/2010 22:15:07] Description: 
[11/09/2010 22:15:07] data/talkactions/scripts/prayer.lua:3: attempt to compare boolean with number
[11/09/2010 22:15:07] stack traceback:
[11/09/2010 22:15:07] 	data/talkactions/scripts/prayer.lua:3: in function <data/talkactions/scripts/prayer.lua:1>

 

[Teckman]

Error:

[11/09/2010 22:15:07] [Error - TalkAction Interface] 
[11/09/2010 22:15:07] data/talkactions/scripts/prayer.lua:onSay
[11/09/2010 22:15:07] Description: 
[11/09/2010 22:15:07] data/talkactions/scripts/prayer.lua:3: attempt to compare boolean with number
[11/09/2010 22:15:07] stack traceback:
[11/09/2010 22:15:07] 	data/talkactions/scripts/prayer.lua:3: in function <data/talkactions/scripts/prayer.lua:1>

forgot this:

change this:

		if(getPlayerStorageValue(20101) < 1) then

to this:

		if(getPlayerStorageValue(cid, 20101) < 1) then

and this:

				setPlayerStorageValue(cid, 20101)

to this:

				setPlayerStorageValue(cid, 20101, 1)

 

[Ninja Bodil]

Yeah I realised that also (I'm abit off as i said )
But nothing happens when I stand at the right position it you says "Maybe the isn't the right place to pray?".

 

[Teckman]

Yeah I realised that also (I'm abit off as i said )
But nothing happens when I stand at the right position it you says "Maybe the isn't the right place to pray?".

			if(getPlayerPosition(cid) == {x = 1000, y = 993, z = 6}) then

change to:

			if(getPlayerPosition(cid) == {x = 1000, y = 993, z = 6, stackpos = 253}) then

 

[Ninja Bodil]

Still the same :'(

 

[Teckman]

So it means that you're not in a right place, have you double-checked?

 

[Kekox]

dude, didnt you read the post of colandus?
You cant do this:

if(getPlayerPosition(cid) == {x = 1000, y = 993, z = 6, stackpos = 253}) then

You need to use:

comparePos(getPlayerPosition(cid), pos_here)

Here, use it:

function comparePos(pos1, pos2)
    return pos1.x==pos2.x and pos1.y==pos2.y and pos1.z==pos2.z
end
function onSay(cid, words, param)
	if(words == "dear god") then
		if(getPlayerStorageValue(cid, 20101) < 1) then
			if(comparePos(getPlayerPosition(cid), {x = 1000, y = 993, z = 6})) then
				doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "An angel told you about a message from God. Talk to Father Damien about the message")
				setPlayerStorageValue(cid, 20101, 1)
			else
				doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "Maybe the isn't the right place to pray?")
			end
		else
			doPlayerSendTextMessage(cid, TALKTYPE_ORANGE_1, "Angels only show up once")
		end
	end
	return true
end

 

[Ninja Bodil]

working now thanks.

 

[Teckman]

dude, didnt you read the post of colandus?
You cant do this:

if(getPlayerPosition(cid) == {x = 1000, y = 993, z = 6, stackpos = 253}) then

You need to use:

comparePos(getPlayerPosition(cid), pos_here)

I bet you don't even know what does the getPlayerPosition(cid) return. I'am only not sure what stackpos it returns.

 

[Kekox]

@Up
Hey tekman, look at this:

working now thanks.

You're owned..

 

[Ninja Bodil]

rep+ on both

 

[Teckman]

@Up
Hey tekman, look at this:


You're owned..

Hey keox don't you know how to compare tables?

You're owned...

 

[Fallen]

Hey keox don't you know how to compare tables?

You're owned...

u cant compare table with table

 

[Teckman]

u cant compare table with table

Lmao, just checked that and in lua tables can't be compared. I didn't know that for sure, in other languages you can compare tables as you want.

 

[Colandus]

rep+ on both

and me?

Lmao, just checked that and in lua tables can't be compared. I didn't know that for sure, in other languages you can compare tables as you want.

no u cant...