[Task] Monster counter

[kamilcioo]

Hey, I need some help. My script only counts 1 person who attacks the monster and I wanna make it that it counts kill for everyone who attacked the monster.

local config = {
     ['cockroach'] = {amount = 20, storage = 20001, startstorage = 20000, startvalue = 1}
   
}
function onKill(cid, target)
     local monster = config[getCreatureName(target):lower()]
     if isPlayer(target) or not monster or isSummon(target) then
         return true
     end

     if getPlayerStorageValue(cid, monster.storage) >= -1 and (getPlayerStorageValue(cid, monster.storage)+1) < monster.amount and getPlayerStorageValue(cid, monster.startstorage) >= monster.startvalue then
         setPlayerStorageValue(cid, monster.storage, getPlayerStorageValue(cid, monster.storage) + 1)
         doPlayerSendTextMessage(cid, MESSAGE_STATUS_CONSOLE_ORANGE, 'Task message: '..(getPlayerStorageValue(cid, monster.storage)+1)..' of '..monster.amount..' '..getCreatureName(target)..'s killed.')
     end
     if (getPlayerStorageValue(cid, monster.storage)+1) == monster.amount then
         doPlayerSendTextMessage(cid, MESSAGE_INFO_DESCR, 'Congratulations, you have killed '..(getPlayerStorageValue(cid, monster.storage)+1)..' '..getCreatureName(target)..'s and completed the '..getCreatureName(target)..'s mission.')
         setPlayerStorageValue(cid, monster.storage, getPlayerStorageValue(cid, monster.storage) + 1)
     end
     return true
end

 

[kamilcioo]

Bump.

 

[kamilcioo]

Bump.

 

[kamilcioo]

Bump.

 

[Limos]

Which server do you use?

 

[kamilcioo]

Tfs 1.0

 

[Limos]

local config = {
  ['cockroach'] = {amount = 20, storage = 20001, startstorage = 20000, startvalue = 1}
}

function onDeath(cid, corpse, killer, mostDamage, unjustified, mostDamage_unjustified)
     local creature = Creature(cid)
     local monster = config[creature:getName():lower()]
     if not monster or creature:getMaster() then
         return true
     end

     local damageMap = creature:getDamageMap()
     for pid, damage in pairs(damageMap) do
         local player = Player(pid)
         if player then
             if (player:getStorageValue(monster.storage)+1) < monster.amount and player:getStorageValue(monster.startstorage) >= monster.startvalue then
                 player:setStorageValue(monster.storage, player:getStorageValue(monster.storage) +1)
                 player:sendTextMessage(MESSAGE_STATUS_CONSOLE_ORANGE, 'Task message: '..(player:getStorageValue(monster.storage) +1)..' of '..monster.amount..' '..creature:getName()..'s killed.')
             end
             if (player:getStorageValue(monster.storage)+1) == monster.amount then
                 player:setStorageValue(monster.storage, player:getStorageValue(monster.storage) +1)
                 player:sendTextMessage(MESSAGE_INFO_DESCR, 'Congratulations, you have killed '..(player:getStorageValue(monster.storage)+1)..' '..creature:getName()..'s and completed the '..creature:getName()..'s mission.')
             end
         end
     end
     return true
end

Register the script in the monsters instead of in login.lua.
Like this

<script>
     <event name="Name"/>
</script>

 

[kamilcioo]

I'm getting a bug "Event OnKill not found".
I've tried to add "function onKill(cid, target)", scripts dont give a bug but it doesn't count monsters. Any idea?

 

[Limos]

Add it with type death in creaturescripts.xml.
Also don't forgot to not register it in login.lua but in the monster file.

 

[kamilcioo]

When I add it in cockroach monster file I get a bug that removes all cockroaches

 

[Limos]

Post the error if you have one and the monster file how you added it.

 

[kamilcioo]

No error and posted it like others.

 

[Limos]

Can you post the monster file how you added it?
And also creaturescripts.xml, make sure to not register it in login.lua, so if it's still registered there, remove it.

 

[kamilcioo]

I'll test it when I come back to home.