[TFS 0.3/0.4 and 1.x] Vocation interval effect system - configurable in vocations.xml

[Nenth]

Note: This code was orginally written for TFS 0.3 by Dantez from tibia.net.pl!
I just a little bit changed it to make it work on TFS 1.x.

Code allows you to set different effect for each vocation.
effect="29" <-- Here you can put effect ID
effectInterval="1000" <-- Here you can set Interval

The Forgotten Server 1.x version

Configuration:

effect="29" effectInterval="1000"

Player.cpp

after:

lastPong = lastPing;

add:

lastEffect = lastPong;

after:

int64_t timeNow = OTSYS_TIME();

add:

if (vocation && vocation->getEffect() && timeNow - lastEffect >= vocation->getEffectInterval())
    {
        g_game.addMagicEffect(getPosition(), vocation->getEffect());
        lastEffect = timeNow;
    }

Player.h

after:

uint64_t manaSpent;

add:

uint64_t lastEffect;

Vocation.cpp

after:

if ((attr = vocationNode.attribute("description"))) {
            voc.description = attr.as_string();
        }

add:

if ((attr = vocationNode.attribute("effect"))) {
            voc.effect = pugi::cast<uint32_t>(attr.value());
        }

        if ((attr = vocationNode.attribute("effectInterval"))) {
            voc.effectInterval = pugi::cast<uint32_t>(attr.value());
        }

Vocation.h

after:

uint64_t getReqMana(uint32_t magLevel);

add:

uint32_t getEffect() const { return effect; }
void setEffect(uint32_t _effect) { effect = _effect; }

uint32_t getEffectInterval() const { return effectInterval; }
void setEffectInterval(uint32_t _interval) { effectInterval = _interval; }

after:

uint32_t baseSpeed;

add:

uint32_t effect;
uint32_t effectInterval;

The Forgotten Server 0.3/0.4 version

Configuration:

effect="29" interval="1000"

Vocation.h

find:

uint32_t id, fromVocation, baseSpeed, attackSpeed;

change for:

uint32_t id, fromVocation, baseSpeed, attackSpeed, effect, effectInterval;

find:

uint64_t getReqMana(uint32_t magLevel);

add under:

uint32_t getEffect() const {return effect;}
void setEffect(uint32_t _effect) {effect = _effect;}
uint32_t getEffectInterval() const {return effectInterval;}
void setEffectInterval(uint32_t _interval) {effectInterval = _interval;}

Vocation.cpp

find:

name = description = "";

add under:

effect = 0;
effectInterval = 4000;    --here you can configure default interval value

find:

if(readXMLInteger(p, "lessloss", intValue))
        voc->setLessLoss(intValue);

add under:

if(readXMLInteger(p, "effect", intValue))
        voc->setEffect(intValue);
if(readXMLInteger(p, "interval", intValue))
    voc->setEffectInterval(intValue);

Player.h

find:

uint64_t lastAttack;

add under:

uint64_t lastEffect;

Player.cpp

find:

lastLoad = lastPing = lastPong = OTSYS_TIME();

change to:

lastLoad = lastPing = lastPong = lastEffect = OTSYS_TIME();

find:

int64_t timeNow = OTSYS_TIME();

add under:

if(vocation && vocation->getEffect() && timeNow - lastEffect >= vocation->getEffectInterval())
{
    g_game.addMagicEffect(getPosition(), vocation->getEffect());
    lastEffect = timeNow;
}

Note: If your engine after adding this code will keep crashing, then go to your source directory and delete /obj folder and compile your server again. This only happens in TFS 0.3/0.4!

Enjoy!

 

[Nenth]

Bump~
I will add TFS 0.3/0.4 and OTServ version on friday if someone is intrested.

 

[JohnColner]

Bump~
I will add TFS 0.3/0.4 and OTServ version on friday if someone is intrested.

I'm interested ! TFS 0.4 am grateful for sharing, beautiful code

 

[Nenth]

@JohnColner Updated main post with 0.3/0.4 version. Enjoy.

 

[Elgenady]

u can use lua for this
something like this

function onThink(interval, lastExecution)
for _, name in ipairs(getOnlinePlayers()) do
local cid = getPlayerByName(name)
if isKnight(cid) then
doSendMagicEffect(getPlayerPosition(cid), 22)
doSendAnimatedText(getPlayerPosition(cid), "Knight", TEXTCOLOR_RED)
end
end
return true
end

 

[Nenth]

@heba Ofcorse, but I think that C++ is faster and configuration in vocations.xml is more comfortable.

 

[narutomaniacos]

How to add position, like x+1?

 

[zuber966]

I guess you need to provide different position to this line

g_game.addMagicEffect(getPosition(), vocation->getEffect());