C++ TFS 1.2 Is it possible to fix the spell emote spam

[Tbol]

I will try to explain what i mean but basically when you cast a spell orange text appears above your head right? So if you cast it like a lot of time it stacks up and it looks just nasty so i will provide image what i mean
Is it possible to make it so it send only like max 3 not that much as in image

 

[Marko999x]

Im not if thats possible but we can make your spell be casted like 3 times instead of spamming if u want?

 

[EvilSkillz]

Im not if thats possible but we can make your spell be casted like 3 times instead of spamming if u want?

I think source edit can work

 

[Tbol]

Im not if thats possible but we can make your spell be casted like 3 times instead of spamming if u want?

Nah it won't do it

 

[EvilSkillz]

Nah it won't do it

Whats the point of spamming spells if we can do it easier with addevent?

 

[Tbol]

Whats the point of spamming spells if we can do it easier with addevent?

I mean spell cooldown is 1 seconds and you want it to cast spell only 3 times. And I have over 100 spells that have same cooldown so I don't think it's smart

 

[EvilSkillz]

Can be changed in like 10sec

 

[Sarah Wesker]

game.cpp -> bool Game::playerSaySpell(Player* player, SpeakClasses type, const std::string& text) You can play with some type of temporizador so that the text of said spell has a cooldown, so that you can continue executing your spell but the text that is shown only appears every so often

 

[Tbol]

Can be changed in like 10sec

But still you would be able too cast spell only 3 times which is the dumbest solution ever

game.cpp -> bool Game::playerSaySpell(Player* player, SpeakClasses type, const std::string& text) You can play with some type of temporizador so that the text of said spell has a cooldown, so that you can continue executing your spell but the text that is shown only appears every so often

But still it doesnt put a limit of text and if i understand right isnt text would be off, like with delay it would look like its lagging? And wont it hit trough performance?

 

[Itutorial]

You would have to make it so every 3x its casted there is a 4 second delay before the next one.

 

[Tbol]

You would have to make it so every 3x its casted there is a 4 second delay before the next one.

How its even possible?

 

[Marko999x]

You can remove it if you want tho haha

so it does not show "exori uber blabla" also only for this spell

 

[Tbol]

You can remove it if you want tho haha

so it does not show "exori uber blabla" also only for this spell

Nah its kinda a think to see a exori uber blabla and for every other spell too

 

[Marko999x]

Nah its kinda a think to see a exori uber blabla and for every other spell too

Do you have many spells which are like "spamming" ?

 

[Tbol]

Do you have many spells which are like "spamming" ?

All of them because all spells have 1 sec cooldown. So all of them stacks up like in that image

 

[Marko999x]

Which client are you even using?

Im using OTCv8 and it does not stack that alot

All of them because all spells have 1 sec cooldown. So all of them stacks up like in that image

 

[Tbol]

Which client are you even using?

Im using OTCv8 and it does not stack that alot

Well yea OTCv8 is in new age when im using stone age client 8.60

 

[JayMeazy]

I needed this too, it should work for you too, you'll have to adjust the numbers because I have different cooldowns,
first go to enums.h
add CONDITION_EMOTESPELLEXHAUST to the bottom of ConditionType_t table:

    CONDITION_EXHAUST_COMBAT = 1 << 23, // unused
    CONDITION_EXHAUST_HEAL = 1 << 24, // unused
    CONDITION_PACIFIED = 1 << 25,
    CONDITION_SPELLCOOLDOWN = 1 << 26,
    CONDITION_SPELLGROUPCOOLDOWN = 1 << 27,
    CONDITION_EMOTESPELLEXHAUST = 1 << 28,

add to conditions.cpp:
by case CONDITION_MUTED add case CONDITION_EMOTESPELLEXHAUST:

        case CONDITION_EXHAUST_COMBAT:
        case CONDITION_EXHAUST_BUFF:
        case CONDITION_EXHAUST_HEAL:
        case CONDITION_MUTED:
        case CONDITION_EMOTESPELLEXHAUST:

and game.cpp, mine looked like this:

    if (result == TALKACTION_BREAK) {
        if (!g_config.getBoolean(ConfigManager::EMOTE_SPELLS)) {
            return internalCreatureSay(player, TALKTYPE_SAY, words, false);
        } else {
            return internalCreatureSay(player, TALKTYPE_MONSTER_SAY, words, false);
        }

    } else if (result == TALKACTION_FAILED) {
        return true;
    }

I changed it to this:

    if (result == TALKACTION_BREAK) {


        if (!player->hasCondition(CONDITION_EMOTESPELLEXHAUST)) {
            Condition* condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_EMOTESPELLEXHAUST, 4000, 0);
            player->addCondition(condition);
            return internalCreatureSay(player, TALKTYPE_MONSTER_SAY, words, false);
        } else {
            if (player->getCondition(CONDITION_EMOTESPELLEXHAUST)->getTicks() >= 4000) {
                return true;
            }
            else {
                player->getCondition(CONDITION_EMOTESPELLEXHAUST)->setTicks(std::min(7000, 2500 + player->getCondition(CONDITION_EMOTESPELLEXHAUST)->getTicks()));
                return internalCreatureSay(player, TALKTYPE_MONSTER_SAY, words, false);
            }
        }

    } else if (result == TALKACTION_FAILED) {
        return true;
    }

I'm not sure about the differences between 1.2 and 1.3

 

[Tbol]

I needed this too, it should work for you too, you'll have to adjust the numbers because I have different cooldowns,
first go to enums.h
add CONDITION_EMOTESPELLEXHAUST to the bottom of ConditionType_t table:

    CONDITION_EXHAUST_COMBAT = 1 << 23, // unused
    CONDITION_EXHAUST_HEAL = 1 << 24, // unused
    CONDITION_PACIFIED = 1 << 25,
    CONDITION_SPELLCOOLDOWN = 1 << 26,
    CONDITION_SPELLGROUPCOOLDOWN = 1 << 27,
    CONDITION_EMOTESPELLEXHAUST = 1 << 28,

add to conditions.cpp:
by case CONDITION_MUTED add case CONDITION_EMOTESPELLEXHAUST:

        case CONDITION_EXHAUST_COMBAT:
        case CONDITION_EXHAUST_BUFF:
        case CONDITION_EXHAUST_HEAL:
        case CONDITION_MUTED:
        case CONDITION_EMOTESPELLEXHAUST:

and game.cpp, mine looked like this:

    if (result == TALKACTION_BREAK) {
        if (!g_config.getBoolean(ConfigManager::EMOTE_SPELLS)) {
            return internalCreatureSay(player, TALKTYPE_SAY, words, false);
        } else {
            return internalCreatureSay(player, TALKTYPE_MONSTER_SAY, words, false);
        }

    } else if (result == TALKACTION_FAILED) {
        return true;
    }

I changed it to this:

    if (result == TALKACTION_BREAK) {


        if (!player->hasCondition(CONDITION_EMOTESPELLEXHAUST)) {
            Condition* condition = Condition::createCondition(CONDITIONID_DEFAULT, CONDITION_EMOTESPELLEXHAUST, 4000, 0);
            player->addCondition(condition);
            return internalCreatureSay(player, TALKTYPE_MONSTER_SAY, words, false);
        } else {
            if (player->getCondition(CONDITION_EMOTESPELLEXHAUST)->getTicks() >= 4000) {
                return true;
            }
            else {
                player->getCondition(CONDITION_EMOTESPELLEXHAUST)->setTicks(std::min(7000, 2500 + player->getCondition(CONDITION_EMOTESPELLEXHAUST)->getTicks()));
                return internalCreatureSay(player, TALKTYPE_MONSTER_SAY, words, false);
            }
        }

    } else if (result == TALKACTION_FAILED) {
        return true;
    }

I'm not sure about the differences between 1.2 and 1.3

Does it affect performance in any way?

 

[Sarah Wesker]

Does it affect performance in any way?

This on a deeper level could be said to add extra nanoseconds of delay between when the spell is invoked and when the spell is executed, because now a few extra things are checked and a couple of extra actions are done, but it is absolutely irrelevant to human time, but nothing more, if I'm wrong, someone correct me