Feature [TFS 1.2] Monster:onSpawn(position, startup, artificial)

[Infernum]

Game.createMonster("Valkyrie", self:getPosition()) right before return false

 

[flaviiojr]

Game.createMonster("Valkyrie", self:getPosition()) right before return false

oh, im tested! thanks, worked!

 

[silveralol]

you can't directly change the actual monster spawn

you can, some time ago Mkalo help me with something like that, the respawn of a monster can be "changed" to another monster that is in the same "spawn" (that violet fire) I couldn't find another way to say it sorry

 

[Infernum]

you can, some time ago Mkalo help me with something like that, the respawn of a monster can be "changed" to another monster that is in the same "spawn" (that violet fire) I couldn't find another way to say it sorry

ofc you can do whatever you want by changing sources, i'm saying the way it's made right now in my code you can't do that.

 

[Evil Puncker]

using these changes on latest tfs is making monsters no longer drop loot, or am I the only one with this issue? 🤔

 

[kimokimo]

using these changes on latest tfs is making monsters no longer drop loot, or am I the only one with this issue? 🤔

same issue here

 

[zbizu]

what does artificial stand for?

 

[kimokimo]

what does artificial stand for?

A monster that died and respawned

 

[Infernum]

A monster that died and respawned

No.

what does artificial stand for?

True if it was spawned by artificial means, i.e. /m or Game.createMonster, false if it was created from their original spawn.

 

[kimokimo]

No.


True if it was spawned by artificial means, i.e. /m or Game.createMonster, false if it was created from their original spawn.

true: the monster is spawned from a spawn on the map
false: the monster is spawned artificially via Game.createMonster(name, pos)

that's what i understood from your explanation

also why's the loot not dropping of tfs 1.3

 

[Infernum]

true: the monster is spawned from a spawn on the map
false: the monster is spawned artificially via Game.createMonster(name, pos)

that's what i understood from your explanation

also why's the loot not dropping of tfs 1.3

In the explanation I put it backwards for true/false, but the loot has nothing to do with this system.

 

[Evil Puncker]

the loot has nothing to do with this system.

as weird as it can be, after undoing these changes the loot went back to normal

 

[kimokimo]

In the explanation I put it backwards for true/false, but the loot has nothing to do with this system.

Must be something wrong because me and @Evil Puncker experienced the same issue, also loot in tfs 1.3 is generated in lua does that have anything to do with it?

 

[Infernum]

I see now, the Monster event class didn't exist before onDropLoot was added, so now there's an if statement at the end of the chain which is never executed, meaning onDropLoot will never execute from data/events/monster.lua.
Instead of adding the if (className == "Monster") portion to the top of the else/if chain, you need to place it under the current existing one that has dropLoot under it, and just check for the method name

        } else if (className == "Monster") {
            if (methodName == "onDropLoot") {
                info.monsterOnDropLoot = event;
            } else {
                std::cout << "[Warning - Events::load] Unknown monster method: " << methodName << std::endl;
            }

to:

        } else if (className == "Monster") {
            if (methodName == "onDropLoot") {
                info.monsterOnDropLoot = event;
            } else if (methodName == "onSpawn") {
                info.monsterOnSpawn = event;
            } else {
                std::cout << "[Warning - Events::load] Unknown monster method: " << methodName << std::endl;
            }

 

[kimokimo]

I see now, the Monster event class didn't exist before onDropLoot was added, so now there's an if statement at the end of the chain which is never executed, meaning onDropLoot will never execute from data/events/monster.lua.
Instead of adding the if (className == "Monster") portion to the top of the else/if chain, you need to place it under the current existing one that has dropLoot under it, and just check for the method name

        } else if (className == "Monster") {
            if (methodName == "onDropLoot") {
                info.monsterOnDropLoot = event;
            } else {
                std::cout << "[Warning - Events::load] Unknown monster method: " << methodName << std::endl;
            }

to:

        } else if (className == "Monster") {
            if (methodName == "onDropLoot") {
                info.monsterOnDropLoot = event;
            } else if (methodName == "onSpawn") {
                info.monsterOnSpawn = event;
            } else {
                std::cout << "[Warning - Events::load] Unknown monster method: " << methodName << std::endl;
            }

also there another one search for if (className == "Monster") you'll find it else it won't work without i just tested it

 

[Infernum]

also there another one search for if (className == "Monster") you'll find it else it won't work without i just tested it

That's literally what I wrote.
I said instead of adding it to the top, you need to check methodname under the currently existing one in 1.3, which is at the bottom of the else/if chain, I even wrote an example of what I meant.

 

[kimokimo]

That's literally what I wrote.
I said instead of adding it to the top, you need to check methodname under the currently existing one in 1.3, which is at the bottom of the else/if chain, I even wrote an example of what I meant.

Ahh my bad

 

[Sarah Wesker]

This generates a crash on the server:

monster:remove()

The solution:
Add what is surrounded in light green.

game.cpp

map.cpp


This was one of the solutions I found at the first, but if there is a better solution, I would like to see it!

The blocking is caused by the function

map.getSpectators(list, >> tile->getPosition() <<, true)

this try to get the position of a tile that does not exist yet. this is in game.cpp in the function

bool Game::removeCreature(Creature* creature, bool isLogout/* = true*/)

 

[Infernum]

There is absolutely zero reason to use monster:remove() in the first place, the return value of the function blocks the spawn if it's set to false. All this "fix" is, is a workaround for something that can already be handled with the original source.

 

[Sarah Wesker]

I am creating a system in which it is necessary to use such a function, in the same way I would have liked to see another solution to the problem, there should be no things that block the server in any way.