[TFS 1.2] Need Critical hit system

Lopaskurwa · Jun 10, 2018

Hi
maybe someone have critical system script? That works like this, lets say you have "10 sword fighting you have 1% chance to hit critical hit", "20 sword fighting you have 2% chance to hit critical hit", "30 sword fighting you have 3% chance to hit critical hit" and etc and when you hit critical hit it sends some kind of magic effect and thats it.

drakylucas · Jun 12, 2018

Lopaskurwa said:
It doesnt work.

Change skilllvl to skillLvl and test, please
I can't test

I've just noticed that I used uppercase in one of them and lowercase in other..
If possible, tell me the error after that

Lopaskurwa · Jun 12, 2018

drakylucas said:
Change skilllvl to skillLvl and test, please
I can't test I've just noticed that I used uppercase in one of them and lowercase in other..
If possible, tell me the error after that

Changed. Still not working. It doeesnt have any errors or warnings in console its just seems like it doesnt functional at all

Lopaskurwa · Jun 14, 2018

Lopaskurwa · Jun 18, 2018

Sarah Wesker · Jun 18, 2018

Critical system perfect!
not is necesary a explication...

Code:

local criticalDefaultChance = 5
local criticalDefaultDamage = 2

local weaponTypeToSkillType = {
    [WEAPON_SWORD] = function(p) return p:getEffectiveSkillLevel(SKILL_SWORD) end,
    [WEAPON_AXE] = function(p) return p:getEffectiveSkillLevel(SKILL_AXE) end,
    [WEAPON_CLUB] = function(p) return p:getEffectiveSkillLevel(SKILL_CLUB) end,
    [WEAPON_AMMO] = function(p) return p:getEffectiveSkillLevel(SKILL_DISTANCE) end,
    [WEAPON_DISTANCE] = function(p) return p:getEffectiveSkillLevel(SKILL_DISTANCE) end,
    [WEAPON_WAND] = function(p) return p:getMagicLevel() end
}

function getSkillByYouWeapon(player)
    local skillValue = 0
    local weapon = player:getSlotItem(CONST_SLOT_LEFT)
    if weapon and ItemType(weapon:getId()):getWeaponType() > 0 then
        skillValue = weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()] and weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()](player) or 0
    else
        weapon = player:getSlotItem(CONST_SLOT_RIGHT)
        if weapon and ItemType(weapon:getId()):getWeaponType() > 0 then
            skillValue = weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()] and weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()](player) or 0
        end
    end
    return skillValue
end

function onHealthChange(creature, attacker, pD, pT, sD, sT, origin)
    if isPlayer(attacker) then
        local skill = getSkillByYouWeapon(attacker)
        if math.random(100 + skill) <= (criticalDefaultChance + (skill / 2)) then
            if origin == ORIGIN_MELEE then
                creature:say("SKULLBASH!", TALKTYPE_MONSTER_SAY)
            elseif origin == ORIGIN_RANGED then
                creature:say("HEADSHOT!", TALKTYPE_MONSTER_SAY)
            end
            pD = pD * criticalDefaultDamage
        end
    end
    return pD, pT, sD, sT
end

drakylucas · Jun 18, 2018

Sarah Wesker said:

Critical system perfect!
not is necesary a explication...

Code:

local criticalDefaultChance = 5
local criticalDefaultDamage = 2

local weaponTypeToSkillType = {
    [WEAPON_SWORD] = function(p) return p:getEffectiveSkillLevel(SKILL_SWORD) end,
    [WEAPON_AXE] = function(p) return p:getEffectiveSkillLevel(SKILL_AXE) end,
    [WEAPON_CLUB] = function(p) return p:getEffectiveSkillLevel(SKILL_CLUB) end,
    [WEAPON_AMMO] = function(p) return p:getEffectiveSkillLevel(SKILL_DISTANCE) end,
    [WEAPON_DISTANCE] = function(p) return p:getEffectiveSkillLevel(SKILL_DISTANCE) end,
    [WEAPON_WAND] = function(p) return p:getMagicLevel() end
}

function getSkillByYouWeapon(player)
    local skillValue = 0
    local weapon = player:getSlotItem(CONST_SLOT_LEFT)
    if weapon and ItemType(weapon:getId()):getWeaponType() > 0 then
        skillValue = weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()] and weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()](player) or 0
    else
        weapon = player:getSlotItem(CONST_SLOT_RIGHT)
        if weapon and ItemType(weapon:getId()):getWeaponType() > 0 then
            skillValue = weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()] and weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()](player) or 0
        end
    end
    return skillValue
end

function onHealthChange(creature, attacker, pD, pT, sD, sT, origin)
    if isPlayer(attacker) then
        local skill = getSkillByYouWeapon(attacker)
        if math.random(100 + skill) <= (criticalDefaultChance + (skill / 2)) then
            if origin == ORIGIN_MELEE then
                creature:say("SKULLBASH!", TALKTYPE_MONSTER_SAY)
            elseif origin == ORIGIN_RANGED then
                creature:say("HEADSHOT!", TALKTYPE_MONSTER_SAY)
            end
            pD = pD * criticalDefaultDamage
        end
    end
    return pD, pT, sD, sT
end

Very nice..
Actually, I think you should also implement this on onManaChange, right? otherwise, the critical system will work only when a monster loses health (or a player loses health, but not player with manashield)

And also, I think he'll need to register the event on every creature of the server, and also in onLogin (so it will works with players aswell)
But very well detailed xD nice

Lopaskurwa · Jun 18, 2018

Sarah Wesker said:

Critical system perfect!
not is necesary a explication...

Code:

local criticalDefaultChance = 5
local criticalDefaultDamage = 2

local weaponTypeToSkillType = {
    [WEAPON_SWORD] = function(p) return p:getEffectiveSkillLevel(SKILL_SWORD) end,
    [WEAPON_AXE] = function(p) return p:getEffectiveSkillLevel(SKILL_AXE) end,
    [WEAPON_CLUB] = function(p) return p:getEffectiveSkillLevel(SKILL_CLUB) end,
    [WEAPON_AMMO] = function(p) return p:getEffectiveSkillLevel(SKILL_DISTANCE) end,
    [WEAPON_DISTANCE] = function(p) return p:getEffectiveSkillLevel(SKILL_DISTANCE) end,
    [WEAPON_WAND] = function(p) return p:getMagicLevel() end
}

function getSkillByYouWeapon(player)
    local skillValue = 0
    local weapon = player:getSlotItem(CONST_SLOT_LEFT)
    if weapon and ItemType(weapon:getId()):getWeaponType() > 0 then
        skillValue = weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()] and weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()](player) or 0
    else
        weapon = player:getSlotItem(CONST_SLOT_RIGHT)
        if weapon and ItemType(weapon:getId()):getWeaponType() > 0 then
            skillValue = weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()] and weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()](player) or 0
        end
    end
    return skillValue
end

function onHealthChange(creature, attacker, pD, pT, sD, sT, origin)
    if isPlayer(attacker) then
        local skill = getSkillByYouWeapon(attacker)
        if math.random(100 + skill) <= (criticalDefaultChance + (skill / 2)) then
            if origin == ORIGIN_MELEE then
                creature:say("SKULLBASH!", TALKTYPE_MONSTER_SAY)
            elseif origin == ORIGIN_RANGED then
                creature:say("HEADSHOT!", TALKTYPE_MONSTER_SAY)
            end
            pD = pD * criticalDefaultDamage
        end
    end
    return pD, pT, sD, sT
end

Lul why it doesnt work for me?

drakylucas · Jun 18, 2018

Lopaskurwa said:
Lul why it doesnt work for me?

I guess you aren't registering the event in login.lua and in every monster xml
if you register the event in login.lua (Creaturescript), it should work with players, but not with creatures (since the creatures are the ones which the health is changing), so you need to register the event in the monsters too... probrably there's a way to do it automatically, but I don't know for now (I'm not programming along TFS for long time ago, just check this forum from time to time)

Sarah Wesker · Jun 18, 2018

for the players use login.lua and for the monster use
data/events/scripts/creature.lua - function onTargetCombat

now use this script criticalSystem.lua:

Code:

local criticalDefaultChance = 5
local criticalDefaultDamage = 2

local weaponTypeToSkillType = {
    [WEAPON_SWORD] = function(p) return p:getEffectiveSkillLevel(SKILL_SWORD) end,
    [WEAPON_AXE] = function(p) return p:getEffectiveSkillLevel(SKILL_AXE) end,
    [WEAPON_CLUB] = function(p) return p:getEffectiveSkillLevel(SKILL_CLUB) end,
    [WEAPON_AMMO] = function(p) return p:getEffectiveSkillLevel(SKILL_DISTANCE) end,
    [WEAPON_DISTANCE] = function(p) return p:getEffectiveSkillLevel(SKILL_DISTANCE) end,
    [WEAPON_WAND] = function(p) return p:getMagicLevel() end
}

function getSkillByYouWeapon(player)
    local skillValue = 0
    local weapon = player:getSlotItem(CONST_SLOT_LEFT)
    if weapon and ItemType(weapon:getId()):getWeaponType() > 0 then
        skillValue = weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()] and weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()](player) or 0
    else
        weapon = player:getSlotItem(CONST_SLOT_RIGHT)
        if weapon and ItemType(weapon:getId()):getWeaponType() > 0 then
            skillValue = weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()] and weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()](player) or 0
        end
    end
    return skillValue
end

local function onChange(creature, attacker, damage, origin)
    local skill = getSkillByYouWeapon(attacker)
    if math.random(100 + skill) <= (criticalDefaultChance + (skill / 2)) then
        if origin == ORIGIN_MELEE then
            creature:say("SKULLBASH!", TALKTYPE_MONSTER_SAY)
        elseif origin == ORIGIN_RANGED then
            creature:say("HEADSHOT!", TALKTYPE_MONSTER_SAY)
        end
        damage = damage * criticalDefaultDamage
    end
    return damage
end

function onHealthChange(creature, attacker, pD, pT, sD, sT, origin)
    if isPlayer(attacker) then
        pD = onChange(creature, attacker, pD, origin)
    end
    return pD, pT, sD, sT
end

function onManaChange(creature, attacker, manaChange, origin)
    if isPlayer(attacker) then
        manaChange = onChange(creature, attacker, manaChange, origin)
    end
    return manaChange
end

in creaturescripts do register

Lopaskurwa · Jun 18, 2018

Sarah Wesker said:

for the players use login.lua and for the monster use
data/events/scripts/creature.lua - function onTargetCombat

now use this script criticalSystem.lua:

Code:

local criticalDefaultChance = 5
local criticalDefaultDamage = 2

local weaponTypeToSkillType = {
    [WEAPON_SWORD] = function(p) return p:getEffectiveSkillLevel(SKILL_SWORD) end,
    [WEAPON_AXE] = function(p) return p:getEffectiveSkillLevel(SKILL_AXE) end,
    [WEAPON_CLUB] = function(p) return p:getEffectiveSkillLevel(SKILL_CLUB) end,
    [WEAPON_AMMO] = function(p) return p:getEffectiveSkillLevel(SKILL_DISTANCE) end,
    [WEAPON_DISTANCE] = function(p) return p:getEffectiveSkillLevel(SKILL_DISTANCE) end,
    [WEAPON_WAND] = function(p) return p:getMagicLevel() end
}

function getSkillByYouWeapon(player)
    local skillValue = 0
    local weapon = player:getSlotItem(CONST_SLOT_LEFT)
    if weapon and ItemType(weapon:getId()):getWeaponType() > 0 then
        skillValue = weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()] and weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()](player) or 0
    else
        weapon = player:getSlotItem(CONST_SLOT_RIGHT)
        if weapon and ItemType(weapon:getId()):getWeaponType() > 0 then
            skillValue = weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()] and weaponTypeToSkillType[ItemType(weapon:getId()):getWeaponType()](player) or 0
        end
    end
    return skillValue
end

local function onChange(creature, attacker, damage, origin)
    local skill = getSkillByYouWeapon(attacker)
    if math.random(100 + skill) <= (criticalDefaultChance + (skill / 2)) then
        if origin == ORIGIN_MELEE then
            creature:say("SKULLBASH!", TALKTYPE_MONSTER_SAY)
        elseif origin == ORIGIN_RANGED then
            creature:say("HEADSHOT!", TALKTYPE_MONSTER_SAY)
        end
        damage = damage * criticalDefaultDamage
    end
    return damage
end

function onHealthChange(creature, attacker, pD, pT, sD, sT, origin)
    if isPlayer(attacker) then
        pD = onChange(creature, attacker, pD, origin)
    end
    return pD, pT, sD, sT
end

function onManaChange(creature, attacker, manaChange, origin)
    if isPlayer(attacker) then
        manaChange = onChange(creature, attacker, manaChange, origin)
    end
    return manaChange
end

in creaturescripts do register

Still the same or i'm just stupid and missing something.
data/creaturescript

Code:

    <event type="healthchange" name="CriticalSystemHp" script="criticalSystem.lua" />
    <event type="manachange" name="CriticalSystemMp" script="criticalSystem.lua" />

data/creaturescript/script
I made criticalSystem.lua with critical system code
Then
data/event/script/creature.lua

Code:

function Creature:onChangeOutfit(outfit)
    return true
end

function Creature:onAreaCombat(tile, isAggressive)
    return true
end

function Creature:onTargetCombat(target)
if not self then
return true
end

if self:getIsCastleDefender(target) then
return false
end

if target:isMonster() then
target:registerEvent('CriticalSystem')
end

Sarah Wesker · Jun 18, 2018

yes, CriticalSystemMp and Hp
for monster is only Hp,

Code:

if target:isMonster() then
target:registerEvent('CriticalSystemHp')
end

Lopaskurwa · Jun 18, 2018

Sarah Wesker said:
yes, CriticalSystemMp and Hp
for monster is only Hp,

Code:

if target:isMonster() then target:registerEvent('CriticalSystemHp') end

Still the same

Lopaskurwa · Jun 20, 2018

Sarah Wesker · Jun 20, 2018

No code has worked for you, but you do not have any errors either, Make sure you learn to implement things to your server first.

Lopaskurwa · Jun 20, 2018

Sarah Wesker said:
No code has worked for you, but you do not have any errors either, Make sure you learn to implement things to your server first.

But you said where to import or you told me something wrong and thats why its not functioning.

Lopaskurwa · Jun 21, 2018

mackerel · Jun 21, 2018

Lopaskurwa said:
bump

Try this:

1. Create file critical_hit_system.lua in data\creaturescripts\scripts and add the following:

Lua:

local config = {
    magic_effect = 15, -- magic effect you want to send when critical hit lands
    damage_multiplier = 10 -- default damage * 10 = critical damage
}

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
    if attacker == nil then
        return primaryDamage, primaryType, secondaryDamage, secondaryType
    end
 
    if not attacker:isPlayer() then
        return primaryDamage, primaryType, secondaryDamage, secondaryType
    end
 
    local skill = attacker:getEffectiveSkillLevel(SKILL_SWORD)
    local chance = (skill * 0.1)
 
    if math.random(100) <= chance then
        attacker:getPosition():sendMagicEffect(config.magic_effect)
        return primaryDamage * config.damage_multiplier, primaryType, secondaryDamage, secondaryType
    end
     
    return primaryDamage, primaryType, secondaryDamage, secondaryType
end

2. In data\creaturescripts\creaturescripts.xml add this line at the top, inside <creaturescripts>

Lua:

<event type="healthchange" name="criticalHitSystemX" script="critical_hit_system.lua"/>

3. In data\creaturescripts\scripts\login.lua under player:registerEvent("PlayerDeath"), add the following line:

Lua:

player:registerEvent("criticalHitSystemX")

4. This step is optional, and only required if you want to make this work with monsters - you will have to add that code for each monster that you want the critical hit system to work with. Under </flags>, add the following:

XML:

<script>
        <event name="criticalHitSystemX"/>
</script>

Lopaskurwa · Jun 21, 2018

mackerel said:
Try this:

1. Create file critical_hit_system.lua in data\creaturescripts\scripts and add the following:

Lua:

local config = { magic_effect = 15, -- magic effect you want to send when critical hit lands damage_multiplier = 10 -- default damage * 10 = critical damage } function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin) if attacker == nil then return primaryDamage, primaryType, secondaryDamage, secondaryType end if not attacker:isPlayer() then return primaryDamage, primaryType, secondaryDamage, secondaryType end local skill = attacker:getEffectiveSkillLevel(SKILL_SWORD) local chance = (skill * 0.1) if math.random(100) <= chance then attacker:getPosition():sendMagicEffect(config.magic_effect) return primaryDamage * config.damage_multiplier, primaryType, secondaryDamage, secondaryType end return primaryDamage, primaryType, secondaryDamage, secondaryType end

2. In data\creaturescripts\creaturescripts.xml add this line at the top, inside <creaturescripts>

Lua:

<event type="healthchange" name="criticalHitSystemX" script="critical_hit_system.lua"/>

3. In data\creaturescripts\scripts\login.lua under player:registerEvent("PlayerDeath"), add the following line:

Lua:

player:registerEvent("criticalHitSystemX")

4. This step is optional, and only required if you want to make this work with monsters - you will have to add that code for each monster that you want the critical hit system to work with. Under </flags>, add the following:

XML:

<script> <event name="criticalHitSystemX"/> </script>

Probably this script works because it sends effect, so thats means it works. As i understand it gives more chance to hit critical if i have more SKILL_SWORD, right? And how to send magic_effect to enemy not to me?

mackerel · Jun 21, 2018

Lopaskurwa said:
Probably this script works because it sends effect, so thats means it works. As i understand it gives more chance to hit critical if i have more SKILL_SWORD, right? And how to send magic_effect to enemy not to me?

Yes, the higher the sword skill level, the higher the chance to land critical hit. You said, skill level 10 = 1%, skill level 20 = 2% and that's how it's made

To send magic effect to enemy just change this line:

Lua:

attacker:getPosition():sendMagicEffect(config.magic_effect)

To this:

Lua:

creature:getPosition():sendMagicEffect(config.magic_effect)

Lopaskurwa · Jun 21, 2018

mackerel said:
Yes, the higher the sword skill level, the higher the chance to land critical hit. You said, skill level 10 = 1%, skill level 20 = 2% and that's how it's made

To send magic effect to enemy just change this line:

Lua:

attacker:getPosition():sendMagicEffect(config.magic_effect)

To this:

Lua:

creature:getPosition():sendMagicEffect(config.magic_effect)

Well thank u very much

[TFS 1.2] Need Critical hit system

Active Member

Intermediate OT User

Active Member

Active Member

Active Member

ƐƖєgαηт Sуηтαx ❤

Intermediate OT User

Active Member

Intermediate OT User

ƐƖєgαηт Sуηтαx ❤

Active Member

ƐƖєgαηт Sуηтαx ❤

Active Member

Active Member

ƐƖєgαηт Sуηтαx ❤

Active Member

Active Member

Well-Known Member

Active Member

Well-Known Member

Active Member

Similar threads