[TFS 1.2] Pet system

Itutorial · Mar 25, 2017

It would be easier to edit:

data>events>creature.lua

LUA:

function Creature:onTargetCombat(target)
    return true
end

hellboy · Mar 25, 2017

Aeronx said:
exp on death fixed correctly.
DUELS_ONLY working, but not correcly. I did like this.

Code:

if PETS and PETS.SYSTEM.DUELS_ONLY then if self:isPet() and target:isPlayer() or target:isPet() and self:isPlayer() or self:isMonster() and target:isPet() then return RETURNVALUE_YOUMAYNOTATTACKTHISCREATURE end end

This makes the pet ONLY attackable by other pets, BUT monsters keep targeting the pet, so its inmune and it can tank forever.. (i made this because a demon with big aoe for exemple was killing my pets all the time), any way to make pets untargeteable by monsters? (i thought RETURNVALUE_YOUMAYNOTATTACKTHISCREATURE was doing exactly that). Also pets attack what players attack, if a player cant attack pets, pet vs pet is not possible.

- If pet should get exp for killing monster, then it also should get damage from them. So I won't fix it.
- I don't know how make pets untargetable by monsters.
- I'll fix player targeting pet.

Aeronx said:
I tried to use something like this instead:
I used this creaturescript and set it to cats.

Code:

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin) if attacker and attacker:isPlayer() and (origin == ORIGIN_MELEE) or (origin == ORIGIN_MELEE) or (origin == ORIGIN_MELEE) then return 0, primaryType, 0, secondaryType end return primaryDamage, primaryType, secondaryDamage, secondaryType end

Now even if player attacks pet, no damage is done. Problem is, for some reason, pets doesnt do any damage to pets either. :/

Try this:

Code:

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin)
       
        if attacker and attacker:isPlayer() then
            return 0, primaryType, 0, secondaryType
        end
       
            return primaryDamage, primaryType, secondaryDamage, secondaryType
end

Aeronx · Mar 25, 2017

hellboy said:
- If pet should get exp for killing monster, then it also should get damage from them. So I won't fix it.
- I don't know how make pets untargetable by monsters.
- I'll fix player targeting pet.

Try this:

Code:

function onHealthChange(creature, attacker, primaryDamage, primaryType, secondaryDamage, secondaryType, origin) if attacker and attacker:isPlayer() then return 0, primaryType, 0, secondaryType end return primaryDamage, primaryType, secondaryDamage, secondaryType end

-Same result, no pet damage.
-fixed pet getting targeted by monsters. (Just set hostile = "0") on monsters.
So i think the way to go is with creature.lua on events.

Code:

if PETS and PETS.SYSTEM.DUELS_ONLY then
        if self:isPet() and target:isPlayer() or target:isPet() and self:isPlayer() or self:isMonster() and target:isPet()  or self:isPet() and target:isMonster() then
            return RETURNVALUE_YOUMAYNOTATTACKTHISCREATURE
        end
end

But this part need to be changed to something that allows players to target pets without damaging them.

hellboy · Mar 25, 2017

Aeronx said:
-Same result, no pet damage.
-fixed pet getting targeted by monsters. (Just set hostile = "0") on monsters.
So i think the way to go is with creature.lua on events.

Code:

if PETS and PETS.SYSTEM.DUELS_ONLY then if self:isPet() and target:isPlayer() or target:isPet() and self:isPlayer() or self:isMonster() and target:isPet() or self:isPet() and target:isMonster() then return RETURNVALUE_YOUMAYNOTATTACKTHISCREATURE end end

But this part need to be changed to something that allows players to target pets without damaging them.

Check updated script on github, with onHealthChange.
Changes:
pet duels fix · yrpen/lua-scripts@b11ef64 · GitHub

Aeronx · Mar 25, 2017

finally!! It works perfect!! *_*!!!

Aeronx · Apr 1, 2017

Hello @hellboy ..
Sometimes i get this error, not always tho, and player exp suddently turn to 1x.

I've been unable to solve it.

hellboy · Apr 1, 2017

Aeronx said:
Hello @hellboy ..
Sometimes i get this error, not always tho, and player exp suddently turn to 1x.

I've been unable to solve it.

I'll try to fix it.

Jorge A · Apr 7, 2017

hi
i have the next problem

[6/4/2017 19:17:4] Description:
[6/4/2017 19:17:4] data/lib/pets_lib.lua:183: attempt to index global 'Player' (a nil value)

hellboy · Apr 7, 2017

Jorge A said:
hi
i have the next problem

TFS version? Do you use last version of scripts from github?

Aeronx · Apr 7, 2017

@hellboy Any fix on that problem? >.<

hellboy · Apr 16, 2017

Aeronx said:
@hellboy Any fix on that problem? >.<

Try this:
on gain exp fix · yrpen/lua-scripts@74a1050 · GitHub

Aeronx · Apr 16, 2017

hellboy said:
Try this:
on gain exp fix · yrpen/lua-scripts@74a1050 · GitHub

Tested. Pets doesnt get any exp at all. Even if they do damage.

Pedrook · Mar 4, 2018

Aeronx said:
Tested. Pets doesnt get any exp at all. Even if they do damage.

I saw that you did not add your server, how did you get it? can you help me?

hellboy · Jan 16, 2020

@nokturno fixed pet exp issue.

I pushed fix into git repository.

ralke · Jan 17, 2020

@hellboy Im having troubles to adding events, how it should be?? I have this on my creature.lua and player.lua and getting the error

LUA:

data/events/scripts/player.lua:93: <'eof'>expected near 'end'

onTargetCombat

LUA:

function Creature:onTargetCombat(target)
target:registerEvent("UpgradeSystemHealth")
target:registerEvent("UpgradeSystemDeath")
    return RETURNVALUE_NOERROR
    end

onGainExperience

LUA:

function Player:onGainExperience(source, exp, rawExp)
  if PETS and PETS.SYSTEM.PLAYER_SHARE_EXPERIENCE and self:getPetUid() > 0 and source and source:isMonster() then
    local pet_exp = exp * PETS.CONFIG.shareExpMultipler
    self:addPetExp(pet_exp)
  end
    if not source or source:isPlayer() then
        exp = us_onGainExperience(self, source, exp, rawExp)
        return exp
    end
end

onLook

LUA:

function Player:onLook(thing, position, distance)
    if thing:isCreature() and thing:isMonster() then
        local owner = thing:getMaster()

        if owner ~= nil and owner:isPlayer() and thing:getId() == owner:getPetUid() then
            local playerName = (owner:getId() == self:getId()) and "you" or owner:getName()
            local description = "You see a ".. thing:getName() ..", it's belongs to "..playerName.."."

            if self:getGroup():getAccess() or playerName == 'you' then
                description = string.format("%s\nHealth: %d / %d", description, thing:getHealth(), thing:getMaxHealth()) .. "."
                description = string.format("%s\nLvl: %d, Exp: %d", description, owner:getPetLevel(), owner:getPetExperience()) .. "."

                if PETS.SYSTEM.MOUNTS then
                    local mountId = self:getPetMountId()
                    if mountId ~= nil and mountId ~= 0 then
                        description = string.format("%s\nHe can serve as mount.", description)
                    end
                end
            end

            if self:getGroup():getAccess() then
                local position = thing:getPosition()
                description = string.format("%s\nPosition: %d, %d, %d", description, position.x, position.y, position.z)
            end
            self:sendTextMessage(MESSAGE_INFO_DESCR, description)
            return false
        end
    end
tpLook(self, position)
        -- shop onLook -
if (thing:isCreature() and thing:isNpc() and distance <= minDist) then
       self:say("hi", TALKTYPE_PRIVATE_PN, false, thing)
       self:say("trade", TALKTYPE_PRIVATE_PN, false, thing)
       return false 
   end
       ----------------------------
    local description = "You see " .. thing:getDescription(distance) description = onItemUpgradeLook(self, thing, position, distance, description)
        -- this is the code you will add to Player:onLook --------------------------------------------------
    description = ( Tile(thing:getPosition()):hasFlag(TILESTATE_MAGICFIELD) and thing:hasAttribute(ITEM_ATTRIBUTE_OWNER) ) and (description.."\nCasted by "..Creature(thing:getAttribute(ITEM_ATTRIBUTE_OWNER)):getName() .. ".")  or description
    ----------------------------------------------------------------------------------------------------------------
    if self:getGroup():getAccess() then
        if thing:isItem() then
            description = string.format("%s\nItem ID: %d", description, thing:getId())

            local actionId = thing:getActionId()
            if actionId ~= 0 then
                description = string.format("%s, Action ID: %d", description, actionId)
            end

            local uniqueId = thing:getAttribute(ITEM_ATTRIBUTE_UNIQUEID)
            if uniqueId > 0 and uniqueId < 65536 then
                description = string.format("%s, Unique ID: %d", description, uniqueId)
            end

            local itemType = thing:getType()

            local transformEquipId = itemType:getTransformEquipId()
            local transformDeEquipId = itemType:getTransformDeEquipId()
            if transformEquipId ~= 0 then
                description = string.format("%s\nTransforms to: %d (onEquip)", description, transformEquipId)
            elseif transformDeEquipId ~= 0 then
                description = string.format("%s\nTransforms to: %d (onDeEquip)", description, transformDeEquipId)
            end

            local decayId = itemType:getDecayId()
            if decayId ~= -1 then
                description = string.format("%s\nDecays to: %d", description, decayId)
            end
        elseif thing:isCreature() then
            local str = "%s\nHealth: %d / %d"
            if thing:isPlayer() and thing:getMaxMana() > 0 then
                str = string.format("%s, Mana: %d / %d", str, thing:getMana(), thing:getMaxMana())
            end
            description = string.format(str, description, thing:getHealth(), thing:getMaxHealth()) .. "."
        end

        local position = thing:getPosition()
        description = string.format(
            "%s\nPosition: %d, %d, %d",
            description, position.x, position.y, position.z
        )

        if thing:isCreature() then
            if thing:isPlayer() then
                description = string.format("%s\nIP: %s.", description, Game.convertIpToString(thing:getIp()))
            end
        end
    end
    end
    self:sendTextMessage(MESSAGE_INFO_DESCR, description)
end

Im using other scripts I need to know how to organize it, thanks in advance!!

hellboy · Jan 23, 2020

ralke said:

@hellboy Im having troubles to adding events, how it should be?? I have this on my creature.lua and player.lua and getting the error

LUA:

data/events/scripts/player.lua:93: <'eof'>expected near 'end'

onTargetCombat

LUA:

function Creature:onTargetCombat(target)
target:registerEvent("UpgradeSystemHealth")
target:registerEvent("UpgradeSystemDeath")
    return RETURNVALUE_NOERROR
    end

onGainExperience

LUA:

function Player:onGainExperience(source, exp, rawExp)
  if PETS and PETS.SYSTEM.PLAYER_SHARE_EXPERIENCE and self:getPetUid() > 0 and source and source:isMonster() then
    local pet_exp = exp * PETS.CONFIG.shareExpMultipler
    self:addPetExp(pet_exp)
  end
    if not source or source:isPlayer() then
        exp = us_onGainExperience(self, source, exp, rawExp)
        return exp
    end
end

onLook

LUA:

function Player:onLook(thing, position, distance)
    if thing:isCreature() and thing:isMonster() then
        local owner = thing:getMaster()

        if owner ~= nil and owner:isPlayer() and thing:getId() == owner:getPetUid() then
            local playerName = (owner:getId() == self:getId()) and "you" or owner:getName()
            local description = "You see a ".. thing:getName() ..", it's belongs to "..playerName.."."

            if self:getGroup():getAccess() or playerName == 'you' then
                description = string.format("%s\nHealth: %d / %d", description, thing:getHealth(), thing:getMaxHealth()) .. "."
                description = string.format("%s\nLvl: %d, Exp: %d", description, owner:getPetLevel(), owner:getPetExperience()) .. "."

                if PETS.SYSTEM.MOUNTS then
                    local mountId = self:getPetMountId()
                    if mountId ~= nil and mountId ~= 0 then
                        description = string.format("%s\nHe can serve as mount.", description)
                    end
                end
            end

            if self:getGroup():getAccess() then
                local position = thing:getPosition()
                description = string.format("%s\nPosition: %d, %d, %d", description, position.x, position.y, position.z)
            end
            self:sendTextMessage(MESSAGE_INFO_DESCR, description)
            return false
        end
    end
tpLook(self, position)
        -- shop onLook -
if (thing:isCreature() and thing:isNpc() and distance <= minDist) then
       self:say("hi", TALKTYPE_PRIVATE_PN, false, thing)
       self:say("trade", TALKTYPE_PRIVATE_PN, false, thing)
       return false
   end
       ----------------------------
    local description = "You see " .. thing:getDescription(distance) description = onItemUpgradeLook(self, thing, position, distance, description)
        -- this is the code you will add to Player:onLook --------------------------------------------------
    description = ( Tile(thing:getPosition()):hasFlag(TILESTATE_MAGICFIELD) and thing:hasAttribute(ITEM_ATTRIBUTE_OWNER) ) and (description.."\nCasted by "..Creature(thing:getAttribute(ITEM_ATTRIBUTE_OWNER)):getName() .. ".")  or description
    ----------------------------------------------------------------------------------------------------------------
    if self:getGroup():getAccess() then
        if thing:isItem() then
            description = string.format("%s\nItem ID: %d", description, thing:getId())

            local actionId = thing:getActionId()
            if actionId ~= 0 then
                description = string.format("%s, Action ID: %d", description, actionId)
            end

            local uniqueId = thing:getAttribute(ITEM_ATTRIBUTE_UNIQUEID)
            if uniqueId > 0 and uniqueId < 65536 then
                description = string.format("%s, Unique ID: %d", description, uniqueId)
            end

            local itemType = thing:getType()

            local transformEquipId = itemType:getTransformEquipId()
            local transformDeEquipId = itemType:getTransformDeEquipId()
            if transformEquipId ~= 0 then
                description = string.format("%s\nTransforms to: %d (onEquip)", description, transformEquipId)
            elseif transformDeEquipId ~= 0 then
                description = string.format("%s\nTransforms to: %d (onDeEquip)", description, transformDeEquipId)
            end

            local decayId = itemType:getDecayId()
            if decayId ~= -1 then
                description = string.format("%s\nDecays to: %d", description, decayId)
            end
        elseif thing:isCreature() then
            local str = "%s\nHealth: %d / %d"
            if thing:isPlayer() and thing:getMaxMana() > 0 then
                str = string.format("%s, Mana: %d / %d", str, thing:getMana(), thing:getMaxMana())
            end
            description = string.format(str, description, thing:getHealth(), thing:getMaxHealth()) .. "."
        end

        local position = thing:getPosition()
        description = string.format(
            "%s\nPosition: %d, %d, %d",
            description, position.x, position.y, position.z
        )

        if thing:isCreature() then
            if thing:isPlayer() then
                description = string.format("%s\nIP: %s.", description, Game.convertIpToString(thing:getIp()))
            end
        end
    end
    end
    self:sendTextMessage(MESSAGE_INFO_DESCR, description)
end

Im using other scripts I need to know how to organize it, thanks in advance!!

Try to replace

Code:

    end
    end
    self:sendTextMessage(MESSAGE_INFO_DESCR, description)
end

with (remove one "end")

Code:

    end
    self:sendTextMessage(MESSAGE_INFO_DESCR, description)
end

olekpro · Mar 25, 2020

pet is offline but still alive, can't see him on map, and he isn't summon when join/leave chat any help? tfs 1.2

hellboy · Mar 25, 2020

olekpro said:
pet is offline but still alive, can't see him on map, and he isn't summon when join/leave chat any help? tfs 1.2

1. You use TFS 1.2?
2. Could you provide some screen shot? I'm not sure if I understand it correctly.
3. Check this post: [TFS 1.2] Pet system (https://otland.net/threads/tfs-1-2-pet-system.236403/#post-2282749)

olekpro · Mar 25, 2020

hellboy said:
1. You use TFS 1.2?
2. Could you provide some screen shot? I'm not sure if I understand it correctly.
3. Check this post: [TFS 1.2] Pet system (https://otland.net/threads/tfs-1-2-pet-system.236403/#post-2282749)

i catch pet, that's ok, i summon him by join the chat (it work correct now) BUT if my summon is online, and i RELOG, my summon disappears and i can't summon him again, need to catch other..
yup tfs 1.2 tibia 10.98

hellboy · Mar 25, 2020

olekpro said:
i catch pet, that's ok, i summon him by join the chat (it work correct now) BUT if my summon is online, and i RELOG, my summon disappears and i can't summon him again, need to catch other..
yup tfs 1.2 tibia 10.98View attachment 43411

Take a look at last script version from git:

GitHub - yrpen/lua-scripts: Few lua scripts

Few lua scripts. Contribute to yrpen/lua-scripts development by creating an account on GitHub.

github.com

And show me:
data/creaturescripts/creaturescripts.xml
data/creaturescripts/scripts/pet_owner_creaturescripts.lua

[TFS 1.2] Pet system

Legendary OT User

Intermediate OT User

Intermediate OT User

Intermediate OT User

Intermediate OT User

Intermediate OT User

Intermediate OT User

Ninja T-Rex Factory

Intermediate OT User

Intermediate OT User

Intermediate OT User

Intermediate OT User

Advanced OT User

Intermediate OT User

(҂ ͠❛ ෴ ͡❛)ᕤ

Intermediate OT User

Member

Intermediate OT User

Member

Intermediate OT User

Similar threads

(҂ ͠❛ ෴ ͡❛)ᕤ