TFS 1.2 Player:onMoveItem

[lazarus321]

Anyone know why is this error happening? I moved the bow from the right hand to the left and it appeared this error, the opposite does not happen error.

Lua Script Error: [Event Interface]
data/events/scripts/party.lua:Player@onMoveItem
data/events/scripts/player.lua:119: attempt to call method 'getSize' (a nil value)
stack traceback:
        [C]: in function 'getSize'
        data/events/scripts/player.lua:119: in function <data/events/scripts/player.lua:100>

function in player.lua,

function Player:onMoveItem(item, count, fromPosition, toPosition, fromCylinder, toCylinder)

    if toPosition.x ~= CONTAINER_POSITION then
        return true
    end

    if item:getTopParent() == self and bit.band(toPosition.y, 0x40) == 0 then
        local itemType, moveItem = ItemType(item:getId())
        if bit.band(itemType:getSlotPosition(), SLOTP_TWO_HAND) ~= 0 and toPosition.y == CONST_SLOT_LEFT then
            moveItem = self:getSlotItem(CONST_SLOT_RIGHT)
        elseif itemType:getWeaponType() == WEAPON_SHIELD and toPosition.y == CONST_SLOT_RIGHT then
            moveItem = self:getSlotItem(CONST_SLOT_LEFT)
            if moveItem and bit.band(ItemType(moveItem:getId()):getSlotPosition(), SLOTP_TWO_HAND) == 0 then
                return true
            end
        end

        if moveItem then
            local parent = item:getParent()
            if parent:getSize() == parent:getCapacity() then
                self:sendTextMessage(MESSAGE_STATUS_SMALL, Game.getReturnMessage(RETURNVALUE_CONTAINERNOTENOUGHROOM))
                return false
            else
                return moveItem:moveTo(parent)
            end
        end
    end

    return true
end

 

[Xikini]

Anyone know why is this error happening? I moved the bow from the right hand to the left and it appeared this error, the opposite does not happen error.

View attachment 36756

Lua Script Error: [Event Interface]
data/events/scripts/party.lua:Player@onMoveItem
data/events/scripts/player.lua:119: attempt to call method 'getSize' (a nil value)
stack traceback:
        [C]: in function 'getSize'
        data/events/scripts/player.lua:119: in function <data/events/scripts/player.lua:100>

function in player.lua,

function Player:onMoveItem(item, count, fromPosition, toPosition, fromCylinder, toCylinder)

    if toPosition.x ~= CONTAINER_POSITION then
        return true
    end

    if item:getTopParent() == self and bit.band(toPosition.y, 0x40) == 0 then
        local itemType, moveItem = ItemType(item:getId())
        if bit.band(itemType:getSlotPosition(), SLOTP_TWO_HAND) ~= 0 and toPosition.y == CONST_SLOT_LEFT then
            moveItem = self:getSlotItem(CONST_SLOT_RIGHT)
        elseif itemType:getWeaponType() == WEAPON_SHIELD and toPosition.y == CONST_SLOT_RIGHT then
            moveItem = self:getSlotItem(CONST_SLOT_LEFT)
            if moveItem and bit.band(ItemType(moveItem:getId()):getSlotPosition(), SLOTP_TWO_HAND) == 0 then
                return true
            end
        end

        if moveItem then
            local parent = item:getParent()
            if parent:getSize() == parent:getCapacity() then
                self:sendTextMessage(MESSAGE_STATUS_SMALL, Game.getReturnMessage(RETURNVALUE_CONTAINERNOTENOUGHROOM))
                return false
            else
                return moveItem:moveTo(parent)
            end
        end
    end

    return true
end

You're trying to get the size of a non-container item.
Confirm that the item is a container before attempting to get the size of it.

if parent:isContainer() and parent:getSize() == parent:getCapacity() then

 

[StreamSide]

also already merged

events/scripts/player.lua: Fix classicEquipmentSlots (#2596) · otland/forgottenserver@743481c

The problem occurs when you use classicEquipmentSlots, it happens as follows. 1 item in the left hand of two hands. 1 item in the arrow slot. I try to move this item on the arrow to the righ...

github.com

 

[lazarus321]

I replace for this code

function Player:onMoveItem(item, count, fromPosition, toPosition, fromCylinder, toCylinder)
    if toPosition.x ~= CONTAINER_POSITION then
        return true
    end

    if item:getTopParent() == self and bit.band(toPosition.y, 0x40) == 0 then
        local itemType, moveItem = ItemType(item:getId())
        if bit.band(itemType:getSlotPosition(), SLOTP_TWO_HAND) ~= 0 and toPosition.y == CONST_SLOT_LEFT then
            moveItem = self:getSlotItem(CONST_SLOT_RIGHT)
        elseif itemType:getWeaponType() == WEAPON_SHIELD and toPosition.y == CONST_SLOT_RIGHT then
            moveItem = self:getSlotItem(CONST_SLOT_LEFT)
            if moveItem and bit.band(ItemType(moveItem:getId()):getSlotPosition(), SLOTP_TWO_HAND) == 0 then
                return true
            end
        end

        if moveItem then
            local parent = item:getParent()
            if parent:isContainer() and parent:getSize() == parent:getCapacity() then
                self:sendTextMessage(MESSAGE_STATUS_SMALL, Game.getReturnMessage(RETURNVALUE_CONTAINERNOTENOUGHROOM))
                return false
            else
                return moveItem:moveTo(parent)
            end
        end
    end

    return true
end

and now get this error, where i can check this function?

Lua Script Error: [Event Interface]
data/events/scripts/party.lua:Player@onMoveItem
data/events/scripts/player.lua:118: attempt to call method 'isContainer' (a nil value)
stack traceback:
        [C]: in function 'isContainer'
        data/events/scripts/player.lua:118: in function <data/events/scripts/player.lua:100>

This error happens only for two-handed weapons, strange even replacing everything above.