Feature [TFS 1.2] Reflection attribute

sebaloko · Aug 14, 2018

@Vulcan_ sorry cant, the problem is that the items with the reflection attribute (added on items.xml) dont show the reflection on the description, but the ones that you do item:setAttribute(ITEM_ATTRIBUTE_REFLECTION,1) appears on description.

Infernum · Aug 14, 2018

i don't see any reason why that would be the case
iirc it worked both ways when i made this, but it's been over a year so maybe not
are you testing both cases on the same type of item, like an armor?

sebaloko · Aug 14, 2018

Vulcan_ said:
i don't see any reason why that would be the case
iirc it worked both ways when i made this, but it's been over a year so maybe not
are you testing both cases on the same type of item, like an armor?

yes maybe its because im using tfs 1.3?

Infernum · Aug 14, 2018

sebaloko said:
yes maybe its because im using tfs 1.3?

doubtful, i'll retest the code later to make sure it works

Mr Erimyth · Aug 28, 2018

Bug it crash my server, anyone can help me to fix? i need use it to tfs 1.3
>> Segmantation Fault

Infernum · Aug 29, 2018

"it crash my server"
let me pull out my crystal ball and tell you the exact solution
jokes aside you need to post more information, what you're doing before the crash, post gdb crash log

Colors · Aug 29, 2018

Vulcan_ said:
let me pull out my crystal ball and tell you the exact solution

Catalyst · Dec 7, 2018

This is kinda old but im trying to make it work for TFS 1.3 and i keep getting the following error when I try to compile.

Code:

/item.cpp:911:44: error: variable ‘reflection’ set but not used [-Werror=unused-but-set-variable] int32_t attack, defense, extraDefense, reflection; ^

Code:

/item.cpp:947:8: error: ‘reflection’ was not declared in this scope if (reflection != 0) { ^

Infernum · Dec 7, 2018

Catalyst said:
This is kinda old but im trying to make it work for TFS 1.3 and i keep getting the following error when I try to compile.

Code:

/item.cpp:911:44: error: variable ‘reflection’ set but not used [-Werror=unused-but-set-variable] int32_t attack, defense, extraDefense, reflection; ^

Code:

/item.cpp:947:8: error: ‘reflection’ was not declared in this scope if (reflection != 0) { ^

you must've not copied the rest of it
reflection gets defined straight after that line

C++:

            int32_t attack, defense, extraDefense, reflection;
            if (item) {
                attack = item->getAttack();
                defense = item->getDefense();
                extraDefense = item->getExtraDefense();
                reflection = item->getReflection();
            } else {
                attack = it.attack;
                defense = it.defense;
                extraDefense = it.extraDefense;
                reflection = it.reflection;
            }

Catalyst · Dec 14, 2018

Stigma said:

you must've not copied the rest of it
reflection gets defined straight after that line

C++:

            int32_t attack, defense, extraDefense, reflection;
            if (item) {
                attack = item->getAttack();
                defense = item->getDefense();
                extraDefense = item->getExtraDefense();
                reflection = item->getReflection();
            } else {
                attack = it.attack;
                defense = it.defense;
                extraDefense = it.extraDefense;
                reflection = it.reflection;
            }

Still didn't get it to work, can you help? Heres my item.cpp

/** * The Forgotten Server - a free and open-source MMORPG server emulator * - Pastebin.com

diarmaint · Feb 23, 2019

sebaloko said:
Hi vulcan the reflection attribute works great, but i can get to work it to appear on description

Code:

if (reflection != 0) { if (begin) { begin = false; s << " ("; } else { s << ", "; } s << "Reflection: " << reflection << std::noshowpos << "%"; }

thanks in advance
[CITAR]
I Need

jel · Mar 7, 2019

fix crash?

115820 · Dec 22, 2019

Delusion said:
i don't see any reason why that would be the case
iirc it worked both ways when i made this, but it's been over a year so maybe not
are you testing both cases on the same type of item, like an armor?

Hey, here too dont show when i do look in item, i put reflection in all part of my set (armor, helmet, legs, boots, ring, ring and weapons) and dont show description

##EDIT
Only show in weapons and shields. For all items use this

After if (it.abilities->speed)
search all line with this
put this:

Code:

                if (it.reflection != 0) {
                    if (begin) {
                        begin = false;
                        s << " (";
                    }
                    else {
                        s << ", ";
                    }

                    s << "Reflection: " << it.reflection << std::noshowpos << "%";

                }

Ramon Bernardo · Dec 27, 2019

When passing over a fire field, the server closes. can fix it?

Infernum · Dec 27, 2019

Ramon Bernardo said:
When passing over a fire field, the server closes. can fix it?

Check the very end of the main post.

Ramon Bernardo · Dec 27, 2019

Delusion said:
Check the very end of the main post.

I remember I put that function LOL. Thanks

115820 · Jan 3, 2020

@Delusion how i put to player see onLook all reflect %??

I put 10% in my set (helmet, armor, legs, boots), and when i do look in myself or other player i want see the all %. How i do this?

115820 · Jan 9, 2020

@Delusion How i change this for storage???

###EDIT

NO NEED MORE. i GOT THIS.

theduck · Jan 21, 2020

is it possible to use this for monsters? nowadays in tibia some monsters have this effect

Guerra · Aug 29, 2020

Infernum said:

enums.h

under the last attribute in itemAttrTypes (ITEM_ATTRIBUTE_DOORID = 1 << 22, if you haven't edited it, and use the number after << + 1 for reflection)

C++:

ITEM_ATTRIBUTE_REFLECTION = 1 << 23,

under ORIGIN_RANGED in CombatOrigin

C++:

ORIGIN_REFLECT,

item.h

in:

C++:

inline static bool isIntAttrType

take the hex value (default is 0x7FFE13) and use bitwise or ( | ) with (1 << 23) and replace the hex with the new value you get (you can do this at Lua: demo) with this code:

LUA:

print(string.format("0x%x", 0x7FFE13 | (1 << 23)))

you should now get 0xFFFE13, replace the value in isIntAttrType with the new hex value we have

under int8_t getHitChance, put:

C++:

        int32_t getReflection() const {
            if (hasAttribute(ITEM_ATTRIBUTE_REFLECTION)) {
                return getIntAttr(ITEM_ATTRIBUTE_REFLECTION);
            }
            return items[id].reflection;
        }

item.cpp

find this code:

C++:

            int32_t attack, defense, extraDefense;
            if (item) {
                attack = item->getAttack();
                defense = item->getDefense();
                extraDefense = item->getExtraDefense();
            } else {
                attack = it.attack;
                defense = it.defense;
                extraDefense = it.extraDefense;
            }

replace it with:

C++:

            int32_t attack, defense, extraDefense, reflection;
            if (item) {
                attack = item->getAttack();
                defense = item->getDefense();
                extraDefense = item->getExtraDefense();
                reflection = item->getReflection();
            } else {
                attack = it.attack;
                defense = it.defense;
                extraDefense = it.extraDefense;
                reflection = it.reflection;
            }

find this piece of code (should be around line 896)

C++:

            if (defense != 0 || extraDefense != 0) {
                if (begin) {
                    begin = false;
                    s << " (";
                } else {
                    s << ", ";
                }

                s << "Def:" << defense;
                if (extraDefense != 0) {
                    s << ' ' << std::showpos << extraDefense << std::noshowpos;
                }
            }

and put this below the code above

C++:

            if (reflection != 0) {
                if (begin) {
                    begin = false;
                    s << " (";
                } else {
                    s << ", ";
                }
             
                s << "Reflection: " << reflection << std::noshowpos << "%";

            }

items.h

under

C++:

int32_t defense = 0;

put

C++:

int32_t reflection = 0;

items.cpp

find:

C++:

        } else if (tmpStrValue == "defense") {
            it.defense = pugi::cast<int32_t>(valueAttribute.value());

put this under it:

C++:

        } else if (tmpStrValue == "reflect") {
            it.reflection = pugi::cast<int32_t>(valueAttribute.value());

player.h

under

C++:

int32_t getArmor() const final;

put

C++:

int32_t getReflection() const;

player.cpp

under:

C++:

int32_t Player::getArmor() const
{
    int32_t armor = 0;

    static const slots_t armorSlots[] = {CONST_SLOT_HEAD, CONST_SLOT_NECKLACE, CONST_SLOT_ARMOR, CONST_SLOT_LEGS, CONST_SLOT_FEET, CONST_SLOT_RING};
    for (slots_t slot : armorSlots) {
        Item* inventoryItem = inventory[slot];
        if (inventoryItem) {
            armor += inventoryItem->getArmor();
        }
    }
    return static_cast<int32_t>(armor * vocation->armorMultiplier);
}

put:

C++:

int32_t Player::getReflection() const
{
    int32_t reflection = 0;

    static const slots_t armorSlots[] = { CONST_SLOT_HEAD, CONST_SLOT_NECKLACE, CONST_SLOT_ARMOR, CONST_SLOT_LEGS, CONST_SLOT_FEET, CONST_SLOT_RING, CONST_SLOT_LEFT, CONST_SLOT_RIGHT };
    for (slots_t slot : armorSlots) {
        Item* inventoryItem = inventory[slot];
        if (inventoryItem) {
            reflection += inventoryItem->getReflection();
        }
    }
    return reflection;
}

game.cpp

inside of

C++:

bool Game::combatChangeHealth(Creature* attacker, Creature* target, CombatDamage& damage)

under:

C++:

target->drainMana(attacker, manaDamage);

put:

C++:

                // mana reflect
                if (targetPlayer && damage.origin != ORIGIN_REFLECT) {
                    int32_t reflection = targetPlayer->getReflection();
                    if (reflection != 0) {
                        CombatDamage reflectDamage;
                        reflectDamage.primary.value = static_cast<int32_t>(-damage.primary.value * (reflection / 100.0));
                        reflectDamage.secondary.value = static_cast<int32_t>(-damage.secondary.value * (reflection / 100.0));
                        reflectDamage.primary.type = damage.primary.type;
                        reflectDamage.secondary.type = damage.secondary.type;
                        reflectDamage.origin = ORIGIN_REFLECT; // create a new origin ORIGIN_REFLECT to avoid infinite reflection between 2 players
                        combatChangeHealth(target, attacker, reflectDamage);
                    }
                }

under: target->drainHealth(attacker, realDamage);
put:

C++:

        // reflect health
        if (targetPlayer && damage.origin != ORIGIN_REFLECT) {
            int32_t reflection = targetPlayer->getReflection();
            if (reflection != 0) {
                CombatDamage reflectDamage;
                reflectDamage.primary.value = static_cast<int32_t>(-damage.primary.value * (reflection / 100.0));
                reflectDamage.secondary.value = static_cast<int32_t>(-damage.secondary.value * (reflection / 100.0));
                reflectDamage.primary.type = damage.primary.type;
                reflectDamage.secondary.type = damage.secondary.type;
                reflectDamage.origin = ORIGIN_REFLECT;
                combatChangeHealth(target, attacker, reflectDamage);
            }
        }

the rest of the code is for scripting purposes, so this isn't 100% necessary if you aren't planning on tampering with reflection using lua

luascript.h

under:

C++:

static int luaItemTypeGetArmor(lua_State* L);

put:

C++:

static int luaItemTypeGetReflection(lua_State* L);

luascript.cpp

under:

C++:

registerEnum(ITEM_ATTRIBUTE_DOORID)

put:

C++:

registerEnum(ITEM_ATTRIBUTE_REFLECTION)

under:

C++:

registerEnum(ORIGIN_RANGED)

put:

C++:

registerEnum(ORIGIN_REFLECT)

under:

C++:

registerMethod("ItemType", "getArmor", LuaScriptInterface::luaItemTypeGetArmor);

put:

C++:

registerMethod("ItemType", "getReflection", LuaScriptInterface::luaItemTypeGetReflection);

under:

C++:

int LuaScriptInterface::luaItemTypeGetArmor(lua_State* L)
{
    // itemType:getArmor()
    const ItemType* itemType = getUserdata<const ItemType>(L, 1);
    if (itemType) {
        lua_pushnumber(L, itemType->armor);
    } else {
        lua_pushnil(L);
    }
    return 1;
}

put:

C++:

int LuaScriptInterface::luaItemTypeGetReflection(lua_State* L)
{
    // itemType:getReflection()
    const ItemType* itemType = getUserdata<const ItemType>(L, -1);
    if (itemType) {
        lua_pushnumber(L, itemType->reflection);
    } else {
        lua_pushnil(L);
    }
    return 1;
}

now you can use ITEM_ATTRIBUTE_REFLECTION, ORIGIN_REFLECT, and itemType:getReflection() in your scripts
you can set reflection inside of items.xml with:

XML:

<attribute key="reflect" value="10"/>

you can set reflection of items with lua using:

LUA:

item:setAttribute(ITEM_ATTRIBUTE_REFLECTION, 10)

also forgot, inside of game.cpp in bool Game::combatChangeHealth(Creature* attacker, Creature* target, CombatDamage& damage)
put

C++:

    if (!target) {
        return false;
    }

at the top of the function, otherwise it will crash when stepping on magic fields that damage you

hey man!!

can help me, I did everything just like the tutorial but when restarting my server the error below.

Feature [TFS 1.2] Reflection attribute

Member

︈

Member

︈

Member

︈

♥

whoU

︈

whoU

New Member

Member

Member

Well-Known Member

︈

Well-Known Member

Member

Member

Member

Member