TFS 1.2 setCreatureMetatable Crash

[Tbol]

Got this small information about crash, any suggestions what could be wrong?

---------------------------------------------------Signal caught: SIGSEGVwar - Pastebin.com

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

pastebin.com

 

[Tbol]

Still havent figured it out

 

[dchampag]

Still havent figured it out

This paste bin does not take us anywhere. But what is happening during the crash?

There is a guide for debugging. Follow it and then post here to get support.

 

[Mateus Robeerto]

The crash is likely caused by a Lua script issue, possibly due to using addEvent tied to a Player or Monster that no longer exists when the event executes. Check your scripts for any addEvent usage involving creatures and ensure proper validation before accessing them.

forgottenserver/src/luascript.cpp at 1.2 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

 

[dchampag]

The crash is likely caused by a Lua script issue, possibly due to using addEvent tied to a Player or Monster that no longer exists when the event executes. Check your scripts for any addEvent usage involving creatures and ensure proper validation before accessing them.

forgottenserver/src/luascript.cpp at 1.2 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

As I can tell you are new to this or still learning, what it means by proper validation is add code to check if the player exists before starting the other code.

Example

if creature:isPlayer then
--code
end

The if statement will need to be changed based on what it is the code is looking for, item, monster blah blah.

 

[Tbol]

Shit there is quite a lot of addevent scripts to find which one exactly

 

[dchampag]

Well, when did this start happening? Did you make changes or have the players progressed to a certain point? Let’s narrow it down.

 

[Tbol]

Well, when did this start happening? Did you make changes or have the players progressed to a certain point? Let’s narrow it down.

The problem is that i dont know how it happens or when it happens or if its old or now crash, probably old one but wasnt triggered for a while

 

[dchampag]

I would try running in debug mode and hope that it happens again to help narrow it down. Then, If not I’m not seeing anything directing you towards exactly it’s located, you’ll have to go through them all. Or potentially use AI and see if they can find it

 

[Nekiro]

The crash is likely caused by a Lua script issue, possibly due to using addEvent tied to a Player or Monster that no longer exists when the event executes. Check your scripts for any addEvent usage involving creatures and ensure proper validation before accessing them.

forgottenserver/src/luascript.cpp at 1.2 · otland/forgottenserver

A free and open-source MMORPG server emulator written in C++ - otland/forgottenserver

github.com

^ is right.

executeTimerEvent Is lua addEvent, likely tried to use deleted userdata, there is no easy way of finding that, search for all addEvent and check them.

 

[Gesior.pl]

search for all addEvent and check them.

What to search for:
There are 2 cases when addEvent crashes OTS:

• script passed object Player/Monster/Item/Container as parameter, that does not exist in moment, when addEvent executes
• function called by addEvent uses variable from outer scope that points to object Player/Monster/Item/Container that does not exist in moment, when addEvent executes

Examples:

[TFS 1.x+] How to NOT write LUA scripts or how to crash server by LUA script – HALP!

 

[Dakos]

also when you finally get whats the problem, here is usefull tutorial that explaining how to properly use addEvent

Thread '[How-to] Using addEvent()'

Dec 4, 2014

I'm gonna get straight to the point and make this very simple. I had a thread already written up before this one, but I got too complex, if you want to get into the more complex stuff, feel free to post here, we can talk about it. Making this tutorial complex to understand is not my goal.

So, what is addEvent()?
It is a method that calls a function or evaluates an expression after a specified number of milliseconds.
In layman's terms, it runs code after X milliseconds.

Quick reminders:

• 1000 milliseconds = 1...

• Evan
• Replies: 21
• Forum: Programming & Scripting

• 
• 

 

[Mateus Robeerto]

Shit there is quite a lot of addevent scripts to find which one exactly

Here’s what you should do: download and install the VSCode program on your PC. Next, open it, select your server folder, and type addEvent in the search bar. You’ll find several files. This will help you identify which one is causing the crash—whether it’s related to spells, onUse, certain scripts you’re using with addEvents, or NPCs using a poorly optimized addEvent. It’s important to carefully review each file. Follow the tutorial on gesior.pl, as it explains everything in detail. It’s not difficult.

Alternatively, the issue might be this: the script is passing a Creature userdata object instead of a Creature ID, which is why it’s crashing. It’s a bit misleading to use cid as an identifier in the argument list when it should actually be called creature.

If you want addEvent to trigger on a player even after they log out, you need to recreate the player object correctly. Instead of using player:getId(), you should use player:getGuid().

The guid is permanent. So, when the player logs in and out, the addEvent will still trigger. By recreating the player object using the Guid, it will successfully find the player.